dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #111762 - bvanjoi:fix-111749, r=compiler-errors 

fix: emit error when fragment is `MethodReceiverExpr` and items is empty

Fixes https://github.com/rust-lang/rust/issues/111749
This commit is contained in:
Dylan DPC 2023-05-20 12:21:02 +05:30 committed by GitHub
parent 9074769dc5 990b2899ad
commit 94ca44a50a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/rustc_expand/src/expand.rs
View File

@ -722,7 +722,11 @@ impl<'a, 'b> MacroExpander<'a, 'b> {
});
}
};
if fragment_kind == AstFragmentKind::Expr && items.is_empty() {
if matches!(
fragment_kind,
AstFragmentKind::Expr | AstFragmentKind::MethodReceiverExpr
) && items.is_empty()
{
self.cx.emit_err(RemoveExprNotSupported { span });
fragment_kind.dummy(span)
} else {

12
tests/ui/macros/issue-111749.rs Normal file
View File

@ -0,0 +1,12 @@
macro_rules! cbor_map {
($key:expr) => {
$key.signum();
};
}
fn main() {
cbor_map! { #[test(test)] 4};
//~^ ERROR removing an expression is not supported in this position
//~| ERROR attribute must be of the form `#[test]`
//~| WARNING this was previously accepted by the compiler but is being phased out
}

18
tests/ui/macros/issue-111749.stderr Normal file
View File

@ -0,0 +1,18 @@
error: removing an expression is not supported in this position
--> $DIR/issue-111749.rs:8:17
|
LL | cbor_map! { #[test(test)] 4};
| ^^^^^^^^^^^^^
error: attribute must be of the form `#[test]`
--> $DIR/issue-111749.rs:8:17
|
LL | cbor_map! { #[test(test)] 4};
| ^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #57571 <https://github.com/rust-lang/rust/issues/57571>
= note: `#[deny(ill_formed_attribute_input)]` on by default
error: aborting due to 2 previous errors