dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clarify the `usage-of-qualified-ty` error message. 

I found this message confusing when I encountered it. This commit makes
it clearer that you have to import the unqualified type yourself.
This commit is contained in:
Nicholas Nethercote 2022-01-27 11:10:37 +11:00
parent 84322efad5
commit 696d5034b2
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compiler/rustc_lint/src/internal.rs
View File

@ -108,7 +108,7 @@ impl<'tcx> LateLintPass<'tcx> for TyTyKind {
lint.build(&format!("usage of qualified `ty::{}`", t)) lint.build(&format!("usage of qualified `ty::{}`", t))
.span_suggestion( .span_suggestion(
path.span, path.span,
"try using it unqualified", "try importing it and using it unqualified",
t, t,
// The import probably needs to be changed // The import probably needs to be changed
Applicability::MaybeIncorrect, Applicability::MaybeIncorrect,

4
src/test/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.stderr
View File

@ -2,7 +2,7 @@ error: usage of qualified `ty::Ty<'_>`
--> $DIR/qualified_ty_ty_ctxt.rs:25:11 --> $DIR/qualified_ty_ty_ctxt.rs:25:11
| |
LL | ty_q: ty::Ty<'_>, LL | ty_q: ty::Ty<'_>,
| ^^^^^^^^^^ help: try using it unqualified: `Ty<'_>` | ^^^^^^^^^^ help: try importing it and using it unqualified: `Ty<'_>`
| |
note: the lint level is defined here note: the lint level is defined here
--> $DIR/qualified_ty_ty_ctxt.rs:4:9 --> $DIR/qualified_ty_ty_ctxt.rs:4:9
@ -14,7 +14,7 @@ error: usage of qualified `ty::TyCtxt<'_>`
--> $DIR/qualified_ty_ty_ctxt.rs:27:16 --> $DIR/qualified_ty_ty_ctxt.rs:27:16
| |
LL | ty_ctxt_q: ty::TyCtxt<'_>, LL | ty_ctxt_q: ty::TyCtxt<'_>,
| ^^^^^^^^^^^^^^ help: try using it unqualified: `TyCtxt<'_>` | ^^^^^^^^^^^^^^ help: try importing it and using it unqualified: `TyCtxt<'_>`
error: aborting due to 2 previous errors error: aborting due to 2 previous errors