698: Added support for primitive types type inference with std::ops::Not r=flodiebold a=WizardOfMenlo

On the guideline of #544 , this allows for type inference for all primitive types implementing [std::ops::Not](https://doc.rust-lang.org/beta/std/ops/trait.Not.html). I think this should be relevant #394 as well?

Co-authored-by: WizardOfMenlo <giacomofenzi@outlook.com>
This commit is contained in:
bors[bot] 2019-01-28 20:43:13 +00:00
commit 48d2acb297
3 changed files with 37 additions and 15 deletions

View File

@ -1588,9 +1588,13 @@ impl<'a, D: HirDatabase> InferenceContext<'a, D> {
_ => Ty::Unknown,
}
}
UnaryOp::Not if inner_ty == Ty::Bool => Ty::Bool,
// TODO: resolve ops::Not trait for inner_ty
UnaryOp::Not => Ty::Unknown,
UnaryOp::Not => {
match inner_ty {
Ty::Bool | Ty::Int(_) | Ty::Infer(InferTy::IntVar(..)) => inner_ty,
// TODO: resolve ops::Not trait for inner_ty
_ => Ty::Unknown,
}
}
}
}
Expr::BinaryOp { lhs, rhs, op } => match op {

View File

@ -1,11 +1,11 @@
---
created: "2019-01-22T14:45:00.059676600+00:00"
creator: insta@0.4.0
created: "2019-01-28T14:51:16.185273502+00:00"
creator: insta@0.5.2
expression: "&result"
source: "crates\\ra_hir\\src\\ty\\tests.rs"
source: crates/ra_hir/src/ty/tests.rs
---
[27; 28) 'x': SomeType
[40; 197) '{ ...lo"; }': ()
[40; 272) '{ ...lo"; }': ()
[50; 51) 'b': bool
[54; 59) 'false': bool
[69; 70) 'c': bool
@ -24,12 +24,25 @@ source: "crates\\ra_hir\\src\\ty\\tests.rs"
[147; 153) '!!true': bool
[148; 153) '!true': bool
[149; 153) 'true': bool
[159; 164) '-3.14': f64
[160; 164) '3.14': f64
[170; 172) '-x': [unknown]
[171; 172) 'x': SomeType
[178; 180) '!x': [unknown]
[179; 180) 'x': SomeType
[186; 194) '-"hello"': [unknown]
[187; 194) '"hello"': &str
[163; 164) 'g': i32
[167; 170) '!42': i32
[168; 170) '42': i32
[180; 181) 'h': u32
[184; 190) '!10u32': u32
[185; 190) '10u32': u32
[200; 201) 'j': i128
[204; 206) '!a': i128
[205; 206) 'a': i128
[212; 217) '-3.14': f64
[213; 217) '3.14': f64
[223; 225) '!3': i32
[224; 225) '3': i32
[231; 233) '-x': [unknown]
[232; 233) 'x': SomeType
[239; 241) '!x': [unknown]
[240; 241) 'x': SomeType
[247; 255) '-"hello"': [unknown]
[248; 255) '"hello"': &str
[261; 269) '!"hello"': [unknown]
[262; 269) '"hello"': &str

View File

@ -166,10 +166,15 @@ fn test(x: SomeType) {
let d: i128 = -a;
let e = -100;
let f = !!!true;
let g = !42;
let h = !10u32;
let j = !a;
-3.14;
!3;
-x;
!x;
-"hello";
!"hello";
}
"#,
);