dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add FIXME for making the cargo cmd properly typed

This commit is contained in:
Ralf Jung 2024-03-30 15:09:38 +01:00
parent 288daeb14f
commit 4797fba3b7
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/bootstrap/src/core/builder.rs
View File

@ -1318,7 +1318,7 @@ impl<'a> Builder<'a> {
compiler: Compiler,
mode: Mode,
target: TargetSelection,
cmd: &str,
cmd: &str, // FIXME make this properly typed
) -> Command {
let mut cargo;
if cmd == "clippy" {
@ -1392,7 +1392,7 @@ impl<'a> Builder<'a> {
mode: Mode,
source_type: SourceType,
target: TargetSelection,
cmd: &str,
cmd: &str, // FIXME make this properly typed
) -> Cargo {
let mut cargo = self.bare_cargo(compiler, mode, target, cmd);
let out_dir = self.stage_out(compiler, mode);
@ -2100,7 +2100,7 @@ impl<'a> Builder<'a> {
rustflags.arg("-Zinline-mir");
}
if builder.config.rustc_parallel
if self.config.rustc_parallel
&& matches!(mode, Mode::ToolRustc | Mode::Rustc | Mode::Codegen)
{
// keep in sync with `bootstrap/lib.rs:Build::rustc_features`
@ -2342,7 +2342,7 @@ impl Cargo {
mode: Mode,
source_type: SourceType,
target: TargetSelection,
cmd: &str,
cmd: &str, // FIXME make this properly typed
) -> Cargo {
let mut cargo = builder.cargo(compiler, mode, source_type, target, cmd);
cargo.configure_linker(builder);
@ -2356,7 +2356,7 @@ impl Cargo {
mode: Mode,
source_type: SourceType,
target: TargetSelection,
cmd: &str,
cmd: &str, // FIXME make this properly typed
) -> Cargo {
builder.cargo(compiler, mode, source_type, target, cmd)
}