dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor function

This commit is contained in:
gnzlbg 2018-07-05 01:53:40 +02:00
parent 14cbdf2607
commit 3fec3b47b6
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clippy_lints/src/missing_inline.rs
View File

@ -67,8 +67,7 @@ declare_clippy_lint! {
pub struct MissingInline;
impl MissingInline {
fn check_missing_inline_attrs(&self, cx: &LateContext,
fn check_missing_inline_attrs(cx: &LateContext,
attrs: &[ast::Attribute], sp: Span, desc: &'static str) {
let has_inline = attrs
.iter()
@ -81,7 +80,6 @@ impl MissingInline {
);
}
}
}
fn is_executable<'a, 'tcx>(cx: &LateContext<'a, 'tcx>) -> bool {
use rustc::session::config::CrateType;
@ -112,7 +110,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingInline {
match it.node {
hir::ItemFn(..) => {
let desc = "a function";
self.check_missing_inline_attrs(cx, &it.attrs, it.span, desc);
check_missing_inline_attrs(cx, &it.attrs, it.span, desc);
},
hir::ItemTrait(ref _is_auto, ref _unsafe, ref _generics,
ref _bounds, ref trait_items) => {
@ -129,7 +127,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingInline {
// an impl is not provided
let desc = "a default trait method";
let item = cx.tcx.hir.expect_trait_item(tit.id.node_id);
self.check_missing_inline_attrs(cx, &item.attrs,
check_missing_inline_attrs(cx, &item.attrs,
item.span, desc);
}
},
@ -195,6 +193,6 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingInline {
},
}
self.check_missing_inline_attrs(cx, &impl_item.attrs, impl_item.span, desc);
check_missing_inline_attrs(cx, &impl_item.attrs, impl_item.span, desc);
}
}