Add 'positive' examples for some lints

This allows to see at a quick glance what the improved code could look
like for these lints.
This commit is contained in:
Philipp Hansch 2018-01-08 10:17:05 +01:00
parent 5815681b38
commit 1a16ac058d
No known key found for this signature in database
GPG Key ID: 667C8F4B5A698A60
1 changed files with 26 additions and 0 deletions

View File

@ -36,6 +36,14 @@ pub struct TypePass;
/// values: Box<Vec<Foo>>,
/// }
/// ```
///
/// Better:
///
/// ```rust
/// struct X {
/// values: Vec<Foo>,
/// }
/// ```
declare_lint! {
pub BOX_VEC,
Warn,
@ -89,6 +97,12 @@ declare_lint! {
/// ```rust
/// fn foo(bar: &Box<T>) { ... }
/// ```
///
/// Better:
///
/// ```rust
/// fn foo(bar: &T) { ... }
/// ```
declare_lint! {
pub BORROWED_BOX,
Warn,
@ -514,6 +528,12 @@ declare_lint! {
/// ```rust
/// fn as_u64(x: u8) -> u64 { x as u64 }
/// ```
///
/// Using `::from` would look like this:
///
/// ```rust
/// fn as_u64(x: u8) -> u64 { u64::from(x) }
/// ```
declare_lint! {
pub CAST_LOSSLESS,
Warn,
@ -994,6 +1014,12 @@ impl<'tcx> Visitor<'tcx> for TypeComplexityVisitor {
/// ```rust
/// 'x' as u8
/// ```
///
/// A better version, using the byte literal:
///
/// ```rust
/// b'x'
/// ```
declare_lint! {
pub CHAR_LIT_AS_U8,
Warn,