dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmp_owned current suggestion for multiple deref

This commit is contained in:
Josh Mcguigan 2018-10-11 05:03:02 -07:00
parent d41615548e
commit 0b65462ca5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/misc.rs
View File

@ -546,7 +546,7 @@ fn check_to_owned(cx: &LateContext<'_, '_>, expr: &Expr, other: &Expr) {
} else if other_gets_derefed {
// suggest dropping the to_owned on the left and the deref on the right
let other_snippet = snippet(cx, other.span, "..").into_owned();
let other_without_deref = other_snippet.trim_left_matches('*');
let other_without_deref = other_snippet.replacen('*', "", 1);
(expr.span.to(other.span), format!("{} == {}", snip.to_string(), other_without_deref))
} else {

2
tests/ui/cmp_owned.stderr
View File

@ -46,7 +46,7 @@ error: this creates an owned instance just for comparison
--> $DIR/cmp_owned.rs:47:5
|
47 | y.to_owned() == **x;
| ^^^^^^^^^^^^^^^^^^^ help: try: `y == x`
| ^^^^^^^^^^^^^^^^^^^ help: try: `y == *x`
error: this creates an owned instance just for comparison
--> $DIR/cmp_owned.rs:54:9