Update non_fmt_panics test.

This commit is contained in:
Mara Bos 2021-08-16 17:26:08 +02:00
parent 0a313250a4
commit 00ca4d0dd3
3 changed files with 68 additions and 15 deletions

View File

@ -17,11 +17,16 @@ fn main() {
//~^ WARN panic message contains unused formatting placeholders //~^ WARN panic message contains unused formatting placeholders
assert!(false, "{}", S); assert!(false, "{}", S);
//~^ WARN panic message is not a string literal //~^ WARN panic message is not a string literal
assert!(false, "{}", 123);
//~^ WARN panic message is not a string literal
assert!(false, "{:?}", Some(123));
//~^ WARN panic message is not a string literal
debug_assert!(false, "{}", "{{}} bla"); //~ WARN panic message contains braces debug_assert!(false, "{}", "{{}} bla"); //~ WARN panic message contains braces
panic!("{}", C); //~ WARN panic message is not a string literal panic!("{}", C); //~ WARN panic message is not a string literal
panic!("{}", S); //~ WARN panic message is not a string literal panic!("{}", S); //~ WARN panic message is not a string literal
std::panic::panic_any(123); //~ WARN panic message is not a string literal std::panic::panic_any(123); //~ WARN panic message is not a string literal
core::panic!("{}", &*"abc"); //~ WARN panic message is not a string literal core::panic!("{}", &*"abc"); //~ WARN panic message is not a string literal
std::panic::panic_any(Some(123)); //~ WARN panic message is not a string literal
panic!("{}", concat!("{", "}")); //~ WARN panic message contains an unused formatting placeholder panic!("{}", concat!("{", "}")); //~ WARN panic message contains an unused formatting placeholder
panic!("{}", concat!("{", "{")); //~ WARN panic message contains braces panic!("{}", concat!("{", "{")); //~ WARN panic message contains braces

View File

@ -17,11 +17,16 @@ fn main() {
//~^ WARN panic message contains unused formatting placeholders //~^ WARN panic message contains unused formatting placeholders
assert!(false, S); assert!(false, S);
//~^ WARN panic message is not a string literal //~^ WARN panic message is not a string literal
assert!(false, 123);
//~^ WARN panic message is not a string literal
assert!(false, Some(123));
//~^ WARN panic message is not a string literal
debug_assert!(false, "{{}} bla"); //~ WARN panic message contains braces debug_assert!(false, "{{}} bla"); //~ WARN panic message contains braces
panic!(C); //~ WARN panic message is not a string literal panic!(C); //~ WARN panic message is not a string literal
panic!(S); //~ WARN panic message is not a string literal panic!(S); //~ WARN panic message is not a string literal
std::panic!(123); //~ WARN panic message is not a string literal std::panic!(123); //~ WARN panic message is not a string literal
core::panic!(&*"abc"); //~ WARN panic message is not a string literal core::panic!(&*"abc"); //~ WARN panic message is not a string literal
panic!(Some(123)); //~ WARN panic message is not a string literal
panic!(concat!("{", "}")); //~ WARN panic message contains an unused formatting placeholder panic!(concat!("{", "}")); //~ WARN panic message contains an unused formatting placeholder
panic!(concat!("{", "{")); //~ WARN panic message contains braces panic!(concat!("{", "{")); //~ WARN panic message contains braces

View File

@ -68,8 +68,34 @@ help: add a "{}" format string to Display the message
LL | assert!(false, "{}", S); LL | assert!(false, "{}", S);
| +++++ | +++++
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:20:20
|
LL | assert!(false, 123);
| ^^^
|
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
help: add a "{}" format string to Display the message
|
LL | assert!(false, "{}", 123);
| +++++
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:22:20
|
LL | assert!(false, Some(123));
| ^^^^^^^^^
|
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
help: add a "{:?}" format string to use the Debug implementation of `Option<i32>`
|
LL | assert!(false, "{:?}", Some(123));
| +++++++
warning: panic message contains braces warning: panic message contains braces
--> $DIR/non-fmt-panic.rs:20:27 --> $DIR/non-fmt-panic.rs:24:27
| |
LL | debug_assert!(false, "{{}} bla"); LL | debug_assert!(false, "{{}} bla");
| ^^^^ | ^^^^
@ -81,7 +107,7 @@ LL | debug_assert!(false, "{}", "{{}} bla");
| +++++ | +++++
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:21:12 --> $DIR/non-fmt-panic.rs:25:12
| |
LL | panic!(C); LL | panic!(C);
| ^ | ^
@ -94,7 +120,7 @@ LL | panic!("{}", C);
| +++++ | +++++
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:22:12 --> $DIR/non-fmt-panic.rs:26:12
| |
LL | panic!(S); LL | panic!(S);
| ^ | ^
@ -107,7 +133,7 @@ LL | panic!("{}", S);
| +++++ | +++++
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:23:17 --> $DIR/non-fmt-panic.rs:27:17
| |
LL | std::panic!(123); LL | std::panic!(123);
| ^^^ | ^^^
@ -124,7 +150,7 @@ LL | std::panic::panic_any(123);
| ~~~~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~~~~~~~
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:24:18 --> $DIR/non-fmt-panic.rs:28:18
| |
LL | core::panic!(&*"abc"); LL | core::panic!(&*"abc");
| ^^^^^^^ | ^^^^^^^
@ -136,8 +162,25 @@ help: add a "{}" format string to Display the message
LL | core::panic!("{}", &*"abc"); LL | core::panic!("{}", &*"abc");
| +++++ | +++++
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:29:12
|
LL | panic!(Some(123));
| ^^^^^^^^^
|
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
help: add a "{:?}" format string to use the Debug implementation of `Option<i32>`
|
LL | panic!("{:?}", Some(123));
| +++++++
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(Some(123));
| ~~~~~~~~~~~~~~~~~~~~~
warning: panic message contains an unused formatting placeholder warning: panic message contains an unused formatting placeholder
--> $DIR/non-fmt-panic.rs:25:12 --> $DIR/non-fmt-panic.rs:30:12
| |
LL | panic!(concat!("{", "}")); LL | panic!(concat!("{", "}"));
| ^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^
@ -153,7 +196,7 @@ LL | panic!("{}", concat!("{", "}"));
| +++++ | +++++
warning: panic message contains braces warning: panic message contains braces
--> $DIR/non-fmt-panic.rs:26:5 --> $DIR/non-fmt-panic.rs:31:5
| |
LL | panic!(concat!("{", "{")); LL | panic!(concat!("{", "{"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -165,7 +208,7 @@ LL | panic!("{}", concat!("{", "{"));
| +++++ | +++++
warning: panic message contains an unused formatting placeholder warning: panic message contains an unused formatting placeholder
--> $DIR/non-fmt-panic.rs:28:37 --> $DIR/non-fmt-panic.rs:33:37
| |
LL | fancy_panic::fancy_panic!("test {} 123"); LL | fancy_panic::fancy_panic!("test {} 123");
| ^^ | ^^
@ -173,7 +216,7 @@ LL | fancy_panic::fancy_panic!("test {} 123");
= note: this message is not used as a format string when given without arguments, but will be in Rust 2021 = note: this message is not used as a format string when given without arguments, but will be in Rust 2021
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:38:12 --> $DIR/non-fmt-panic.rs:43:12
| |
LL | panic!(a!()); LL | panic!(a!());
| ^^^^ | ^^^^
@ -190,7 +233,7 @@ LL | std::panic::panic_any(a!());
| ~~~~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~~~~~~~
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:40:12 --> $DIR/non-fmt-panic.rs:45:12
| |
LL | panic!(format!("{}", 1)); LL | panic!(format!("{}", 1));
| ^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^
@ -205,7 +248,7 @@ LL + panic!("{}", 1);
| |
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:41:20 --> $DIR/non-fmt-panic.rs:46:20
| |
LL | assert!(false, format!("{}", 1)); LL | assert!(false, format!("{}", 1));
| ^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^
@ -220,7 +263,7 @@ LL + assert!(false, "{}", 1);
| |
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:42:26 --> $DIR/non-fmt-panic.rs:47:26
| |
LL | debug_assert!(false, format!("{}", 1)); LL | debug_assert!(false, format!("{}", 1));
| ^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^
@ -235,7 +278,7 @@ LL + debug_assert!(false, "{}", 1);
| |
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:44:12 --> $DIR/non-fmt-panic.rs:49:12
| |
LL | panic![123]; LL | panic![123];
| ^^^ | ^^^
@ -252,7 +295,7 @@ LL | std::panic::panic_any(123);
| ~~~~~~~~~~~~~~~~~~~~~~ ~ | ~~~~~~~~~~~~~~~~~~~~~~ ~
warning: panic message is not a string literal warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:45:12 --> $DIR/non-fmt-panic.rs:50:12
| |
LL | panic!{123}; LL | panic!{123};
| ^^^ | ^^^
@ -268,5 +311,5 @@ help: or use std::panic::panic_any instead
LL | std::panic::panic_any(123); LL | std::panic::panic_any(123);
| ~~~~~~~~~~~~~~~~~~~~~~ ~ | ~~~~~~~~~~~~~~~~~~~~~~ ~
warning: 19 warnings emitted warning: 22 warnings emitted