dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
rust/tests/ui/check-static-values-constra...

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

123 lines
3.4 KiB
Rust
Raw Normal View History

test: Convert statics to constants Additionally, add lots of tests for new functionality around statics and `static mut`.
2014-10-07 12:16:35 +08:00
// Verifies all possible restrictions for statics values.
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
rustc: Rearchitect lints to be emitted more eagerly In preparation for incremental compilation this commit refactors the lint handling infrastructure in the compiler to be more "eager" and overall more incremental-friendly. Many passes of the compiler can emit lints at various points but before this commit all lints were buffered in a table to be emitted at the very end of compilation. This commit changes these lints to be emitted immediately during compilation using pre-calculated lint level-related data structures. Linting today is split into two phases, one set of "early" lints run on the `syntax::ast` and a "late" set of lints run on the HIR. This commit moves the "early" lints to running as late as possible in compilation, just before HIR lowering. This notably means that we're catching resolve-related lints just before HIR lowering. The early linting remains a pass very similar to how it was before, maintaining context of the current lint level as it walks the tree. Post-HIR, however, linting is structured as a method on the `TyCtxt` which transitively executes a query to calculate lint levels. Each request to lint on a `TyCtxt` will query the entire crate's 'lint level data structure' and then go from there about whether the lint should be emitted or not. The query depends on the entire HIR crate but should be very quick to calculate (just a quick walk of the HIR) and the red-green system should notice that the lint level data structure rarely changes, and should hopefully preserve incrementality. Overall this resulted in a pretty big change to the test suite now that lints are emitted much earlier in compilation (on-demand vs only at the end). This in turn necessitated the addition of many `#![allow(warnings)]` directives throughout the compile-fail test suite and a number of updates to the UI test suite.
2017-07-27 12:51:09 +08:00
#![allow(warnings)]
Test fixes and rebase conflicts
2015-01-08 10:53:58 +08:00
markers -> marker
2015-01-07 06:33:42 +08:00
use std::marker;
Immutable static items should be `Freeze` Fixes #12432
2014-02-22 03:31:50 +08:00
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
struct WithDtor;
impl Drop for WithDtor {
fn drop(&mut self) {}
}
// This enum will be used to test the following rules:
// 1. Variants are safe for static
// 2. Expr calls are allowed as long as they arguments are safe
test: Convert statics to constants Additionally, add lots of tests for new functionality around statics and `static mut`.
2014-10-07 12:16:35 +08:00
// 3. Expr calls with unsafe arguments for statics are rejected
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
enum SafeEnum {
Variant1,
Update compile fail tests to use isize.
2015-01-08 18:54:35 +08:00
Variant2(isize),
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
Variant3(WithDtor),
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
Variant4(String),
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
}
// These should be ok
Switch to purely namespaced enums This breaks code that referred to variant names in the same namespace as their enum. Reexport the variants in the old location or alter code to refer to the new locations: ``` pub enum Foo { A, B } fn main() { let a = A; } ``` => ``` pub use self::Foo::{A, B}; pub enum Foo { A, B } fn main() { let a = A; } ``` or ``` pub enum Foo { A, B } fn main() { let a = Foo::A; } ``` [breaking-change]
2014-11-06 16:05:53 +08:00
static STATIC1: SafeEnum = SafeEnum::Variant1;
static STATIC2: SafeEnum = SafeEnum::Variant2(0);
static STATIC3: SafeEnum = SafeEnum::Variant3(WithDtor);
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
enum UnsafeEnum {
Variant5,
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
Variant6(isize),
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
}
impl Drop for UnsafeEnum {
fn drop(&mut self) {}
}
Switch to purely namespaced enums This breaks code that referred to variant names in the same namespace as their enum. Reexport the variants in the old location or alter code to refer to the new locations: ``` pub enum Foo { A, B } fn main() { let a = A; } ``` => ``` pub use self::Foo::{A, B}; pub enum Foo { A, B } fn main() { let a = A; } ``` or ``` pub enum Foo { A, B } fn main() { let a = Foo::A; } ``` [breaking-change]
2014-11-06 16:05:53 +08:00
static STATIC4: UnsafeEnum = UnsafeEnum::Variant5;
static STATIC5: UnsafeEnum = UnsafeEnum::Variant6(0);
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
struct SafeStruct {
field1: SafeEnum,
field2: SafeEnum,
}
// Struct fields are safe, hence this static should be safe
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC6: SafeStruct =
SafeStruct { field1: SafeEnum::Variant1, field2: SafeEnum::Variant2(0) };
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC7: SafeStruct =
SafeStruct { field1: SafeEnum::Variant1, field2: SafeEnum::Variant3(WithDtor) };
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
// Test variadic constructor for structs. The base struct should be examined
Fix misspelled comments for tests.
2014-08-02 07:42:13 +08:00
// as well as every field present in the constructor.
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
// This example shouldn't fail because all the fields are safe.
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC8: SafeStruct = SafeStruct {
field1: SafeEnum::Variant1,
..SafeStruct { field1: SafeEnum::Variant1, field2: SafeEnum::Variant1 }
};
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
// This example should fail because field1 in the base struct is not safe
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC9: SafeStruct = SafeStruct {
field1: SafeEnum::Variant1,
..SafeStruct {
//~^ ERROR destructor of
field1: SafeEnum::Variant3(WithDtor),
field2: SafeEnum::Variant1,
}
};
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
struct UnsafeStruct;
impl Drop for UnsafeStruct {
fn drop(&mut self) {}
}
static STATIC10: UnsafeStruct = UnsafeStruct;
Replace all ~"" with "".to_owned()
2014-04-16 09:17:48 +08:00
struct MyOwned;
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC11: Vec<MyOwned> = vec![MyOwned];
rustc: merge check_static into check_const.
2014-12-31 04:36:03 +08:00
//~^ ERROR allocations are not allowed in statics
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
//~^^ ERROR cannot call non-const
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
static mut STATIC12: UnsafeStruct = UnsafeStruct;
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static mut STATIC13: SafeStruct =
SafeStruct { field1: SafeEnum::Variant1, field2: SafeEnum::Variant3(WithDtor) };
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
test: Remove all uses of `~str` from the test suite.
2014-05-13 08:56:43 +08:00
static mut STATIC14: SafeStruct = SafeStruct {
Switch to purely namespaced enums This breaks code that referred to variant names in the same namespace as their enum. Reexport the variants in the old location or alter code to refer to the new locations: ``` pub enum Foo { A, B } fn main() { let a = A; } ``` => ``` pub use self::Foo::{A, B}; pub enum Foo { A, B } fn main() { let a = A; } ``` or ``` pub enum Foo { A, B } fn main() { let a = Foo::A; } ``` [breaking-change]
2014-11-06 16:05:53 +08:00
field1: SafeEnum::Variant1,
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
field2: SafeEnum::Variant4("str".to_string()), //~ ERROR cannot call non-const fn
test: Remove all uses of `~str` from the test suite.
2014-05-13 08:56:43 +08:00
};
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC15: &'static [Vec<MyOwned>] = &[
vec![MyOwned], //~ ERROR allocations are not allowed in statics
//~^ ERROR cannot call non-const
vec![MyOwned], //~ ERROR allocations are not allowed in statics
//~^ ERROR cannot call non-const
test: Convert statics to constants Additionally, add lots of tests for new functionality around statics and `static mut`.
2014-10-07 12:16:35 +08:00
];
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC16: (&'static Vec<MyOwned>, &'static Vec<MyOwned>) = (
&vec![MyOwned], //~ ERROR allocations are not allowed in statics
//~^ ERROR cannot call non-const
&vec![MyOwned], //~ ERROR allocations are not allowed in statics
//~^ ERROR cannot call non-const
test: Convert statics to constants Additionally, add lots of tests for new functionality around statics and `static mut`.
2014-10-07 12:16:35 +08:00
);
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
Switch to purely namespaced enums This breaks code that referred to variant names in the same namespace as their enum. Reexport the variants in the old location or alter code to refer to the new locations: ``` pub enum Foo { A, B } fn main() { let a = A; } ``` => ``` pub use self::Foo::{A, B}; pub enum Foo { A, B } fn main() { let a = A; } ``` or ``` pub enum Foo { A, B } fn main() { let a = Foo::A; } ``` [breaking-change]
2014-11-06 16:05:53 +08:00
static mut STATIC17: SafeEnum = SafeEnum::Variant1;
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
static STATIC19: Vec<isize> = vec![3];
rustc: merge check_static into check_const.
2014-12-31 04:36:03 +08:00
//~^ ERROR allocations are not allowed in statics
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
//~^^ ERROR cannot call non-const
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
pub fn main() {
Remove uses of `box_syntax` in rustc and tools
2023-02-27 21:07:44 +08:00
let y = {
static x: Vec<isize> = vec![3]; //~ ERROR allocations are not allowed in statics
//~^ ERROR cannot call non-const
x
//~^ ERROR cannot move out of static
};
Forbid certain types for static items - For each *mutable* static item, check that the **type**: - cannot own any value whose type has a dtor - cannot own any values whose type is an owned pointer - For each *immutable* static item, check that the **value**: - does not contain any ~ or box expressions (including ~[1, 2, 3] sort of things) - does not contain a struct literal or call to an enum variant / struct constructor where - the type of the struct/enum has a dtor
2014-02-27 02:22:41 +08:00
}