2018-10-28 22:37:39 +08:00
|
|
|
#![warn(clippy::needless_bool)]
|
2018-10-11 18:16:22 +08:00
|
|
|
|
2018-10-28 22:37:39 +08:00
|
|
|
use std::cell::Cell;
|
2017-09-18 18:47:33 +08:00
|
|
|
|
2018-10-28 22:37:39 +08:00
|
|
|
macro_rules! bool_comparison_trigger {
|
|
|
|
($($i:ident: $def:expr, $stb:expr );+ $(;)*) => (
|
|
|
|
|
|
|
|
#[derive(Clone)]
|
|
|
|
pub struct Trigger {
|
|
|
|
$($i: (Cell<bool>, bool, bool)),+
|
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
impl Trigger {
|
|
|
|
pub fn trigger(&self, key: &str) -> bool {
|
|
|
|
$(
|
|
|
|
if let stringify!($i) = key {
|
|
|
|
return self.$i.1 && self.$i.2 == $def;
|
|
|
|
}
|
|
|
|
)+
|
|
|
|
false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
)
|
|
|
|
}
|
2017-09-18 18:47:33 +08:00
|
|
|
|
2018-07-28 23:34:52 +08:00
|
|
|
#[allow(clippy::if_same_then_else)]
|
2015-05-02 06:35:49 +08:00
|
|
|
fn main() {
|
2015-08-12 02:22:20 +08:00
|
|
|
let x = true;
|
2016-07-04 07:17:31 +08:00
|
|
|
let y = false;
|
2018-12-10 06:26:16 +08:00
|
|
|
if x {
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
true
|
|
|
|
};
|
|
|
|
if x {
|
|
|
|
false
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
};
|
|
|
|
if x {
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
};
|
|
|
|
if x {
|
|
|
|
false
|
|
|
|
} else {
|
|
|
|
true
|
|
|
|
};
|
|
|
|
if x && y {
|
|
|
|
false
|
|
|
|
} else {
|
|
|
|
true
|
|
|
|
};
|
|
|
|
if x {
|
|
|
|
x
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}; // would also be questionable, but we don't catch this yet
|
2016-03-14 23:41:41 +08:00
|
|
|
bool_ret(x);
|
|
|
|
bool_ret2(x);
|
|
|
|
bool_ret3(x);
|
2016-07-04 07:17:31 +08:00
|
|
|
bool_ret5(x, x);
|
2016-03-14 23:41:41 +08:00
|
|
|
bool_ret4(x);
|
2016-07-04 07:17:31 +08:00
|
|
|
bool_ret6(x, x);
|
2018-10-28 22:37:39 +08:00
|
|
|
needless_bool(x);
|
|
|
|
needless_bool2(x);
|
|
|
|
needless_bool3(x);
|
2016-03-14 23:41:41 +08:00
|
|
|
}
|
|
|
|
|
2018-07-28 23:34:52 +08:00
|
|
|
#[allow(clippy::if_same_then_else, clippy::needless_return)]
|
2016-03-14 23:41:41 +08:00
|
|
|
fn bool_ret(x: bool) -> bool {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x {
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
return true;
|
|
|
|
};
|
2016-03-14 23:41:41 +08:00
|
|
|
}
|
|
|
|
|
2018-07-28 23:34:52 +08:00
|
|
|
#[allow(clippy::if_same_then_else, clippy::needless_return)]
|
2016-03-14 23:41:41 +08:00
|
|
|
fn bool_ret2(x: bool) -> bool {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x {
|
|
|
|
return false;
|
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
};
|
2016-03-14 23:41:41 +08:00
|
|
|
}
|
|
|
|
|
2018-07-28 23:34:52 +08:00
|
|
|
#[allow(clippy::needless_return)]
|
2016-03-14 23:41:41 +08:00
|
|
|
fn bool_ret3(x: bool) -> bool {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x {
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
};
|
2016-07-04 07:17:31 +08:00
|
|
|
}
|
|
|
|
|
2018-07-28 23:34:52 +08:00
|
|
|
#[allow(clippy::needless_return)]
|
2016-07-04 07:17:31 +08:00
|
|
|
fn bool_ret5(x: bool, y: bool) -> bool {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x && y {
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
};
|
2016-03-14 23:41:41 +08:00
|
|
|
}
|
|
|
|
|
2018-07-28 23:34:52 +08:00
|
|
|
#[allow(clippy::needless_return)]
|
2016-03-14 23:41:41 +08:00
|
|
|
fn bool_ret4(x: bool) -> bool {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x {
|
|
|
|
return false;
|
|
|
|
} else {
|
|
|
|
return true;
|
|
|
|
};
|
2016-07-04 07:17:31 +08:00
|
|
|
}
|
|
|
|
|
2018-07-28 23:34:52 +08:00
|
|
|
#[allow(clippy::needless_return)]
|
2016-07-04 07:17:31 +08:00
|
|
|
fn bool_ret6(x: bool, y: bool) -> bool {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x && y {
|
|
|
|
return false;
|
|
|
|
} else {
|
|
|
|
return true;
|
|
|
|
};
|
2015-05-02 06:35:49 +08:00
|
|
|
}
|
2018-10-28 22:37:39 +08:00
|
|
|
|
|
|
|
fn needless_bool(x: bool) {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x == true {};
|
2018-10-28 22:37:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
fn needless_bool2(x: bool) {
|
2018-12-10 06:26:16 +08:00
|
|
|
if x == false {};
|
2018-10-28 22:37:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
fn needless_bool3(x: bool) {
|
|
|
|
bool_comparison_trigger! {
|
|
|
|
test_one: false, false;
|
|
|
|
test_three: false, false;
|
|
|
|
test_two: true, true;
|
|
|
|
}
|
2018-12-10 06:26:16 +08:00
|
|
|
|
|
|
|
if x == true {};
|
|
|
|
if x == false {};
|
2018-10-28 23:28:17 +08:00
|
|
|
}
|
2019-01-20 23:15:00 +08:00
|
|
|
|
|
|
|
fn needless_bool_in_the_suggestion_wraps_the_predicate_of_if_else_statement_in_brackets() {
|
|
|
|
let b = false;
|
|
|
|
let returns_bool = || false;
|
|
|
|
|
|
|
|
let x = if b {
|
|
|
|
true
|
|
|
|
} else if returns_bool() {
|
|
|
|
false
|
|
|
|
} else {
|
|
|
|
true
|
|
|
|
};
|
|
|
|
}
|