dnrops
/
node-oracledb
mirror of https://github.com/oracle/node-oracledb
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Correct concurency issue with high frequency notifications from CQN

This commit is contained in:
Christopher Jones 2018-12-05 12:38:14 +11:00
parent 37f061cb3f
commit f434ef5127
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
CHANGELOG.md
View File

@ -25,7 +25,8 @@ This release is currently under development.
applications where not all users will be accessing Oracle Database.
It allows code generation tools to access node-oracledb constants
without needing Oracle Client installed (See #983).
without needing Oracle Client installed (see
[#983](https://github.com/oracle/node-oracledb/issues/983)).
Applications now have more scope to alter Oracle environment
variables referenced by the Oracle Client layer. Note it is still
@ -36,10 +37,13 @@ This release is currently under development.
- Support fetching XMLTYPE columns in queries. They will return as
String.
- Fixed a crash with high frequency notifications from CQN
([#1009](https://github.com/oracle/node-oracledb/issues/1009)).
- Display correct error message for SODA `createIndex()` when no
parameter is passed.
- Fix some SODA stability issues (node-oracledb and ODPI-C changes).
- Fixed some SODA stability issues (node-oracledb and ODPI-C changes).
- Improved the statement error whitelist to avoid unnecessarily
dropping statements from the statement cache (ODPI-C change).
@ -226,8 +230,8 @@ This release is currently under development.
## node-oracledb v2.1.1 (16 Feb 2018)
- Fixed regression with querystream() in Node 4 & 6.
https://github.com/oracle/node-oracledb/issues/847
- Fixed regression with `queryStream()` in Node 4 & 6
([#847](https://github.com/oracle/node-oracledb/issues/847)).
## node-oracledb v2.1.0 (15 Feb 2018)

4
src/njsSubscription.cpp
View File

@ -81,6 +81,7 @@ void njsSubscription::ProcessNotification(uv_async_t *handle)
njsSubscription *subscription = (njsSubscription*) handle->data;
Nan::HandleScope scope;
uv_mutex_lock(&subscription->mutex);
Local<Function> callback = Nan::New<Function>(subscription->jsCallback);
Local<Value> callbackArgs[1];
callbackArgs[0] = subscription->CreateMessage(subscription->message);
@ -92,6 +93,7 @@ void njsSubscription::ProcessNotification(uv_async_t *handle)
if (!subscription->message->registered)
subscription->StopNotifications();
subscription->WaitOnBarrier();
uv_mutex_unlock(&subscription->mutex);
}
@ -367,9 +369,9 @@ void njsSubscription::EventHandler(njsSubscription *subscription,
uv_mutex_lock(&subscription->mutex);
uv_barrier_init(&subscription->barrier, 2);
subscription->message = incomingMessage;
uv_mutex_unlock(&subscription->mutex);
uv_async_send(&subscription->async);
subscription->WaitOnBarrier();
uv_mutex_unlock(&subscription->mutex);
}
}