From ded6b22d2aae24de627b397b7b60e74bac2e9117 Mon Sep 17 00:00:00 2001 From: Christopher Jones Date: Thu, 3 Sep 2015 19:42:25 +1000 Subject: [PATCH] Temporarily disable lobPrefetchSize --- CHANGELOG.md | 4 +++- doc/api.md | 2 ++ src/dpi/src/dpiConnImpl.cpp | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bdd423bf..8a2da5d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log -## node-oracledb v1.1.0 (DD Mon YYYY ) +## node-oracledb v1.1.0 (3 Sep 2015) - Enhanced pool.release() to drop the session if it is known to be unusable, allowing a new session to be created. @@ -18,6 +18,8 @@ - Added a check to throw an error sooner when a CURSOR type is used for IN or IN OUT binds. (Support is pending). +- Temporarily disabling setting lobPrefetchSize + ## node-oracledb v1.0.0 (17 Aug 2015) - Implemented Stream interface for CLOB and BLOB types, adding support for diff --git a/doc/api.md b/doc/api.md index 51cf0407..f12264f2 100644 --- a/doc/api.md +++ b/doc/api.md @@ -478,6 +478,8 @@ oracledb.maxRows = 100; Number lobPrefetchSize ``` +This attribute is temporarily disabled. Setting it has no effect. + Node-oracledb internally uses Oracle *LOB Locators* to manipulate long object (LOB) data. LOB Prefetching allows LOB data to be returned early to node-oracledb when these locators are first returned. diff --git a/src/dpi/src/dpiConnImpl.cpp b/src/dpi/src/dpiConnImpl.cpp index a2ba0ab1..87b4f7b4 100644 --- a/src/dpi/src/dpiConnImpl.cpp +++ b/src/dpi/src/dpiConnImpl.cpp @@ -301,8 +301,11 @@ unsigned int ConnImpl::stmtCacheSize() const void ConnImpl::lobPrefetchSize(unsigned int lobPrefetchSize) { +// Temporarily disable this attribute. +#if 0 ociCall(OCIAttrSet(sessh_, OCI_HTYPE_SESSION, &lobPrefetchSize, 0, OCI_ATTR_DEFAULT_LOBPREFETCH_SIZE, errh_), errh_); +#endif }