dnrops
/
node-oracledb
mirror of https://github.com/oracle/node-oracledb
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix pool queue dequeuing loop 

This resolves a problem introduced with the pool.reconfigure() enhancement.
This commit is contained in:
Christopher Jones 2021-06-04 08:36:52 +10:00
parent 901c50c632
commit b7abd67128
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/pool.js
View File

@ -27,14 +27,17 @@ const util = require('util');
// _checkRequestQueue()
// When a connection is returned to the pool, this method is called (via an
// event handler) to determine when requests for connections should be
// completed and cancels any timeout that may have been associated with the
// resumed and cancels any timeout that may have been associated with the
// request. This method is also called from reconfigure() so that waiting
// connection-requests can be processed.
// connection requests can be processed. Note the use of a local variable for
// the number of connections out. This is because the connection requests will
// not resume until after the loop is finished, and therefore the number of
// connections the pool thinks is out will not be incremented.
//-----------------------------------------------------------------------------
function _checkRequestQueue() {
while (this._connRequestQueue.length > 0 &&
this._connectionsOut < this.poolMax) {
// process the payload
let connectionsOut = this._connectionsOut;
while (this._connRequestQueue.length > 0 && connectionsOut < this.poolMax) {
connectionsOut += 1;
const payload = this._connRequestQueue.shift();
if (this._enableStatistics) {
this._totalRequestsDequeued += 1;