From 26828746526fe36bb5b90b0072483da0aeb12336 Mon Sep 17 00:00:00 2001 From: darkbushido Date: Tue, 30 May 2017 15:56:51 -0500 Subject: [PATCH] fixing a busted -R on creds search I broke this when moving creds to its own file. --- .../ui/console/command_dispatcher/creds.rb | 2 + lib/msf/ui/console/command_dispatcher/db.rb | 41 +------------ .../console/command_dispatcher/db_common.rb | 57 +++++++++++++++++++ 3 files changed, 62 insertions(+), 38 deletions(-) create mode 100644 lib/msf/ui/console/command_dispatcher/db_common.rb diff --git a/lib/msf/ui/console/command_dispatcher/creds.rb b/lib/msf/ui/console/command_dispatcher/creds.rb index 17ce194365..0eba702caa 100644 --- a/lib/msf/ui/console/command_dispatcher/creds.rb +++ b/lib/msf/ui/console/command_dispatcher/creds.rb @@ -3,6 +3,7 @@ require 'rexml/document' require 'rex/parser/nmap_xml' require 'msf/core/db_export' +require 'msf/ui/console/command_dispatcher/db_common' module Msf module Ui @@ -14,6 +15,7 @@ class Creds include Msf::Ui::Console::CommandDispatcher include Metasploit::Credential::Creation + include Msf::Ui::Console::CommandDispatcher::DbCommon # # The dispatcher's name. diff --git a/lib/msf/ui/console/command_dispatcher/db.rb b/lib/msf/ui/console/command_dispatcher/db.rb index 0e54d59958..960345afa9 100644 --- a/lib/msf/ui/console/command_dispatcher/db.rb +++ b/lib/msf/ui/console/command_dispatcher/db.rb @@ -3,6 +3,7 @@ require 'rexml/document' require 'rex/parser/nmap_xml' require 'msf/core/db_export' +require 'msf/ui/console/command_dispatcher/db_common' module Msf module Ui @@ -14,7 +15,8 @@ class Db require 'tempfile' include Msf::Ui::Console::CommandDispatcher - + include Msf::Ui::Console::CommandDispatcher::DbCommon + # # The dispatcher's name. # @@ -1715,43 +1717,6 @@ class Db print_line end - # - # Set RHOSTS in the +active_module+'s (or global if none) datastore from an array of addresses - # - # This stores all the addresses to a temporary file and utilizes the - #
file:/tmp/filename
syntax to confer the addrs. +rhosts+ - # should be an Array. NOTE: the temporary file is *not* deleted - # automatically. - # - def set_rhosts_from_addrs(rhosts) - if rhosts.empty? - print_status("The list is empty, cowardly refusing to set RHOSTS") - return - end - if active_module - mydatastore = active_module.datastore - else - # if there is no module in use set the list to the global variable - mydatastore = self.framework.datastore - end - - if rhosts.length > 5 - # Lots of hosts makes 'show options' wrap which is difficult to - # read, store to a temp file - rhosts_file = Rex::Quickfile.new("msf-db-rhosts-") - mydatastore['RHOSTS'] = 'file:'+rhosts_file.path - # create the output file and assign it to the RHOSTS variable - rhosts_file.write(rhosts.join("\n")+"\n") - rhosts_file.close - else - # For short lists, just set it directly - mydatastore['RHOSTS'] = rhosts.join(" ") - end - - print_line "RHOSTS => #{mydatastore['RHOSTS']}" - print_line - end - def db_find_tools(tools) missed = [] tools.each do |name| diff --git a/lib/msf/ui/console/command_dispatcher/db_common.rb b/lib/msf/ui/console/command_dispatcher/db_common.rb new file mode 100644 index 0000000000..68f789d646 --- /dev/null +++ b/lib/msf/ui/console/command_dispatcher/db_common.rb @@ -0,0 +1,57 @@ +# -*- coding: binary -*- + +require 'rexml/document' +require 'rex/parser/nmap_xml' +require 'msf/core/db_export' + +module Msf +module Ui +module Console +module CommandDispatcher + +module DbCommon + + # + # Set RHOSTS in the +active_module+'s (or global if none) datastore from an array of addresses + # + # This stores all the addresses to a temporary file and utilizes the + #
file:/tmp/filename
syntax to confer the addrs. +rhosts+ + # should be an Array. NOTE: the temporary file is *not* deleted + # automatically. + # + def set_rhosts_from_addrs(rhosts) + if rhosts.empty? + print_status("The list is empty, cowardly refusing to set RHOSTS") + return + end + if active_module + mydatastore = active_module.datastore + else + # if there is no module in use set the list to the global variable + mydatastore = self.framework.datastore + end + + if rhosts.length > 5 + # Lots of hosts makes 'show options' wrap which is difficult to + # read, store to a temp file + rhosts_file = Rex::Quickfile.new("msf-db-rhosts-") + mydatastore['RHOSTS'] = 'file:'+rhosts_file.path + # create the output file and assign it to the RHOSTS variable + rhosts_file.write(rhosts.join("\n")+"\n") + rhosts_file.close + else + # For short lists, just set it directly + mydatastore['RHOSTS'] = rhosts.join(" ") + end + + print_line "RHOSTS => #{mydatastore['RHOSTS']}" + print_line + end + + +end + +end +end +end +end