From 228de518f0977d550db08680e8672e0495b25097 Mon Sep 17 00:00:00 2001 From: William Vu Date: Wed, 26 Apr 2017 02:48:50 -0500 Subject: [PATCH] Remove horrid title casing check --- tools/dev/msftidy.rb | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/tools/dev/msftidy.rb b/tools/dev/msftidy.rb index c93b6468ad..56dab3d409 100755 --- a/tools/dev/msftidy.rb +++ b/tools/dev/msftidy.rb @@ -12,16 +12,6 @@ require 'time' CHECK_OLD_RUBIES = !!ENV['MSF_CHECK_OLD_RUBIES'] SUPPRESS_INFO_MESSAGES = !!ENV['MSF_SUPPRESS_INFO_MESSAGES'] -TITLE_WHITELIST = %w{ - a an and as at avserve callmenum configdir connect debug docbase dtspcd - execve file for from getinfo goaway gsad hetro historysearch htpasswd ibstat - id in inetd iseemedia jhot libxslt lmgrd lnk load main map migrate mimencode - multisort name net netcat nodeid ntpd nttrans of on onreadystatechange or - ovutil path pbot pfilez pgpass pingstr pls popsubfolders prescan readvar - relfile rev rexec rlogin rsh rsyslog sa sadmind say sblistpack spamd - sreplace tagprinter the tnftp to twikidraw udev uplay user username via - welcome with ypupdated zsudo -} if CHECK_OLD_RUBIES require 'rvm' @@ -447,19 +437,6 @@ class Msftidy end end - def check_title_casing - if @source =~ /["']Name["'][[:space:]]*=>[[:space:]]*['"](.+)['"],*$/ - words = $1.split - words.each do |word| - if TITLE_WHITELIST.include?(word) - next - elsif word =~ /^[a-z]+$/ - warn("Suspect capitalization in module title: '#{word}'") - end - end - end - end - def check_bad_terms # "Stack overflow" vs "Stack buffer overflow" - See explanation: # http://blogs.technet.com/b/srd/archive/2009/01/28/stack-overflow-stack-exhaustion-not-the-same-as-stack-buffer-overflow.aspx @@ -709,7 +686,6 @@ class Msftidy check_old_rubies check_ranking check_disclosure_date - check_title_casing check_bad_terms check_bad_super_class check_bad_class_name