dnrops
/
leptos
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: new `<For/>` bug when clearing which ignores further additions (#1181)

This commit is contained in:
jquesada2016 2023-06-14 11:56:56 -06:00 committed by GitHub
parent 55bb63edea
commit 97127a90c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
leptos_dom/src/components/each.rs
View File

@ -818,13 +818,15 @@ fn apply_diff<T, EF, V>(
#[cfg(not(debug_assertions))]
parent.append_with_node_1(closing).unwrap();
} else {
range.set_start_before(opening).unwrap();
range.set_start_after(opening).unwrap();
range.set_end_before(closing).unwrap();
range.delete_contents().unwrap();
}
return;
if diff.added.is_empty() {
return;
}
}
for DiffOpRemove { at } in &diff.removed {
@ -838,11 +840,8 @@ fn apply_diff<T, EF, V>(
#[allow(unstable_name_collisions)]
children.drain_filter(|c| c.is_none());
// Resize children if needed
if let Some(added) = diff.added.len().checked_sub(diff.removed.len()) {
let target_size = children.len() + added;
children.resize_with(target_size, || None);
}
// Resize children
children.resize_with(children.len() + diff.added.len(), || None);
let (move_cmds, add_cmds) = unpack_moves(&diff);