dnrops
/
leptos
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: don't re-mount identical child in `DynChild` (#1211)

This commit is contained in:
Greg Johnston 2023-06-19 17:04:08 -04:00 committed by GitHub
parent 5c34c3fc77
commit 8ae5cf0ccf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
leptos_dom/src/components/dyn_child.rs
View File

@ -273,7 +273,8 @@ where
// I can imagine some edge case that the child changes while
// hydration is ongoing
if !HydrationCtx::is_hydrating() {
if !was_child_moved && child != new_child {
let same_child = child == new_child;
if !was_child_moved && !same_child {
// Remove the child
let start = child.get_opening_node();
let end = &closing;
@ -308,10 +309,13 @@ where
}
// Mount the new child
mount_child(
MountKind::Before(&closing),
&new_child,
);
// If it's the same child, don't re-mount
if !same_child {
mount_child(
MountKind::Before(&closing),
&new_child,
);
}
}
// We want to reuse text nodes, so hold onto it if