Commit Graph

751 Commits

Author SHA1 Message Date
Roland Walker 4991f655c6 comment typo 2014-11-15 12:27:11 -05:00
Roland Walker fbc9e35556 DSL remove support for `after_install` and friends
in favor of new-style `preflight`/`postflight` forms
2014-11-14 11:06:01 -05:00
Roland Walker 113a667fcc flag backward-compatibility todo 2014-11-13 11:45:47 -05:00
Roland Walker 00747614f7 use new header form in `create` template 2014-11-13 11:45:06 -05:00
Roland Walker 3262c5a5e5 cut v0.47.0 2014-11-12 11:42:54 -05:00
Federico Bond da0412bd71 Remove unsupported -x option in launchctl command 2014-11-12 11:28:45 -05:00
Roland Walker 09ecd1eb79 DSL: remove support `install` stanza
now replaced by `pkg`
2014-11-11 11:23:51 -05:00
Federico Bond 75ee4ef812 Add key option to suppress_move_to_applications 2014-11-02 00:26:49 -03:00
Roland Walker b837d6c552 remove support for `link` artifact
* `app`, `suite`, and `artifact no longer implemented as
  synonyms for `link`
* backward-compatible code/comments removed
* creates class `Cask::Artifact::Suite`
* updates `brew cask info` to show specific artifact type
* fixes stray "Generic artifact" messages
2014-10-29 10:53:49 -04:00
Roland Walker 839ccb98d4 recast _checklinks verb as _checkurl
remove stray doc item missed in #6966
2014-10-28 12:12:10 -04:00
Roland Walker f7258c0e1b cut v0.46.0 2014-10-25 12:15:38 -04:00
Roland Walker 3f5551788c Merge pull request #6966 from rolandwalker/checklinks_internal
recast `checklinks` as internal command `_checklinks`
2014-10-25 06:44:36 -04:00
Roland Walker d70fdb20a4 Merge pull request #6965 from rolandwalker/url_corner_cases
better handling for invalid `url` stanzas
2014-10-24 21:40:56 -04:00
Roland Walker 431d00ebbb Merge pull request #6967 from rolandwalker/dump_tweak
improve error message in `brew cask _dump`
2014-10-24 21:40:48 -04:00
Roland Walker 66f2b722bb Merge pull request #6823 from ffleming/downgrade-error
Downgrade CaskAlreadyInstalledError to a warning
2014-10-24 11:40:23 -04:00
Roland Walker 6b69564066 improve error message in `brew cask _dump` 2014-10-24 09:51:23 -04:00
Roland Walker 2370400207 chg `checklinks` to internal command `_checklinks`
* `checklinks` is a very simple implementation useful only for development purposes
* it has no test coverage, only one line of documentation
* users regularly experiment with it and break it, especially
 `brew cask checklinks` with no arguments, which tests all Tapped Casks
2014-10-24 09:49:35 -04:00
Roland Walker db0b5aa9d9 better handling for invalid `url` stanzas 2014-10-24 09:36:11 -04:00
Roland Walker 66e2e05d34 Merge pull request #6947 from rolandwalker/chflags_permissions
Handle permissions corner cases on uninstall
2014-10-24 05:19:38 -04:00
Roland Walker aa4b112a90 Handle permissions corner cases on uninstall
* unset BSD file flags if present
* attempt ownership change if permissions changes fail

fixes #6699
fixes #6752
2014-10-23 12:07:05 -04:00
Roland Walker 03350791c6 be more explicit about which errors are rescued 2014-10-23 11:57:47 -04:00
Roland Walker cd63241558 use "staged" instead of "installed" for Caskroom
refs: #6783
2014-10-21 07:13:04 -04:00
Forrest Fleming f3611f4383 Downgrade CaskAlreadyInstalledError to a warning
Automatic installs - like thoughtbot's laptop script - fail when we
use Homebrew's onoe method.  Using opoo (to warn) will let the
scripts complete successfully when they try to install packages that
have already been installed.

Test for downgrading AlreadyInstalledError to warning
2014-10-19 15:35:09 -07:00
Roland Walker 967aa22793 recast method `destination_path` as `staged_path`
* part of DSL 1.0 review
* `destination_path` was always a bit vague (it refers to
  Cask-specific, version-specific location under
  `/opt/homebrew-cask/Caskroom`)
* here renamed `staged_path` to match upcoming command verb
  `brew cask stage`
* rename also intended to reduce confusion when we implement
  copying as a configurable alternative to symlinking
* transitional `destination_path` methods to remain while
  Casks are converted (this was documented as a part of the
  DSL, and used by 39 Casks in main repo)
* unrelated variables containing "stage" recast for clarity
2014-10-18 12:23:36 -04:00
Roland Walker b76d0fbb4f cut v0.45.0 2014-10-17 09:10:11 -04:00
Roland Walker 633a2ef0f1 Merge pull request #6660 from rolandwalker/installer_stanza
DSL: add `installer` stanza
2014-10-15 22:58:28 -04:00
Roland Walker 012a9f5a7b document `appcast` stanza
The :latest_version key stays undocumented, as it is not
clear yet whether it is useful
2014-10-15 09:28:29 -04:00
Roland Walker 42770516f7 dsl: add `installer :manual`
a toplevel artifact, intended to replace `manual_installer`,
which is currently implemented within the `caveats` mini-DSL
2014-10-14 11:34:44 -04:00
Roland Walker 68fdb25129 recast install_script to installer :script
* document installer :script.  install_script was never documented
2014-10-14 11:34:32 -04:00
Roland Walker 37136710d2 Recast Cask::DSL::Installed as Cask::Staged
Change namespace for clarity, as we already have Cask::Installer,
and are about to add Cask::DSL::Installer.

Move to parent because these methods are not DSL-specific.
2014-10-14 11:34:02 -04:00
Roland Walker 4ec22f2b7a require Cask argument to `brew cask _dump` 2014-10-14 04:36:20 -04:00
Roland Walker 1a8884753e sanity check against deleting user files
Needed to reduce danger from typos in "zap" stanzas.

As noted in the comments, this is somewhat simplistic, and
should later be merged with similar logic in lib/cask/pkg.rb.
2014-10-11 12:07:31 -04:00
Roland Walker d2f041d9d4 coerce `uninstall :script :input` value to array 2014-10-10 09:04:32 -04:00
Roland Walker 41cf7d96f0 docs and tests for new form `container :nested` 2014-10-09 11:34:37 -04:00
Roland Walker 707db75505 standardize Cask (capitalized) when used as noun
* was already done, but inconsistently
* this style follows homebrew Formula
* covers user-facing messages, test titles, comments
* some related minor orthography is included, such
  as the consistent spelling of our project name as
  "homebrew-cask"
* grammar nits
2014-10-08 10:39:51 -04:00
Roland Walker 096a13ed73 cut v0.44.0 2014-10-07 08:52:49 -04:00
ndr 69c2aa91e8 Merge pull request #6360 from ndr-qef/dsl/validate-gpg-key
DSL: validate value of GPG key ID
2014-10-06 23:10:30 +01:00
Roland Walker 4f671ad177 Merge pull request #6491 from claui/issue-5997
User-friendly error messages for invalid options/arguments; fixes #5997
2014-10-06 11:15:59 -04:00
Roland Walker 32e5b80c2f Merge pull request #6478 from rolandwalker/doctor_caskroom
print caskroom location in `brew cask doctor`
2014-10-06 06:19:18 -04:00
Claudia 0fe558b927 User-friendly error messages for invalid options/arguments; fixes #5997
- Show a more user-friendly error message when dealing with an option whose (mandatory) argument is missing.

- Likewise, we show a more user-friendly error message when a given option is ambiguous. Examples:
    - Given `-f`, the parser successfully expands to `--fontdir`.

    - Given `-c`, we fail to expand because the parser can’t tell if the user means `--caskroom` or rather `--colorpickerdir`. This exception now results in a nicer error message.

- Some commands now result in a consistent error message when a required cask name is missing.
This affects all stable commands which require one or more cask names as arguments, i. e. `cat`, `create`, `edit`, `fetch`, `info`, `install`, `uninstall`, and `zap`.

- Up to now, the commands `cat`, `create`, `edit`, and `info` used to treat any unknown option as a cask name. This commit changes that behaviour to make it consistent to the rest of the commands (like `fetch`, `install`, `uninstall`, and `zap`), who have silently discarded any unknown option in the past, and continue to do so.
2014-10-05 18:32:33 +02:00
ndr 3c060f366e Merge pull request #6487 from alexcruice/caveats-dsl-tiger-support
Fix caveats os_version_only Tiger support
2014-10-05 18:00:07 +02:00
Alex Cruice fad43d9976 Fix caveats os_version_only Tiger support 2014-10-05 23:11:32 +10:00
ndr 975d2518b0 Validate value of GPG :key_id
The value of `:key_id` must be an hexadecimal string of length 8, 16,
or 40.
2014-10-05 12:47:40 +02:00
Roland Walker f86ea4c7a4 show staging directory (caskroom) in doctor
refs #6471
2014-10-04 08:24:21 -04:00
Roland Walker 1f18a74056 comment/todo re: directory creation 2014-10-04 08:23:28 -04:00
Roland Walker e3f10f82b8 doc and tests for `container :type`
includes some minor tweaks/re-ordering in docs
2014-10-03 10:40:54 -04:00
Roland Walker a12698efa2 comments in download_strategy.rb 2014-10-03 10:13:31 -04:00
Roland Walker a98af14abe Merge pull request #6433 from jconley/kextunload
fix params for kextunload
2014-10-02 11:03:38 -04:00
Johnathan Conley 203dae5e60 fix params for kextunload 2014-10-01 12:39:38 -05:00
Roland Walker f1604e4efb docs and create template for new license stanza
some :closed licenses in the code are left undocumented for
now, and should not be used.
2014-10-01 11:18:13 -04:00