Commit Graph

488 Commits

Author SHA1 Message Date
Roland Walker d8ad14aaa5 Merge pull request #4757 from rolandwalker/https_in_create
prompt for HTTPS URLs in `brew cask create`
2014-06-07 15:35:45 -04:00
Roland Walker 154eb2b12f prompt for HTTPS URLs in `brew cask create` 2014-06-07 14:36:35 -04:00
Fernando Paredes a4d479c3c4 Add audit for versioned casks with no checksum
* Check if version is not latest and has a sha256 :no_check for checksum
2014-06-06 21:22:19 -07:00
Roland Walker bd30615a88 `collect_concat` is not available in Ruby 1.8
`collect` is fine here. References #4719.
plus bugfix: join into a string so that `render_with_none`
knows to substitute "<NONE>"
2014-06-06 21:48:37 -04:00
Roland Walker 8da1d588bb Merge pull request #4733 from rolandwalker/helpdoc_cleanup
remove issues_url and nullcommand from help output
2014-06-06 20:58:07 -04:00
Roland Walker 3a48343a03 Merge pull request #4719 from rolandwalker/doctor_refactor
refactor `brew cask doctor`
2014-06-06 20:42:45 -04:00
Roland Walker 324d79f0bb Merge pull request #4673 from rolandwalker/cask_load_exceptions
Improve error checking and messages on Cask load
2014-06-06 20:42:35 -04:00
Roland Walker 13f8a4d282 remove issues_url and nullcommand from help output
necessitated by Homebrew's switch to Ruby 2.x
Fixes #4728
Fixes #4726
2014-06-06 17:10:28 -04:00
Roland Walker abe4428cb6 add $SHELL to doctor 2014-06-06 14:15:48 -04:00
Roland Walker 40215968ef add $CHRUBY_VERSION to doctor 2014-06-06 14:15:34 -04:00
Fernando Paredes b767f9f1e6 Add OS X 10.10 as a known OS version
* In Yosemite the tests failed for being unknown
2014-06-06 10:56:41 -07:00
Roland Walker 50841d3f86 whitespace 2014-06-06 11:34:45 -04:00
Roland Walker c857f11965 add PATH to doctor 2014-06-06 11:33:15 -04:00
Roland Walker a9121320f8 add render_env_var in doctor
add quoting
2014-06-06 11:32:15 -04:00
Roland Walker e6e5626bbc warning on old-style tap paths in doctor 2014-06-06 11:25:35 -04:00
Roland Walker 796104b786 move homebrew_origin to method in doctor 2014-06-06 11:08:19 -04:00
Roland Walker 6a7cda5c24 move default_cask_count to method in doctor 2014-06-06 11:08:19 -04:00
Roland Walker 8388d1c3ac move alt_taps to method in doctor 2014-06-06 11:08:18 -04:00
Roland Walker c354e53cc3 move fq_default_tap to method in doctor 2014-06-06 11:08:18 -04:00
Roland Walker 8a5ad08dc8 move privledged_uid to method in doctor 2014-06-06 11:08:18 -04:00
Roland Walker 9f2c773ed6 move notfound_string to method 2014-06-06 11:00:32 -04:00
Roland Walker fc9e7299ed add locale variables to doctor
references: #4677
2014-06-06 11:00:32 -04:00
Roland Walker f6011c85c9 render empty doctor values with <NONE> 2014-06-06 10:37:01 -04:00
Roland Walker 1400b61acf abstract error_string in doctor 2014-06-06 10:36:56 -04:00
Roland Walker a517e25acd abstract none_string in doctor 2014-06-06 10:36:46 -04:00
Roland Walker 0ef4606e0c retire support for `no_checksum` stanza 2014-06-04 23:26:09 -04:00
Roland Walker c082b5521a Improve error checking and messages on Cask load
Other Cask sources ultimately invoke the `load` method in the
abstract class Cask::Source::PathBase, so these changes apply
to all other sources.
2014-06-04 07:34:52 -04:00
Roland Walker 96ebb64320 Merge pull request #4658 from rolandwalker/demote_implicit_path_source
Demote implicit Cask path sources (i.e. files in current working directory)
2014-06-03 19:14:52 -04:00
Roland Walker 787b471618 isolate ErrorDuringExecution rescue
it only should be rescued for the `curl` invocation
2014-06-03 11:39:58 -04:00
Roland Walker 9797d2770f doc: improve Cask-source-resolution debug message 2014-06-03 10:39:18 -04:00
Roland Walker f24b4ba05a show resolved Cask source file or URI w/ --debug
references #4641
2014-06-03 10:38:49 -04:00
Roland Walker f8c9567a66 Don't prefer Cask files in the cwd
Fixes #4641.  Cask files in the cwd are still permitted, but
at the very lowest priority, below Tapped Cask names.
2014-06-03 10:33:19 -04:00
Roland Walker 290d1ccb38 ChecksumMismatchError is ordinary exception
not a bug
2014-06-02 23:26:19 -04:00
Roland Walker 1b9df93e20 no need to catch CaskAlreadyInstalledError
separately; it is already descended from CaskError
2014-06-02 23:24:59 -04:00
Roland Walker d4fb446830 Merge pull request #4603 from rolandwalker/doctor_homebrew_origin
show Homebrew repo & origin in doctor
2014-05-31 15:19:37 -04:00
Roland Walker 9fdc5b3fd9 show Homebrew repo & origin in doctor
references: #4581, #4571
2014-05-31 07:58:22 -04:00
Roland Walker f71ed25ee0 rescue download failure; don't show traceback
instead, give a more specific error message.  Closes #4556.
2014-05-26 15:56:35 -04:00
Roland Walker 5b2e9d1466 doc/comment: known performance issues 2014-05-15 16:52:41 -04:00
Roland Walker 3c40e82c18 generate installed list only once during list cmd 2014-05-15 16:52:17 -04:00
Roland Walker c3e514defe optimize Cask.installed by guessing full paths 2014-05-15 16:50:42 -04:00
Roland Walker 598f53ba48 memoize all_tapped_cask_dirs 2014-05-15 16:49:43 -04:00
Roland Walker 03af4f45a1 make cask_titles hold Pathnames, not strings 2014-05-15 16:38:35 -04:00
Roland Walker d0db956d69 refactor `brew cask doctor`
Output remains the same (except in the case of error).
Wrap all calculations in begin blocks for safety, provide fallback
values for all variables, don't use ohai+puts when ohai is
sufficient
2014-05-15 12:55:23 -04:00
Roland Walker abd66acba1 Merge pull request #4370 from rolandwalker/uninstall_signal
add `:signal` directive for `uninstall`
2014-05-14 06:26:49 -04:00
Roland Walker d4c89509c2 Merge pull request #4382 from rolandwalker/no_doubledash_launchctl_remove
don't use doubledash on launchctl remove
2014-05-14 06:26:27 -04:00
Roland Walker 6815ef272e don't use doubledash on launchctl remove
it appears to be incorrect here: removal of jobs is hindered
2014-05-13 18:52:35 -04:00
Roland Walker b38d6a6977 add `:signal` directive for `uninstall`
to send arbitrary Unix signals.  Per discussion in #4328, some
processes are resistant to the `:quit` directive, and can be
made to shut down via a signal.
2014-05-13 13:04:10 -04:00
Roland Walker 5101d363ab append the .rb extension on Cask::Source::Path
Unless `.rb` is already present on the query string.  Failure
to append the extension caused confusing effects, including
selective failure of "brew cask list" when invoked from
`/usr/local/bin` working directory.  Fixes #4077 .
Credit to @mroth on the detective work.
2014-05-13 09:04:14 -04:00
Roland Walker cfc6ae7a13 Merge pull request #4264 from rolandwalker/retire_sha1
Retire support for `sha1` stanza.
2014-05-08 18:37:00 -04:00
Roland Walker 0808c0f3f9 handle Tap read error in `brew cask doctor` 2014-05-08 14:53:30 -04:00
Roland Walker 34df5309d4 Retire support for `sha1` stanza.
We haven't received new submissions using `sha1` for quite
some time.
2014-05-08 12:01:32 -04:00
Roland Walker c436ddc5fd transition docs/tests/messages to sha256 :no_check
`sha256 :no_check` has been supported syntax for a couple of months,
and now is being transitioned to the preferred syntax, replacing
the `no_checksum` stanza (which will still be supported, but
deprecated)
2014-05-08 08:42:44 -04:00
Roland Walker 89082904c4 cut v0.35.0 2014-05-08 07:48:34 -04:00
Roland Walker 4f82dda065 Merge pull request #4242 from rolandwalker/cat_documentation
update docs and messages for `brew cask cat`
2014-05-07 22:34:07 -04:00
Atsushi Nagase 186e2592df Moved garmin-express.rb to correct location 2014-05-08 00:47:23 +09:00
Roland Walker e910467b39 update docs and messages for `brew cask cat` 2014-05-07 10:32:15 -04:00
Roland Walker 89bf98ce6d Merge pull request #4241 from rolandwalker/cat_tweaks
light changes to "brew cask cat"
2014-05-07 09:33:52 -04:00
Roland Walker 31ce4bd4cd light changes to "brew cask cat"
tone down strident comment imported from Homebrew, whitespace, misc
2014-05-07 09:18:03 -04:00
Roland Walker fe99823d84 Merge pull request #4226 from rolandwalker/handle_nil_in_checklinks
handle `nil` `@response_status`
2014-05-07 08:38:24 -04:00
Roland Walker e1ee7b118d Merge pull request #4200 from linc01n/cli_cat
Add `brew cask cat` command
2014-05-07 08:29:30 -04:00
Roland Walker f80afb8684 handle nil @response_status
fixes #4212
2014-05-06 09:13:49 -04:00
Atsushi Nagase 4e1d4cbd0e Added Garmin Express 2014-05-06 06:28:37 +09:00
Lincoln Lee 227ac512bc Add `brew cask cat` command mentioned in #4018 2014-05-05 22:46:28 +08:00
Paul Hinze 767be2b4b0 cut v0.34.0 2014-05-04 18:53:58 -05:00
Paul Hinze 9e2641b851 Merge pull request #2427 from rolandwalker/checksum_error_help
Give the user help on checksum errors
2014-05-04 18:27:20 -05:00
Paul Hinze f54eaf7082 update all references to new caskroom org home
global replace of:
  'phinze/homebrew-cask' -> 'caskroom/homebrew-cask'
  'phinze/cask' -> 'caskroom/cask'
  'phinze/homebrew-testcasks' -> 'caskroom/homebrew-testcasks'

and various other specific places that needed updates

<3 the homebrew-cask community!
2014-05-03 10:29:17 -05:00
Roland Walker 90bba2cf00 cut v0.33.1 2014-04-29 09:49:12 -04:00
Roland Walker d73b8089c6 Merge pull request #4095 from rolandwalker/doctor_tap_paths
add Tap path info to `brew cask doctor`
2014-04-29 09:39:36 -04:00
Roland Walker c7ec83c068 add Tap path info to `brew cask doctor` 2014-04-29 09:30:06 -04:00
Roland Walker 75d6859195 better handle renamed Casks in `brew cask info`
Fixes #4058
2014-04-29 08:57:44 -04:00
Lincoln Lee 5faa850690 Remove ISSUES_URL from cli commands
When user run `brew cask` it will list all commands out.
There is a blank help command call issues_url which caused by the newly
introduced constant from #2971
2014-04-27 17:49:01 +08:00
Roland Walker 1f69c04cd6 cut v0.33.0 2014-04-26 09:59:40 -04:00
Roland Walker f7a209d133 Merge pull request #4042 from rolandwalker/tap_location_change
Adapt to homebrew's move of the tap directory
2014-04-26 09:47:03 -04:00
Roland Walker 400433be20 Adapt to homebrew's move of the tap directory
Closes #4035. Closes #4029. Closes #4026.
2014-04-26 09:42:16 -04:00
Roland Walker 836b3ce699 avoid exit code with no Casks are installed
and no argument is give to `brew cask list`.  Fixes #3881.
2014-04-25 10:56:45 -04:00
Võ Anh Duy 0fb893027d Redirect user to cask issues page, fixes #1251 2014-04-19 20:21:48 +07:00
Roland Walker af3fe61ae5 cut v0.32.0 2014-03-29 09:04:25 -04:00
Roland Walker 5bc2b62b25 Merge pull request #3667 from rolandwalker/artifacts_in_info
display artifact summary in `brew cask info`
2014-03-28 09:33:23 -04:00
Roland Walker 0652a39eb8 Merge pull request #3700 from rolandwalker/assistive_devices_caveat
add `assistive_devices` to `caveats` DSL
2014-03-28 09:33:00 -04:00
Roland Walker af103f1486 add `zsh_path_helper` to `caveats` DSL
Per discussion in #3597 and Homebrew/homebrew#25719
2014-03-27 09:42:33 -04:00
Roland Walker 9554b58245 add `assistive_devices` to `caveats` DSL
Inspired by #3695
2014-03-27 09:41:20 -04:00
Roland Walker 5c8640d6fe Merge pull request #2706 from rolandwalker/install_suggest
suggest replacements on "brew cask install" fail
2014-03-27 08:51:13 -04:00
Roland Walker 421eafaec8 display artifact summary in `brew cask info`
Per discussion with @drew-gross in closed issue #3280.
Limitation: does not show link targets.
2014-03-26 08:55:58 -04:00
Roland Walker f1620a56f5 make `brew cask audit` return error code on fail
Per report in #3655
2014-03-25 09:09:49 -04:00
Roland Walker 0938a9d862 cut v0.31.1 2014-03-17 10:11:50 -04:00
Roland Walker 266718d047 don't downcase a Pathname object
Fixes #3572.
2014-03-17 09:56:22 -04:00
Roland Walker 008b96353d cut v0.31.0 2014-03-15 10:30:37 -04:00
Roland Walker be255dcdbc Merge pull request #3515 from rolandwalker/unload_service
explicitly unload :launchctl service before remove
2014-03-14 21:12:14 -04:00
Roland Walker e8bd3465fe respect digits in search strings
Fixes #3533
2014-03-14 08:48:43 -04:00
Roland Walker ba8473a766 explicitly unload :launchctl service before remove 2014-03-14 08:41:18 -04:00
Roland Walker f5318395eb Merge pull request #3518 from rolandwalker/casecmp_fixes
fix some erroneous uses of `casecmp`
2014-03-12 19:15:37 -04:00
Roland Walker ba8d9ba4b5 fix some erroneous uses of `casecmp`
`casecmp` returns -1/0/1, never false or nil
2014-03-12 10:40:11 -04:00
Roland Walker 21e18b8a37 only set filesystem metadata if :target != source
fixing a bug in the implementation of #3073 which caused
metadata to be set in all cases.
2014-03-12 10:26:38 -04:00
Roland Walker a8acf3de1a bugfix: preserve resource forks when unzipping
Use the unarchiving ability built into the `ditto` utility,
rather explicitly calling the `unzip` utility.  Fixes
caskroom/homebrew-fonts#90.
2014-03-11 08:46:38 -04:00
Pedro Silva e58f3f89ca add new CurlPostDownloadStrategy
- lib/cask/url.rb: initialize(): add new `:data` attribute to hold post parameters
- lib/cask/download.rb: perform(): dispatch to new class based on `:using => :post`
- lib/cask/download_strategy.rb: Cask::CurlPostDownloadStrategy:
  			extend curl_args with x-www-form-urlencoded data
- doc/CASK_LANGUAGE_REFERENCE.md: HTTP URLs: document new strategy
- test/cask/test_download_strategy.rb: Cask::CurlPostDownloadStrategy: test new strategy
2014-03-07 20:51:35 +01:00
Roland Walker 726a650ebd Merge pull request #3106 from rolandwalker/emojii
Emoji and disk usage stats at install success
2014-03-06 21:40:37 -05:00
Roland Walker bf6ce149cf Merge pull request #3217 from rolandwalker/multiple_args_to_pkgutil
accept multiple arguments to uninstall/:pkgutil
2014-03-04 10:30:00 -05:00
Roland Walker 96dfc573b1 Merge pull request #2672 from rolandwalker/lsb_no_delete_safety
BUGFIX: don't try autocleanup inside system dirs
2014-03-03 09:30:09 -05:00
Roland Walker 655f50b064 cut v0.30.1 2014-03-02 10:30:23 -05:00
Roland Walker 15a4ca92e9 test if lsar is nil before attempting split
fixes #3332
2014-03-02 10:22:03 -05:00