Commit Graph

1279 Commits

Author SHA1 Message Date
Markus Reiter 245711fb1c Prefer keyword arguments over option hashes. 2016-07-27 21:43:12 +02:00
Markus Reiter 9e71e0ca02 Also output `stderr` when a command fails. (#23038) 2016-07-25 04:19:08 +02:00
Markus Reiter aba97a8ca6 Fix `audit` hanging at `curl`. (#23050) 2016-07-25 02:43:59 +02:00
Markus Reiter 9ee9ee77d5 Add `.MobileBackups` to DMG metadata. (#23036) 2016-07-24 16:54:00 +02:00
Markus Reiter 29221df8f3 Use full paths for system commands. (#23026) 2016-07-24 03:24:55 +02:00
Josh Hagins 0e125c6fa4 Ensure caveats block has access to relevant DSL methods (#22958)
* caveats: inherit helpers from Hbc::DSL::Base

* Refactor Hbc::DSL::Base with delegators to cask methods

* Add shared examples for Hbc::DSL::Base methods

* Test that caveats block has access to Hbc::DSL::Base methods
2016-07-20 14:36:13 -04:00
Josh Hagins e41a3c5fd3 Refactor Hbc::Container::Dmg for clarity (#22952) 2016-07-20 11:06:06 -04:00
Markus Reiter 1806aaf9a3 Change hash rockets to colons. (#22951) 2016-07-20 01:05:31 -04:00
Markus Reiter 16c6b8987b Fix and refactor recognition of container types. (#22857)
* Fix and refactor recognition of container types.

* Use retry instead of redundant code when ejecting DMGs.

* Use BOM file for extracting DMGs.

* Add `lzma` compression.
2016-07-19 23:30:15 -04:00
Markus Reiter ed5452b728 Run RuboCop on all core files. (#22855)
Add Style/BlockDelimiters cop.
2016-07-19 14:11:22 -04:00
Josh Hagins 0c0ae8bd80 Bump rubocop-cask to 0.8.3 (#22848) 2016-07-16 21:48:10 -04:00
Vítor Galvão 1b5256d915 "staged at" message changed to "was successfully installed!" (#22623) 2016-07-16 16:13:02 -04:00
Josh Hagins 1280c8afe1 Use our Tty instead of Homebrew's (#22843) 2016-07-16 16:05:26 -04:00
Josh Hagins a9a0cb27a1 Make audit_modified_casks an internal cmd (#22826) 2016-07-15 13:09:10 -04:00
Vítor Galvão 07326d91ca audit.rb: always fake browser headers when getting appcast (#22811) 2016-07-15 10:08:26 -04:00
Anastasia Sulyagina c50e5f6aa2 utils and pathname moved (#22762)
* utils and pathname moved

* style fix

* fix build

* comments fixed
2016-07-15 10:06:53 -04:00
Josh Hagins d9371efc32 Remove support for appcast :sha256 and convert remaining instances to :checkpoint (#22807) 2016-07-14 18:03:55 -04:00
Josh Hagins bb139c2a3f Fix audit --download to correctly calculate appcast checkpoint (#22741) 2016-07-12 01:14:40 -04:00
Markus Reiter acf2777b35 Refactor Artifacts (#22725)
* Use class method for`moved` artifact english name.

* Refactor linked artifacts.

* Refactor moved artifact.
2016-07-11 21:36:09 -04:00
Markus Reiter 1d5219f3ff Simplify version conversion methods. (#22733) 2016-07-11 21:35:39 -04:00
AnastasiaSulyagina a373e36d0e fix style 2016-07-09 22:19:09 +03:00
AnastasiaSulyagina 837bac4b6c strategies moved 2016-07-09 19:19:39 +03:00
Sean Zhu 35adc2f174 Update repo name in lib/hbc/utils.rb (#22664)
`brew untap phinze/cask` does not remove casks but `brew untap caskroom/cask` does.
2016-07-08 13:13:30 -04:00
Joshua Hagins b2a93664c7 Add Homebrew libs to load path in testing_env 2016-07-07 02:19:02 -04:00
Josh Hagins 70240f9ad7 Don't modify frozen string (#22599)
Resolves #22598
2016-07-05 10:54:11 -04:00
Benjamin Schanzel b3ee33f1a0 Fix error on 'require "english"' when running on a case-sensitive file system (#22597) 2016-07-05 08:24:23 -04:00
Markus Reiter 11eedac599 Core Code Cleanup 2016-07-05 02:29:10 -04:00
Josh Hagins 65d518000d Verify appcast checkpoint when running audit --download (#22565) 2016-07-05 02:03:40 -04:00
Anastasia Sulyagina fe4dc6f241 Delete exceptions from homebrew-fork (#22574)
* delete exceptions from homebrew-fork

* paths fix
2016-07-05 01:59:26 -04:00
Josh Hagins 9ba2575c1a Bump rubocop-cask to 0.8.2 (#22566) 2016-07-05 01:36:22 -04:00
Josh Hagins d52719d38b Inherit rubocop config from rubocop-cask defaults (#22495)
* Bump rubocop-cask to 0.7.0

* Inherit rubocop config from rubocop-cask defaults
2016-06-30 18:52:52 -04:00
Vítor Galvão 4216c15ed6 Merge pull request #22383 from vitorgalvao/malware
* caveats: apps with malware

* faq: filenames separated with _

* faq: apps with malware
2016-06-29 00:10:29 +01:00
Josh Hagins b124ea63ff Scope require_sha to installer (#22404)
* Scope require_sha to installer

* Use double-quotes around --require-sha in error message
2016-06-27 14:22:08 -04:00
Joshua McKinney ff81663f56 Add --require-sha option for Issue #18831 2016-06-26 02:05:25 -04:00
Josh Hagins ba08fbbe47 Tell users to delete old caskroom (#22387) 2016-06-25 18:48:08 -04:00
Markus Reiter 64d08cc7c1 Fix output formatting of depends_on :macos/:arch. (#22362) 2016-06-25 12:36:01 +01:00
abrammer 745b7c283c Copied which_editor and exec_editor from brew utils to address #20074. … (#22338) 2016-06-25 12:34:51 +01:00
Vítor Galvão 79cb8836b5 caveats: apps with malware 2016-06-25 12:15:53 +01:00
Claudia f348f74157 Introduce optional block syntax for `url` stanza
This commit amends the `url` stanza to accept an optional
block

The block is only evaluated when needed, for example on
download time or when auditing a Cask. It is never evaluated
when loading a Cask.

The return value of the block is either a `String`, or a
`String, Hash` tuple; the latter case is for additional
options such as `referer`.

Implementation note: Rolled my own delegate logic because
`SimpleDelegator` turns out to take too much of a
performance hit.
2016-06-18 21:32:39 +02:00
Markus Reiter cf9b071877 Replace `and`/`or`/`not` keywords with `&&`/`||`/`!` (#22041) 2016-06-18 00:43:50 -04:00
Matt Wean 1bfdb2a07c Make appdir method available inside *flight blocks (#22043)
* Add appdir method to *flight blocks

* Update casks to use new appdir method
2016-06-17 13:25:19 -04:00
Markus Reiter 3bc2ce240c Show all versions with `brew cask list --versions`.
Fixes part of https://github.com/caskroom/homebrew-cask/issues/14058.
2016-06-16 23:33:54 +02:00
Markus Reiter d6cb39915e Check arguments individually in `brew cask list`.
Fixes part 1 of https://github.com/caskroom/homebrew-cask/issues/14058.
2016-06-16 20:36:44 +02:00
Vítor Galvão d6cb4211e6 core: Mac > macOS 2016-06-13 21:17:57 +01:00
Vítor Galvão a605177612 core: added support for sierra 2016-06-13 21:17:46 +01:00
Vítor Galvão 96632038dc core: OS X > macOS 2016-06-13 21:17:46 +01:00
Vítor Galvão 7b4a37122d Clarify new options for caskroom (#21915)
* readme: mark new issue as the FAQ to the caskroom directory change

* locations: mark new issue as the FAQ to the caskroom directory change
2016-06-13 11:14:13 -04:00
Josh Hagins b6b17a64f2 Use legacy Caskroom if it exists, but warn of change (#21901)
If a Caskroom exists at the old location of /opt/homebrew-cask/Caskroom,
use it and warn the user that the default location has changed.

Refs #21858, #21857, #21894
2016-06-12 21:46:37 -04:00
Claudia eac934fcbf Handle broken symlinks on `install`, `install --force` (#21893)
This commit fixes an error occurring with both `install` and `install --force` where either would fail when encountering a broken symlink.

Users _might_ run into that issue in the wake of PR #21857, and certainly _will_ be bitten by it once PR #21858 is merged.

This commit changes the `install` case so it handles the condition gracefully. It also fixes `install --force` so before moving an app, it removes any broken symlinks which might stand in the way.
2016-06-12 14:19:14 -04:00
Vítor Galvão 8318ffe409 Change default Caskroom path (#21857)
* core: change default Caskroom location to be inside brew --repository

* docs: change default Caskroom location to be inside brew --repository
2016-06-12 10:09:03 +01:00