homebrew-cask/.github/PULL_REQUEST_TEMPLATE.md

17 lines
1.3 KiB
Markdown
Raw Normal View History

**Important:** *Do not tick a checkbox if you havent performed its action.* Honesty is indispensable for a smooth review process.
2016-03-31 21:44:49 +08:00
After making all changes to a cask, verify:
2016-03-31 21:44:49 +08:00
- [ ] `brew cask audit --download {{cask_file}}` is error-free.
- [ ] `brew cask style --fix {{cask_file}}` reports no offenses.
- [ ] There are no [open pull requests](https://github.com/Homebrew/homebrew-cask/pulls) for the same update.
- [ ] The submission is for [a stable version](https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#stable-versions) or [documented exception](https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#but-there-is-no-stable-version).
2016-03-31 21:44:49 +08:00
Additionally, **if adding a new cask**:
2016-03-31 21:44:49 +08:00
- [ ] Named the cask according to the [token reference](https://github.com/Homebrew/homebrew-cask/blob/master/doc/cask_language_reference/token_reference.md).
2016-03-31 21:44:49 +08:00
- [ ] `brew cask install {{cask_file}}` worked successfully.
- [ ] `brew cask uninstall {{cask_file}}` worked successfully.
- [ ] Checked the cask was not [already refused](https://github.com/Homebrew/homebrew-cask/search?q=is%3Aclosed&type=Issues).
- [ ] Checked the cask is submitted to [the correct repo](https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#finding-a-home-for-your-cask).