mirror of https://github.com/GNOME/gimp.git
fb1cb22f62
- app_activate_callback() moved with other private functions. - Removing the `if (app)` test in app_activate_callback() as we don't set it to NULL anymore. The app variable is always set. - As a consequence of the previous point, change signature of app_exit_after_callback() which doesn't have to change the value of app anymore. - Don't emit direcly the "exit" signal from app_activate_callback(). We must call `gimp_exit (gimp, TRUE);` instead, which does more than just emitting this signal. It also takes care of cleaning any remaining images without a display. If we don't do this, we are leaking GeglBuffer when opening images from command lines while quitting immediately with --quit. - Get rid of gimp_core_app_set_values() which was completely bypassing the fact that all the properties of a GimpCoreApp were construct-only. Instead make these proper properties. I use a trick used in other interface, creating a gimp_container_view_install_properties() which is called from child classes. The point of GimpCoreApp is not just to share a common interface, it's rather to weakly simulate some kind of multi-inheritance in GObject. Since we want both GimpApp and GimpConsoleApp to inherit from a same parent class while we also want them to inherit either from GtkApplication and GApplication respectively (yet without linking to GTK in this second case), we are stuck as far as normal GObject inheritance goes. This is why we use an interface to which we add a private struct through a GQuark trick. We want the property settings and function implementations to also be part of this shared code. - Get rid of all the abstract methods of GimpCoreApp of the form get_*(). These are useless as we don't expect these to have different implementation depending on the actual child class. Once again, our main goal was to simulate multiple inheritance rather than actually have an interface with various implementations. - Make "no-splash" a property of GimpApp, because it's cleaner this way. - Fix gimp_core_app_private_finalize(). - don't use #pragma once, it's not standard. Just use include guards. - Fix includes: order was wrong, include from the source, not other headers, etc. - Clean various other details, coding styles, fix several more bugs and more… |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile.am | ||
| dbus-service.xml | ||
| gimpapp.c | ||
| gimpapp.h | ||
| gimpdbusservice.c | ||
| gimpdbusservice.h | ||
| gimpuiconfigurer.c | ||
| gimpuiconfigurer.h | ||
| gui-message.c | ||
| gui-message.h | ||
| gui-types.h | ||
| gui-unique.c | ||
| gui-unique.h | ||
| gui-vtable.c | ||
| gui-vtable.h | ||
| gui.c | ||
| gui.h | ||
| icon-themes.c | ||
| icon-themes.h | ||
| meson.build | ||
| modifiers.c | ||
| modifiers.h | ||
| session.c | ||
| session.h | ||
| splash.c | ||
| splash.h | ||
| themes.c | ||
| themes.h | ||