mirror of https://github.com/GNOME/gimp.git
![]() Now that GimpParamSpecFile makes file validation depending on the action set in the param spec, when trying to open a non-existing file (which can happen through GUI, for instance when opening through the Document History dockable or Open Recent menu), we had a quite obscure error about a value "out of range" used "for argument 'file' (#2, type GFile)", which is because core tried to set the GFile for a non-existing file into the second parameter of the plug-in PDB. This is not a very nice error for end-users. The old error was much nicer as it used to say things like: > Could not open '/path/not/existing.png' for reading: No such file or directory But in fact, this string came from the plug-in, which means: * first that the error can be different depending on the format (inconsistency of error message); * depending on bugs in plug-ins, it may just crash or return no error messages; * finally we were making a useless call to a load plug-in while we should already know from core that it won't work. The new message is something like: > Error when getting information for file "/path/not/existing.png: No such file or directory This error is generated by core, so it will always be consistently the same, is understandable too and the plug-in won't even be called. As a side related fix, I updated the GimpParamSpecFile validation to only validate local files, just like we do in core. Remote files can always be set (and we let plug-ins handle them), at least for the time being. |
||
---|---|---|
.. | ||
file-import.c | ||
file-import.h | ||
file-open.c | ||
file-open.h | ||
file-remote.c | ||
file-remote.h | ||
file-save.c | ||
file-save.h | ||
file-utils.c | ||
file-utils.h | ||
gimp-file.h | ||
meson.build |