Commit Graph

8743 Commits

Author SHA1 Message Date
William Skaggs f7cca5f2f2 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/core/gimpchannel-combine.c: improve anti-aliasing for
	elliptical selections, as described in bug #147836.
2004-07-18 19:31:29 +00:00
Sven Neumann 55c03a25b5 don't start a comment with /** unless it's meant to be parsed by gtk-doc.
2004-07-18  Sven Neumann  <sven@gimp.org>

	* app/composite/gimp-composite-mmx.h: don't start a comment with
	/** unless it's meant to be parsed by gtk-doc.

	* app/actions/Makefile.am:
	* app/actions/file-dialog-commands.[ch]: removed, not used any
	longer.
2004-07-18 18:24:32 +00:00
Philip Lafleur a1c89069db Check if the array index is legal before using it, not the other way
2004-07-18  Philip Lafleur  <plafleur@cvs.gnome.org>

	* app/paint/gimpink-blob.c (blob_make_convex): Check if the
	array index is legal before using it, not the other way around.
	Fixes bug #144856.
2004-07-18 09:10:17 +00:00
Philip Lafleur 68aa11c012 Fixed a write to unallocated memory that was causing crashes in various
2004-07-17  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/common/polar.c (dialog_update_preview): Fixed a
	write to unallocated memory that was causing crashes in various
	spots.
2004-07-18 01:45:57 +00:00
Philip Lafleur 774b116e08 moved array initialization out of variable declaration. Fixes bug #147799.
2004-07-17  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/common/polar.c (polarize_func): moved array
	initialization out of variable declaration. Fixes bug #147799.
2004-07-18 00:30:56 +00:00
Michael Natterer 09c6ee7363 added the removed help IDs back.
2004-07-17  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimphelp-ids.h: added the removed help IDs back.

	* app/widgets/gimpfileprocview.[ch]: cache all file_procs' help
	IDs and added gimp_file_proc_view_get_help_id() which returns the
	selected item's help ID.

	* app/widgets/gimpfiledialog.c: added a custom help func which
	shows the help for the selected file_proc if the proc_view has the
	focus.
2004-07-17 19:53:05 +00:00
Sven Neumann d95059db48 use GIMP_STOCK_WEB for "file-open-location".
2004-07-17  Sven Neumann  <sven@gimp.org>

	* app/actions/file-actions.c (file_actions): use GIMP_STOCK_WEB
	for "file-open-location".

	* app/widgets/gimpfiledialog.c: create the scrolled window with
	shadow_type GTK_SHADOW_IN.

	* app/widgets/gimpfileprocview.c (gimp_file_proc_view_new): skip
	procedures that register a prefix (the URL loader).

	* app/widgets/gimphelp-ids.h: removed help IDs that used to be
	used from the file-open and file-save menus.

	* plug-ins/common/xwd.c (query): "X window dump" seems to be more
	appropriate than "X window image".
2004-07-17 13:06:59 +00:00
Sven Neumann 996b45696e app/actions/Makefile.am app/actions/file-dialog-actions.[ch]
2004-07-17  Sven Neumann  <sven@gimp.org>

	* app/actions/Makefile.am
	* app/actions/file-dialog-actions.[ch]
	* app/actions/file-open-actions.[ch]
	* app/actions/file-save-actions.[ch]: these aren't needed any
	longer.

	* app/actions/actions.c: changed accordingly.

	* app/menus/Makefile.am
	* app/menus/file-dialog-menu.[ch]
	* app/menus/file-open-menu.[ch]
	* app/menus/file-save-menu.[ch]: these aren't needed any longer.

	* app/menus/menus.c: changed accordingly.

	* menus/Makefile.am
	* menus/file-open-menu.xml
	* menus/file-save-menu.xml: these are also not needed any longer.
2004-07-17 12:19:58 +00:00
Philip Lafleur a23024eb2b Applied a patch from Brion Vibber that fixes corruption when saving
2004-07-17  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/bmp/bmpwrite.c (WriteImage): Applied a patch from
	Brion Vibber that fixes corruption when saving RLE-encoded
	BMPs on big endian hosts. Fixes bug #147759.
2004-07-17 11:33:03 +00:00
Shlomi Fish 7ddb6a6a9e normalized the identifiers of general.c and general.h. Also, renamed a
* plug-ins/gimpressionist/: normalized the identifiers of
general.c and general.h. Also, renamed a callback from _store
to simply _callback to avoid confusion with the _store methods.
Some of the member variables of the pcvals struct were changed
as a result.
2004-07-17 09:43:46 +00:00
Helvetix Victorinox 47b1730948 We've had trouble compiling with the Intel compiler which
identifies itself as GCC, but doesn't support the same extended
assembly features/misfeatures as GCC.  With the help of the Intel
compiler group, we've determined that the Intel compiler can be
identified at compile time by the definition of the preprocessor
variable __INTEL_COMPILER.

These changes make all of the assembly code currently written to
simply avoid the Intel compiler.

This is an interim solution to get a build working despite the
Intel compiler.  A more correct solution has been identified, see
the discussion of bug #147013 for more information.
2004-07-17 05:24:08 +00:00
Sven Neumann 76a5689fc5 also register the internal XCF handlers according to the new scheme.
2004-07-17  Sven Neumann  <sven@gimp.org>

	* app/xcf/xcf.c (xcf_init): also register the internal XCF
	handlers according to the new scheme.

	* plug-ins/common/Makefile.am
	* plug-ins/common/plugin-defs.pl
	* plug-ins/common/hrz.c: removed the HRZ file plug-in since it
	doesn't seem to be very useful.
2004-07-16 22:54:53 +00:00
Sven Neumann 81bdb3c8d0 use g_slist_prepend() instead of g_slist_append().
2004-07-17  Sven Neumann  <sven@gimp.org>

	* app/plug-in/plug-ins.c (plug_ins_temp_proc_def_add)
	(plug_ins_init_file): use g_slist_prepend() instead of
	g_slist_append().

	* plug-ins/common/url.c (query): ported to the new PDB registration
	scheme.
2004-07-16 22:45:03 +00:00
Sven Neumann 5222925694 sort the file procedures by their menu labels.
2004-07-16  Sven Neumann  <sven@gimp.org>

	* app/plug-in/plug-ins.c (plug_ins_init): sort the file procedures
	by their menu labels.

	* app/widgets/gimpfileprocview.c: removed the sort function here.
2004-07-16 21:47:06 +00:00
Sven Neumann ccf8ed69e7 app/widgets/Makefile.am app/widgets/widgets-types.h added new widget that
2004-07-16  Sven Neumann  <sven@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpfileprocview.[ch]: added new widget that offers
	a treeview on file procedures.

	* app/widgets/gimpfiledialog.[ch]: replaced the file type option
	menu with the new GimpFileProcView widget.
	(gimp_file_dialog_set_image): reset the file type to Automatic
	(fixes bug #141535).

	* app/actions/file-commands.c
	* app/gui/file-open-dialog.[ch]
	* app/gui/file-save-dialog.[ch]: changed accordingly.

	* plug-ins/common/bz2.c
	* plug-ins/common/gz.c: don't register "xcf.gz" and "xcf.bz2"
	extension. It's redundant and breaks the code that sets the
	extension from the selected file-type.

	* plug-ins/common/dicom.c: register a shorter menu label.

	* plug-ins/common/gbr.c
	* plug-ins/common/gih.c
	* plug-ins/common/pat.c
	* plug-ins/common/url.c: register stock icons.
2004-07-16 21:24:39 +00:00
William Skaggs 07b8bed29a Bill Skaggs <weskaggs@primate.ucdavis.edu>
* plug-ins/Lighting/lighting_main.c
	* plug-ins/Lighting/lighting_main.h
	* plug-ins/Lighting/lighting_preview.c
	* plug-ins/Lighting/lighting_preview.h
	* plug-ins/Lighting/lighting_shade.c
	* plug-ins/Lighting/lighting_ui.c:  Made this plug-in support
	multiple light sources; implemented three, architecture now
	supports any number.  Changed material properties to more intuitve
	names; added "metallic" property.  Cleaned out some unused,
	commented-out code.
2004-07-16 19:41:21 +00:00
Michael Natterer a456ac9bde include "libgimpbase/gimpbase.h" instead of "libgimpbase/gimpparasite.h"
2004-07-16  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb.pl: include "libgimpbase/gimpbase.h" instead of
	"libgimpbase/gimpparasite.h" for getting the GimpParasite type.

	* tools/pdbgen/app.pl
	* tools/pdbgen/pdb/drawable.pdb
	* tools/pdbgen/pdb/edit.pdb
	* tools/pdbgen/pdb/gradients.pdb
	* tools/pdbgen/pdb/guides.pdb
	* tools/pdbgen/pdb/image.pdb: removed redundant #includes.

	* tools/pdbgen/pdb/plug_in.pdb: standardized "success" logic.
	Consistetly fail if there is no currently queried plugin.

	* app/pdb/*.c: regenerated.
2004-07-16 14:43:56 +00:00
Michael Natterer 147775d63d made gtk-doc even happier; clarified meaning of the "use_offsets"
2004-07-16  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-transform.c: made gtk-doc even
	happier; clarified meaning of the "use_offsets" parameter.
2004-07-16 12:41:05 +00:00
Sven Neumann 8c4b7b5aba app/display/gimpdisplayshell.c corrected API documentation, removed
2004-07-16  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdata.c:
	* app/display/gimpcanvas.c:
	* app/display/gimpdisplayshell.c
	* app/display/gimpdisplayshell-transform.c: corrected API
	documentation, removed trailing whitespace.

	Please do always build the documentation if you add or change any
	gtk-doc comments.
2004-07-16 10:07:30 +00:00
William Skaggs 0787e0304f Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/display/gimpcanvas.c:
	* app/display/gimpdisplayshell-transform.c: added gtk-doc
	comments for all public functions that lack them.

	* app/display/gimpdisplayshell.c: added a couple of
	gtk-doc comments.
2004-07-15 23:02:52 +00:00
William Skaggs aced3f7910 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/core/gimpdata.c: added gtk-doc comments for
	public functions.
2004-07-15 19:01:57 +00:00
Shlomi Fish 596ce390b3 normalized the identifiers of paper.c and paper.h. Made one variable local
* plug-ins/gimpressionist/: normalized the identifiers of
paper.c and paper.h. Made one variable local to the function
instead of module static.
2004-07-15 18:09:48 +00:00
Shlomi Fish 2f5a1d8a7b normalized the ppmtools.c and ppmtool.h identifiers. Also fixed some (but
* plug-ins/gimpressionist/: normalized the ppmtools.c and
ppmtool.h identifiers. Also fixed some (but not all) of the
syntax.
2004-07-15 11:58:47 +00:00
Philip Lafleur f162a82e2a Fixed typo. 2004-07-15 11:14:15 +00:00
Philip Lafleur de5aa52eb8 Applied a patch from Brion Vibber that fixes byte-swapping on big endian
2004-07-15  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/winicon/icoload.c:
	* plug-ins/winicon/icosave.c: Applied a patch from Brion Vibber
	that fixes byte-swapping on big endian hosts.	Fixes bug #147610.
2004-07-15 11:10:09 +00:00
Sven Neumann 9098878252 plug-ins/helpbrowser/dialog.c don't warn if no help pages are installed
2004-07-15  Sven Neumann  <sven@gimp.org>

	* plug-ins/helpbrowser/dialog.c
	* plug-ins/helpbrowser/uri.c: don't warn if no help pages are
	installed and the Home button is clicked.
2004-07-15 10:39:59 +00:00
Michael Natterer 963b941d39 don't crash if no layer or only one layer is visible. Fixes bug #143804.
2004-07-15  Michael Natterer  <mitch@gimp.org>

	* app/file/file-open.c (file_open_layer): don't crash if no
	layer or only one layer is visible. Fixes bug #143804.

	* app/app_procs.c (app_run): fixed log domain registration.
2004-07-15 10:37:03 +00:00
Michael Natterer c9d31f6e97 corrected API docs and fixed function parameter names to silent gtk-doc
2004-07-15  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpviewable.[ch]: corrected API docs and fixed
	function parameter names to silent gtk-doc warnings.
2004-07-15 09:53:17 +00:00
Michael Natterer 4812d3165a register a log handler for the "Gimp-Menus" domain.
2004-07-15  Michael Natterer  <mitch@gimp.org>

	* app/app_procs.c (app_run): register a log handler for the
	"Gimp-Menus" domain.
2004-07-15 09:29:01 +00:00
Philip Lafleur 7327a2ed51 cleanup.
2004-07-15  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/common/mng.c: cleanup.
2004-07-15 06:57:46 +00:00
William Skaggs 9c7c6e4221 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/core/gimpviewable.c: added gtk-doc comments for public
	functions.
2004-07-14 23:41:41 +00:00
Michael Natterer 6fb2502e72 reordered to match the .c file.
2004-07-15  Michael Natterer  <mitch@gimp.org>

	* app/actions/file-commands.h: reordered to match the .c file.

	* app/core/gimpitem.c
	* app/vectors/gimpvectors-import.c: fixed API docs.
2004-07-14 23:14:49 +00:00
Philip Lafleur 6f6c71d01c Fixed erroneously reported warning message when saving indexed layers with
2004-07-14  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/common/png.c:
	* plug-ins/common/mng.c: Fixed erroneously reported warning
	message when saving indexed layers with an alpha channel but
	no transparent pixels.
2004-07-14 22:09:51 +00:00
Sven Neumann deb8f7bfc4 register a log handler for the "Gimp-Actions" domain.
2004-07-14  Sven Neumann  <sven@gimp.org>

	* app/app_procs.c (app_run): register a log handler for the
	"Gimp-Actions" domain.
2004-07-14 21:27:11 +00:00
William Skaggs b7e75c5dd7 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* devel-docs/objects.txt: . . . and removed because it is
	redundant with devel-docs/app/app.hierarchy.
2004-07-14 20:47:41 +00:00
William Skaggs 8aeb819196 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* devel-docs/objects.txt:  added file containing a map of Gimp's
	GObject hierarchy.
2004-07-14 18:43:13 +00:00
Michael Natterer 178d7d3ff1 massively changed: removed message_ids, the message mem chunk and all
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpstatusbar.[ch]: massively changed: removed
	message_ids, the message mem chunk and all signals. Added new
	function gimp_statusbar_replace() which updates a message without
	moving it to the top of the stack. Fixes bug #120175.

	* app/display/gimpdisplayshell-title.[ch]: renamed
	gimp_display_shell_update_title() to
	gimp_display_shell_title_update() and switched from pop()/push()
	to replace() so the title message keeps its place in the stack.
	Added new function gimp_display_shell_title_init() which push()es
	the title message to the stack.

	* app/display/gimpdisplayshell.c (gimp_display_shell_new): call
	gimp_display_shell_title_init() so the "title" message is at the
	bottom of the stack.

	* app/display/gimpdisplayshell-callbacks.c
	* app/display/gimpdisplayshell-handlers.c: changed accordingly.
2004-07-14 16:37:13 +00:00
Sven Neumann 6d4d038f2d plug-ins/script-fu/script-fu-console.[ch] plug-ins/script-fu/script-fu.c
2004-07-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/script-fu-console.[ch]
	* plug-ins/script-fu/script-fu.c
	* plug-ins/script-fu/siod-wrapper.[ch]
	* plug-ins/script-fu/siod/slib.c: applied a patch from Kevin
	Cozens that removes an unneeded pipe which was causing problems
	on long output from the SIOD interpreter (bug #139200). Also
	shortened the welcome message.
2004-07-14 16:03:58 +00:00
Sven Neumann 7314f2d77f GUI polishing.
2004-07-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/pagecurl/pagecurl.c: GUI polishing.
2004-07-14 13:47:56 +00:00
Shlomi Fish 9c8fd71d3a Added more underscores to identifiers. Fixed some of the style (added
* plug-ins/gimpressionist/: Added more underscores to identifiers.
Fixed some of the style (added whitespace before the '(' in function
calls)
2004-07-14 13:28:01 +00:00
Philip Lafleur df393e0647 Now writes a global palette chunk, and empty palette chunks for the frames
2004-07-14  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/common/mng.c: Now writes a global palette chunk, and
	empty palette chunks for the frames that use it. This saves a
	bit of diskspace.
2004-07-14 12:18:58 +00:00
Michael Natterer 87b5322fdb added properties "gimp", "id", "width", "height" and "base-type". Moved
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage.c: added properties "gimp", "id", "width",
	"height" and "base-type". Moved all code from gimp_image_new()
	to GObject::constructor().

	* app/core/gimpimage-convert.c
	* app/core/gimpimage-crop.c
	* app/core/gimpimage-resize.c
	* app/core/gimpimage-rotate.c
	* app/core/gimpimage-scale.c
	* app/core/gimpimage-undo-push.c: set "width", "height" and
	"base-type" with g_object_set() so "notify" is emitted on the
	properties.

	* app/core/gimpimage-undo.c (gimp_image_undo_pop_stack):
	freeze/thaw property notifications around undoing/redoing so they
	are not emitted in the middle of the undo operation.
2004-07-14 12:12:50 +00:00
Michael Natterer 8e2e464f67 converted tabs to spaces, cleanup, reviewed new API docs.
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpitem.c: converted tabs to spaces, cleanup,
	reviewed new API docs.
2004-07-14 11:52:03 +00:00
Sven Neumann 00fed8dcba applied a patch done by Brion Vibber and Philip Lafleur that fixes loading
2004-07-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/tiff.c: applied a patch done by Brion Vibber
	and Philip Lafleur that fixes loading of CMYK TIFF images on
	big-endian hardware (bug #147328).
2004-07-14 10:57:13 +00:00
Philip Lafleur cf6ae91996 Properly check the return value of find_unused_ia_color(). The plugin will
2004-07-14  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/common/mng.c (respin_cmap): Properly check the return
	value of find_unused_ia_color(). The plugin will now save indexed
	MNGs correctly; fixes bug #139947. Also converted tabs to spaces.
2004-07-14 10:55:31 +00:00
Michael Natterer fe9d9be66b Code review & cleanup:
2004-07-14  Michael Natterer  <mitch@gimp.org>

	Code review & cleanup:

	* app/config/gimpguiconfig.[ch]: removed transparency-size,
	transparency-type and snap-distance properties...

	* app/config/gimpdisplayconfig.[ch]: ...and added them here.

	* app/display/gimpdisplayshell.c
	* app/tools/gimpmovetool.c: changed accordingly.

	* app/core/gimpimage-scale.[ch] (gimp_layer_scale_check): added a
	"max_memsize" parameter instead of looking it up in GimpGuiConfig.

	* app/actions/image-commands.c: changed accordingly.

	* app/core/gimparea.c
	* app/core/gimpdrawable.c: converted tabs to spaces, cleanup.

	* app/core/gimpprojection.[ch]: renamed IdleRenderStruct to
	GimpProjectionIdleRender, reordered functions, cleanup.

	* app/display/gimpdisplay-handlers.c
	* app/display/gimpdisplay.c: removed unused #includes.

	* app/display/gimpdisplayshell.[ch]
	* app/display/gimpdisplayshell-close.c: renamed
	shell->warning_dialog to shell->close_dialog, some random
	cleanups.

	* app/display/gimpdisplayshell-handlers.c
	* app/widgets/gimpselectioneditor.c: minor coding style cleanup.
2004-07-14 10:31:59 +00:00
William Skaggs 53249872f6 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/core/gimpitem.c: added documentation comments to some
	of the functions.
2004-07-14 00:32:09 +00:00
Michael Natterer 2226ddf7e4 app/display/Makefile.am new files for gimp_display_shell_close() and its
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/display/Makefile.am
	* app/display/gimpdisplayshell-close.[ch]: new files for
	gimp_display_shell_close() and its dialog & callback.

	* app/display/gimpdisplayshell.[ch]: removed from here.

	* app/actions/view-actions.c (view_close_view_cmd_callback):
	changed accordingly.
2004-07-14 00:15:57 +00:00
Sven Neumann 2f16b5f824 code cleanup. Use enums instead of a plethora of booleans. Added some
2004-07-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/pagecurl/pagecurl.c: code cleanup. Use enums instead of
	a plethora of booleans. Added some macros for readability. Allow
	to use a reversed gradient for colorizing the curl.
2004-07-13 23:05:11 +00:00
Michael Natterer 54cc251b08 app/core/Makefile.am app/core/core-types.h new interface which has
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/core/Makefile.am
	* app/core/core-types.h
	* app/core/gimppickable.[ch]: new interface which has
	get_image_type(), get_tiles() and get_color_at() methods.

	* app/core/gimpdrawable.[ch]
	* app/core/gimpimagemap.[ch]
	* app/core/gimpprojection.[ch]: implement GimpPickableInterface
	and removed public get_colot_at() functions.

	* app/core/gimpimage-pick-color.[ch]: removed typedef
	GimpImagePickColorFunc and gimp_image_pick_color_by_func(). Use
	gimp_pickable_pick_color() instead.

	* app/core/gimpimage-contiguous-region.c
	* app/core/gimpimage-crop.c
	* app/gui/info-window.c
	* app/paint/gimpconvolve.c
	* app/paint/gimpsmudge.c
	* app/tools/gimpbycolorselecttool.c
	* app/tools/gimpimagemaptool.c
	* app/widgets/gimpselectioneditor.c: use GimpPickable functions
	instead of the various get_color_at() functions. Simplifies code
	which has a "sample_merged" boolean. Various cleanups.
2004-07-13 23:04:05 +00:00