2002-09-02 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpviewabledialog.c: use GimpContainerView's
get_name_func utility stuff instead of reinventing the wheel.
(They should probably be renamed because they are not at all
GimpContainerView related).
2002-09-02 Michael Natterer <mitch@gimp.org>
* app/tools/gimpclonetool.c (gimp_clone_tool_draw): manually add
the src_drawable's offsets instead of implicitly using the
offsets of the active_drawable (fixes#92311).
2002-09-01 Michael Natterer <mitch@gimp.org>
GimpViewableDialogs everywhere, cleanup:
* libgimpwidgets/gimpstock.c: added texts for the RESIZE, SCALE
and CROP stock items.
* app/widgets/gimpviewabledialog.c: update the title when the
viewable's name changes.
* app/gui/color-notebook.[ch]: added color_notebook_viewable_new()
which creates a GimpViewableDialog.
* app/widgets/gimpgradienteditor.[ch]
* app/gui/colormap-editor-commands.c
* app/gui/file-new-dialog.c
* app/gui/gradient-editor-commands.c
* app/gui/palette-editor-commands.c
* app/undo_history.c: use GimpViewableDialogs and the new
color_notebook constructor.
* app/gui/convert-dialog.c: #include "widgets/gimpviewabledialog.h"
* app/gui/image-commands.c
* app/gui/info-dialog.c
* app/gui/resize-dialog.c: minor cleanups.
* app/gui/info-window.c: cleaned up the whole thing, esp. the
"Extended" page. Added HSV color display to the color picker
frame. Set the icons as frame titles, stuff...
* app/tools/gimpimagemaptool.[ch]: removed "shell_title",
"shell_name" and "stock_id" from the GimpImageMapTool struct
because they can be obtained from the tool's GimpToolInfo object.
* app/tools/gimpbrightnesscontrasttool.c
* app/tools/gimpcolorbalancetool.c
* app/tools/gimpcurvestool.c
* app/tools/gimphuesaturationtool.c
* app/tools/gimplevelstool.c
* app/tools/gimpposterizetool.c
* app/tools/gimpthresholdtool.c: changed accordingly.
* app/tools/gimphistogramtool.c: same here: take values from
tool->tool_info instead of hardcoding them.
* app/tools/gimpcroptool.[ch]: removed the static crop dialog
variables and added them to the GimpCropTool struct. Feels safer
and makes the callback code much simpler. Use stock items for the
dialog's "Resize" and "Crop" buttons.
* app/tools/gimpmeasuretool.c
* app/tools/gimprotatetool.c: for consistency don't name the tools
"Blah Tool", also the dialog titles need to match the menu
entries.
Unrelated:
* libgimpwidgets/gimpwidgets.c: the recently changed, gtk-doc
comment was correct, as gtk-doc takes the parameter names from
the header, not the .c file.
* app/tools/gimptransformtool.c: set the transform tool's state to
TRANSFORM_CREATING after changing displays, so the initial matrix
components are saved correctly for the "Reset" function.
2002-09-01 Manish Singh <yosh@gimp.org>
* modules/Makefile.am: use AM_CPPFLAGS instead of CPPFLAGS
* modules/cdisplay_gamma.c
* modules/cdisplay_highcontrast.c: changed deprecated calls
* modules/colorsel_triangle.c: #undef GTK_DISABLE_DEPRECATED,
still needs to be fixed for use of GtkPreview
2002-08-30 Michael Natterer <mitch@gimp.org>
* app/widgets/Makefile.am
* app/widgets/widgets-types.h
* app/widgets/gimpviewabledialog.[ch]: new dialog widget featuring
a title bar containing a stock icon, a description, the viewable's
name and a preview. Will be used for all viewable related dialogs
and serves as a common place to control their look & feel.
* app/tools/gimpimagemaptool.[ch]: removed the code which did
almost the same and use GimpViewableDialog.
* app/gui/info-dialog.[ch]: extended the API so it has enough
information to create a GimpViewableDialog.
* app/gui/channels-commands.c
* app/gui/convert-dialog.c
* app/gui/gradient-editor-commands.c
* app/gui/image-commands.c
* app/gui/info-window.c
* app/gui/layers-commands.c
* app/gui/offset-dialog.c
* app/gui/qmask-commands.c
* app/gui/resize-dialog.c
* app/gui/vectors-commands.c
* app/tools/gimpcolorpickertool.c
* app/tools/gimpcroptool.c
* app/tools/gimphistogramtool.c
* app/tools/gimpmeasuretool.c
* app/tools/gimpperspectivetool.c
* app/tools/gimprotatetool.c
* app/tools/gimpscaletool.c
* app/tools/gimpsheartool.c: use GimpViewableDialogs
* themes/Default/gtkrc: apply the dialog style to "*Gimp*Dialog*",
not only "*GimpDialog*" so it covers GimpViewableDialog.
2002-08-29 Michael Natterer <mitch@gimp.org>
* app/core/gimpchannel.c: fixed wrong g_return_if_fail() in
gimp_channel_feather() so the function can be called again (fixes
#91923). Also added more g_return_if_fail() where they were
missing and cleaned up everything a bit.
2002-08-28 Michael Natterer <mitch@gimp.org>
* app/tools/gimpimagemaptool.[ch]: added a tool icon and
descriptive string to the dialog's title box. Create the
drawable preview with is_popup == TRUE so it doesn't show
layers in the image context. Still not perfect...
* app/tools/gimpbrightnesscontrasttool.c
* app/tools/gimpcolorbalancetool.c
* app/tools/gimpcurvestool.c
* app/tools/gimphuesaturationtool.c
* app/tools/gimplevelstool.c
* app/tools/gimpposterizetool.c
* app/tools/gimpthresholdtool.c: Chain up early in initialize()
and return if gdisp == NULL. Set stock_id and desc_text so
GimpImageMapTool can display them. Added lots of mnemonics
(#80804). Use gimp_size_entry_new() instead of manually creating
the slider+spinbutton stuff.
* app/tools/gimpcurvestool.c
* app/tools/gimphistogramtool.c
* app/tools/gimplevelstool.c: changed widgets packing to make them
resizable without strange effects. Put the "Load", "Save" and
"Auto" buttons into a frame.
* app/tools/gimphuesaturationtool.c: use GimpColorAreas instead of
deprecated GtkPreviews. Arranged the color previews and their
radio buttons as a color wheel. Not the best solution maybe but
IMHO better than the old GUI.
2002-08-28 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpdrawablepreview.c (gimp_drawable_preview_render):
look at drawable->offset_[xy] != 0 when deciding whether to offset
the preview. Fixes bug where layers of the size of the image were
previewed with offset (0,0), regardless of their real offset.
2002-08-28 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpchannellistview.c: removed all component item
signal handling code, which is cool...
* app/widgets/gimpcomponentlistitem.c: ...and added it here, which
is not so cool because it adds Extra Ugliness (TM). At least it
fixes part one of #90967.
2002-08-28 Michael Natterer <mitch@gimp.org>
* app/undo.c (undo_pop_layer)
* app/core/gimpimage.c (gimp_image_[add|remove]_layer): emit
"alpha_changed" from the image if we started (or ended up)
with an image containing one layer without alpha.
* app/core/gimplayer.c: use gimp_container_num_children() instead
of accessing container->num_children manually.
2002-08-28 Sven Neumann <sven@gimp.org>
* plug-ins/common/rotate.c (rotate): check if the active drawable
is a layer before using gimp_layer functions on it.
2002-08-27 Michael Natterer <mitch@gimp.org>
* app/core/gimpimage-mask.c (gimp_image_mask_float): fixed a bug
introduced by myself on 2001-12-13: the floating selection layer
needs to be of the type of it's associated drawable, which may be
different from the image's type if it is a channel or layer mask
(fixes#91814).
2002-08-27 Manish Singh <yosh@gimp.org>
* devel-docs/lib*/Makefile.am: add dummy all-local rules for the
!gtk-doc case, to fix problems with some automake/make combos
* modules/Makefile.am: use lib instead of libexec to appease automake
1.6
2002-08-27 Michael Natterer <mitch@gimp.org>
* app/widgets/gimppreview.[ch]: added #define for
GIMP_PREVIEW_MAX_BORDER_WIDTH instead of hardcoding it all over
the place, cleanup.
2002-08-27 Michael Natterer <mitch@gimp.org>
* app/plug-ins/plug-in.c (plug_in_close,
plug_in_handle_proc_uninstall): don't forget to g_free() the
proc_def struct after removing a temporary procedure.
* app/plug-ins/plug-ins.c: iterate lists with for() loops,
cleanup.
2002-08-27 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpdialogfactory.c: if a dialog constructor fails
to return a GimpDockable, destroy the dock we created for the
dockable instead of leaking it. Cleanup.
2002-08-27 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpitemfactory.c: g_strdup(entry->help_path) if
static_entry == FALSE.
* app/gui/file-open-dialog.c
* app/gui/file-save-dialog.c
* app/gui/plug-in-menus.c: free the help string after adding
a menu item with static_entry == FALSE.
2002-08-27 Michael Natterer <mitch@gimp.org>
* app/tools/gimptexttool.c: changed the default text to
"No, you can't change this text. Please DON'T report this bug."
2002-08-27 Michael Natterer <mitch@gimp.org>
* app/base/curves.h: removed #defines and added enum CurvesType
instead.
* app/core/gimpchannel.c: use TRANSPARENT_OPACITY and
OPAQUE_OPACITY instead of 0 and 255.
* app/core/gimplayer.c (gimp_layer_create_mask): fixed inverse
layer mask creation by setting GIMP_CHANNEL(mask)->bounds_known to
FALSE correctly (fixes#90982). Also optimized mask creation
by calling gimp_channel_all() and gimp_channel_clear() for
white and black masks.
2002-08-27 Sven Neumann <sven@gimp.org>
* app/gui/menus.c
* app/gui/select-commands.[ch]: added a menu entry that toggles
the QuickMask state and bound Shift-Q to it (bug #86580).
2002-08-26 Sven Neumann <sven@gimp.org>
* plug-ins/sel2path/sel2path.c: changed dialog name as suggested
in bug-report #88905 and did some code cleanup while I was at it.
2002-08-26 Michael Natterer <mitch@gimp.org>
Color correction tool chopping:
* app/Makefile.am
* app/image_map.[ch]: removed...
* app/core/Makefile.am
* app/core/core-types.h
* app/core/gimpimagemap.[ch]: ...and added here as object.
* app/base/Makefile.am
* app/base/base-types.h
* app/base/color-balance.[ch]
* app/base/curves.[ch]
* app/base/hue-saturation.[ch]
* app/base/threshold.[ch]: the lowlevel color correction functions
plus their parameter structs cut out of the resp. tools.
* app/core/core-enums.[ch]: removed GimpTransferMode enum...
* app/base/base-enums.[ch]: ...added it here. Also added
GimpHueRange for the new hue-saturation files.
* tools/pdbgen/enums.pl
* libgimp/gimpenums.h
* plug-ins/script-fu/script-fu-constants.c: regenerated.
* app/tools/Makefile.am
* app/tools/gimpcolorbalancetool-transfer.c: removed (code went
to base/color-balance.c).
* app/tools/gimpimagemaptool.[ch]: added most code which was
diplicated in subclasses. Create the dialog here with a nice title
bar including image preview and name (fixes#66033). Added virtual
functions map(), dialog() and reset() which need to be implemented
by subclasses.
* app/tools/gimpbrightnesscontrasttool.[ch]
* app/tools/gimpcolorbalancetool.[ch]
* app/tools/gimpcurvestool.[ch]
* app/tools/gimphuesaturationtool.[ch]
* app/tools/gimplevelstool.[ch]
* app/tools/gimpposterizetool.[ch]
* app/tools/gimpthresholdtool.[ch]: removed tons of duplicated
code and simply implement GimpImageMapTool's virtual functions.
Removed all dialog structs and keep the variables in the tool
structs. The dialogs are now created on-the-fly and destroyed when
the tool goes away, which makes all callbacks much simpler and
safer. Lots of GUI & code cleanup in all dialogs.
* app/tools/gimpcurvestool.c
* app/tools/gimplevelstool.c: added separate "Reset Channel"
buttons and let the global "Reset" buttons reset all color
channels.
* app/tools/tools.c: the various antique foo_free() functions
don't exist any more.
* app/tools/gimphistogramtool.c: removed ImageMap field from
dialog struct (it was unused). Cleaned up dialog a bit.
* tools/pdbgen/Makefile.am: don't scan tools/gimphuesaturationtool.h
for enums.
* tools/pdbgen/pdb/color.pdb: use the new stuff from base/ and
don't include stuff from tools/ any more.
* app/pdb/color_cmds.c
* app/pdb/paint_tools_cmds.c: regenerated.
2002-08-22 Michael Natterer <mitch@gimp.org>
* themes/Default/images/stock-all-16.png
* themes/Default/images/stock-none-16.png
* themes/Default/images/stock-grow-16.png
* themes/Default/images/stock-shrink-16.png: new icons from Jimmac.
* themes/Default/images/Makefile.am
* themes/Default/imagerc
* libgimpwidgets/gimpstock.[ch]: added them to the stock system.
* app/gui/menus.c: use them.
* app/widgets/gimpselectioneditor.[ch]: use the icons and added
a "Save to Channel" button.
2002-08-22 Sven Neumann <sven@gimp.org>
* tools/pdbgen/pdb/gimprc.pdb
* app/pdb/gimprc_cmds.c (gimprc_query_invoker): don't leak the
result of gimprc_value_to_str().
* app/core/gimpdrawable-preview.c (gimp_drawable_preview_scale):
use g_new0() instead of g_new() followed by memset().
* plug-ins/script-fu/script-fu-server.c (server_log): free the
string after logging it.
2002-08-22 Michael Natterer <mitch@gimp.org>
* app/paint/paint.c: unref the paint info objects after adding
them to their container.
* app/widgets/toolbox.c: free the tooltip string after setting it.
* app/gui/session.c: spit out the correct warning if (position x y)
could not be parsed.
2002-08-22 Michael Natterer <mitch@gimp.org>
* configure.in: bumped version number to 1.3.9
* app/tools/gimpbycolorselecttool.[ch]: removed the ByColorDialog
and cleaned up the code.
* app/widgets/Makefile.am
* app/widgets/widgets-types.h
* app/widgets/gimpselectioneditor.[ch]: added new widget
GimpSelectionEditor with same same functionality as the old
ByColorDialog which can be open all the time (independent of the
active tool).
* app/widgets/gimppreview.[ch]: added gimp_preview_new_by_type()
so previews can be created without a viewable.
* app/widgets/gimppreview-utils.[ch]: changed
gimp_preview_type_from_viewable() to
gimp_preview_type_from_viewable_type().
* app/gui/dialogs-constructors.[ch]
* app/gui/dialogs.c
* app/gui/menus.c: register the new dialog type.
2002-08-22 Michael Natterer <mitch@gimp.org>
* app/undo.c: compress emissions of "mask_changed" and
"qmask_changed" across undo groups.
* app/core/gimpimage-mask.c: set GIMP_DRAWABLE(mask)->preview_valid
to FALSE in gimp_image_mask_invalidate(), not in
gimp_image_mask_push_undo(). Fixes selection preview rendering
after a mask undo.
2002-08-22 Michael Natterer <mitch@gimp.org>
* app/display/gimpdisplayshell-render.c: allocate all temporary
render bufs and check bufs large enough for GIMP_PREVIEW_MAX_SIZE
(which is 1024). Fixes crashes with too large navigation previews.
2002-08-22 Michael Natterer <mitch@gimp.org>
Fixed usage of uninitialized memory found by valgrind,
plus some cleanup:
* app/base/pixel-region.[ch]: allocate PixelRegionIterators and
PixelRegionHolders with g_new0(). Changed return values of
pixel_regions_register() and pixel_regions_process() from gpointer
to PixelRegionIterator*
* app/base/pixel-processor.c: no need to cast the above return values.
* app/base/temp-buf.[ch]: initialize PixelRegions with { 0 }
before using them for TempBufs.
* app/gui/device-status-dialog.c: initialize colors before
passing them to gimp_color_area_new().
Michael Natterer