2004-10-07 Michael Natterer <mitch@gimp.org>
* app/actions/view-actions.c: changed zoom actions to be
GimpEnumActions using the GimpActionSelectType enum. Enables
keyboard shortcuts for useless stuff like "zoom out a lot", and
makes them better accessible for external controllers.
* app/actions/view-commands.[ch]: renamed view_zoom_cmd_callback()
to view_zoom_explicit_cmd_callback(), removed the zoom_in and
zoom_out callbacks and added a new view_zoom_cmd_callback() for
the new GimpActionSelectType-based actions. The implementation of
the new zoom types is questionable but now there is a place where
nomis can fill in nice formulas...
2004-10-06 Michael Natterer <mitch@gimp.org>
* app/tools/gimpeditselectiontool.[ch]: added new parameter
"gboolean propagate_release" to gimp_edit_slection_tool_start()
and remember it in the GimpEditSelectionTool struct. If requested,
propagate GimpTool::button_release() to the tool below in the tool
stack.
* app/tools/gimpselectiontool.c (gimp_selection_tool_start_edit):
pass FALSE so we don't get the button_release().
* app/tools/gimpmovetool.[ch]: pass TRUE so we get
button_release(). If moving a layer or path in "pick active" mode,
remember the old active layer/path and switch back to it in
button_release(). Fixes bug #97734.
Unrelated:
* app/tools/gimpeditselectiontool.c
(gimp_edit_selection_tool_motion): set "first_move" to FALSE only
if a move actually happened. Fixes un-undoable moves at high zoom
factors.
2004-10-06 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpdnd.c (gimp_dnd_data_drag_begin): remember for
which GdkDragContext the icon_widget was made.
(gimp_dnd_data_drag_end): destroy the icon_widget only if it was
created for this GdkDragContext. Fixes broken DND icon_widgets
when dragging the same source again while the old icon_widget is
still floating back from an unsuccessful drop. Fixes bug #139337.
2004-10-06 Michael Natterer <mitch@gimp.org>
* tools/pdbgen/lib.pl: for deprecated procedures, create a gtk-doc
comment that contains a link to the replacement procedure and
doesn't contain redundant information.
* tools/pdbgen/pdb/text_tool.pdb: fixed names of replacement
procedures.
* libgimp/gimpbrushes.c
* libgimp/gimpgradients.c
* libgimp/gimppalettes.c
* libgimp/gimppatterns.c: made the handwritten gtk-doc comments of
deprecated procedures look like the generated ones.
* app/pdb/text_tool_cmds.c
* libgimp/gimpbrushes_pdb.c
* libgimp/gimpgradients_pdb.c
* libgimp/gimppalettes_pdb.c
* libgimp/gimppatterns_pdb.c
* libgimp/gimptexttool_pdb.c: regenerated.
2004-10-06 Michael Natterer <mitch@gimp.org>
* app/tools/gimp-tools.c (gimp_tools_restore): reset the tool
options before deserializing so they have the correct default
values. Fixes bug #120832.
* app/tools/gimpbucketfilloptions.c
* app/tools/gimpmagnifyoptions.c
* app/tools/gimpselectionoptions.c
* app/tools/gimptransformoptions.c: removed all set_defaults()
utility functions and moved their code to reset(). The change
above calls them automatically so there is no need to call them
from the GUI constructors any more.
2004-10-06 Michael Natterer <mitch@gimp.org>
* plug-ins/script-fu/scripts/selection-round.scm: use a
scale_entry instead of a spinbutton, changed mnemonic from "R" to
"E", indentation.
* plug-ins/script-fu/scripts/test-sphere.scm: s/SF_BRUSH/SF-BRUSH/
in a comment.
2004-10-06 Sven Neumann <sven@gimp.org>
* plug-ins/script-fu/scripts/selection-round.scm: applied patch by
Alan Horkan that improves usability and usefulness of this script.
Did some code cleanup and added the old procedure for backward
compatibility. Fixes bug #145147.
* menus/image-menu.xml.in: renamed placeholder in Image->Select
from "Outline" to "Modify".
2004-10-06 Michael Natterer <mitch@gimp.org>
* app/pdb/procedural_db.h (struct ProcRecord): changed new member
"deprecated" from "gboolean" to a "gchar*" which holds the name of
the replacement procedure.
* tools/pdbgen/app.pl: changed accordingly.
* app/plug-in/plug-in-message.c (plug_in_handle_proc_run): show
the name of the replacement procedure in the warning message.
* tools/pdbgen/stddefs.pdb: added utility function
std_pdb_deprecated() which takes the name of the replacement
procedure and fills the blurb, help, author, copyright, date and
deprecated fields of the procedure definition.
* tools/pdbgen/pdb/brushes.pdb
* tools/pdbgen/pdb/gradients.pdb
* tools/pdbgen/pdb/image.pdb
* tools/pdbgen/pdb/palettes.pdb
* tools/pdbgen/pdb/patterns.pdb
* tools/pdbgen/pdb/text_tool.pdb: use it instead of duplicating
the same code and strings for all deprecated procedures.
* app/pdb/*_cmds.c
* libgimp/gimppatterns_pdb.c
* libgimp/gimptexttool_pdb.c: regenerated.
20
2004-10-06 Michael Natterer <mitch@gimp.org>
* app/pdb/procedural_db.h (struct ProcRecord): changed new member
"deprecated" from "gboolean" to a "gchar*" which holds the name of
the replacement procedure.
* tools/pdbgen/app.pl: changed accordingly.
* app/plug-in/plug-in-message.c (plug_in_handle_proc_run): show
the name of the replacement procedure in the warning message.
* tools/pdbgen/stddefs.pdb: added utility function
std_pdb_deprecated() which takes the name of the replacement
procedure and fills the blurb, help, author, copyright, date and
deprecated fields of the procedure definition.
* tools/pdbgen/pdb/brushes.pdb
* tools/pdbgen/pdb/gradients.pdb
* tools/pdbgen/pdb/image.pdb
* tools/pdbgen/pdb/palettes.pdb
* tools/pdbgen/pdb/patterns.pdb
* tools/pdbgen/pdb/text_tool.pdb: use it instead of duplicating
the same code and strings for all deprecated procedures.
* app/pdb/*_cmds.c: regenerated.
2004-10-06 Michael Natterer <mitch@gimp.org>
Fixed the scale constraints radio buttons:
* app/tools/gimptransformoptions.c (gimp_transform_options_gui):
initialize the radio group with the correct value instead of
resetting the model before creating the group.
(gimp_scale_options_constrain_callback): change the model
only if the radio button became active.
(gimp_scale_options_constrain_notify): new callback which makes
the radio buttons a real view on the model again (fixes GUI
updates on modifier press/release).
2004-10-06 Sven Neumann <sven@gimp.org>
* app/actions/plug-in-actions.c (plug_in_actions_update): an image
doesn't necessarily have a drawable. Handle the case when it doesn't.
2004-10-06 Sven Neumann <sven@gimp.org>
* app/app_procs.[ch]
* app/batch.[ch]
* app/main.c: added new command-line option "--batch-interpreter"
that allows to specify the procedure to use to process batch
commands. Removed the perl-server hack but kept Script-Fu as the
default for backward compatibility.
* docs/gimp.1.in: documented the new option.
2004-10-06 Michael Natterer <mitch@gimp.org>
* app/actions/file-commands.c (file_revert_confirm_callback):
removed the code which sets the new image on all contexts where
the old image was set...
* app/display/gimpdisplay-foreach.c (gimp_displays_reconnect):
...and added it here so it happens for all calls of this function,
also from the PDB. Fixes bug #154638.
2004-10-06 Michael Natterer <mitch@gimp.org>
* tools/pdbgen/pdb/brush.pdb: return the mask's bpp and the
brush's pixmap data if it has one.
* tools/pdbgen/pdb/pattern.pdb: cleaned up.
* tools/pdbgen/pdb/image.pdb: added $deprecated = 1 to deprecated
functions even if they are not exported to libgimp any more.
* app/pdb/procedural_db.h (struct ProcRecord): added member
"gboolean deprecated".
* tools/pdbgen/app.pl
* app/xcf/xcf.c: fill it accordingly.
* app/plug-in/plug-in-message.c (plug_in_handle_proc_run): warn
not only for deprecated procedured which are in the compat hach
table, but also for procedures with deprecated flag set to TRUE.
* app/pdb/*_cmds.c
* libgimp/gimpbrush_pdb.[ch]
* libgimp/gimppattern_pdb.[ch]: regenerated.
* libgimp/gimpbrushmenu.c
* plug-ins/gfig/gfig-style.c: changed accordingly.
2004-10-06 Sven Neumann <sven@gimp.org>
* app/core/gimpimage.[ch]: store the time when the image is first
dirtied.
* app/display/gimpdisplayshell-close.c: tell the user what time
period of changes will be lost when the image is not saved.
2004-10-05 Sven Neumann <sven@gimp.org>
* plug-ins/script-fu/scripts/addborder.scm: simple change to make
the script work on all image types, not only RGB.
2004-10-05 Sven Neumann <sven@gimp.org>
* libgimpwidgets/gimpwidgets.c (gimp_table_attach_aligned):
left-justify the label.
* libgimpwidgets/gimpdialog.c: if a button with GTK_RESPONSE_HELP
is being added, hide the automatically added help button.
* plug-ins/script-fu/script-fu-interface.c: five buttons are too
much for the action area. Renamed the About button to Help and
resurrected the help button in the about dialog as a way to get to
the actual help pages (pressing F1 will get you there as well).
2004-10-05 Michael Natterer <mitch@gimp.org>
* plug-ins/script-fu/siod-wrapper.c (marshall_proc_db_call):
- check the number of elements of array parameters against
the actually passed array and spit a proper error message
instead of trashing the wire. Fixes bug #154266.
- g_strdup()/g_free() the proc_name so it doesn't get mungled
by convert_string().
- added missing implementation of INT16ARRAY return values.
- cleaned up STRINGARRAY value implementations to work like
all other array values.
2004-10-04 Sven Neumann <sven@gimp.org>
* libgimp/gimpdrawablepreview.c (gimp_drawable_preview_draw_area):
take drawable offsets into account when masking the preview with
the selection mask.
2004-10-04 Michael Natterer <mitch@gimp.org>
* tools/pdbgen/pdb/gimprc.pdb (gimprc_query, gimprc_set): disallow
the empty string as token. Spotted by Kevin Cozens.
* app/pdb/gimprc_cmds.c: regenerated.
2004-10-04 Sven Neumann <sven@gimp.org>
* libgimp/gimpaspectpreview.c (gimp_aspect_preview_draw_buffer):
no need to set bpp before calling gimp_drawable_get_thumbnail_data().
* libgimp/gimpaspectpreview.c: (gimp_aspect_preview_draw_buffer) only
apply the effect inside the current selection. This, together with my
previous commit fixes bug #132194.
2004-10-04 Sven Neumann <sven@gimp.org>
* app/config/gimpguiconfig.[ch]
* app/config/gimprc-blurbs.h: added gimprc option "show-help-button".
* app/dialogs/preferences-dialog.c: added a GUI for it.
* app/dialogs/file-save-dialog.c
* app/dialogs/image-new-dialog.c
* app/dialogs/quit-dialog.c
* app/display/gimpdisplayshell-close.c
* app/widgets/gimphelp-ids.h: don't set help-ids on confirmation
dialogs.
* libgimpbase/gimpprotocol.[ch]
* libgimp/gimp.[ch]: added boolean "show_help_button" to the
config message.
* app/plug-in/plug-in-run.c: pass the new preference to the plug-in.
* libgimpwidgets/gimpdialog.[ch]: added new function that allows to
set whether new dialogs should get a help button added.
* app/gui/gui.c
* libgimp/gimpui.c: call gimp_dialogs_show_help_button() according
to the gimprc settings.
2004-10-04 Sven Neumann <sven@gimp.org>
* plug-ins/script-fu/script-fu-interface.c (script_fu_about):
enabled line wrapping on labels.
(script_fu_interface): substitute underscores by hyphens to
generate the help_id from the procedure name.
2004-10-04 Michael Natterer <mitch@gimp.org>
* libgimpbase/gimpwire.c: added assertions to make sure "count" is
always >= 0. Turns the crash described in bug #154266 into a
warning plus corrupted wire state :) Real fix (in script-fu) will
follow. Untabified.
2004-10-04 Michael Natterer <mitch@gimp.org>
* libgimpwidgets/gimphelpui.c: untabified.
(gimp_help_callback): use GIMP_HELP_ID instead of "gimp-help-id".
Michael Natterer