Commit Graph

8502 Commits

Author SHA1 Message Date
William Skaggs 977952caff Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/tools/gimprectangleselecttool.c
	* app/tools/gimprectangletool.[ch]:simplify code by
	removing unneeded properties and getters/setters.
2006-09-23 21:22:33 +00:00
William Skaggs 60611ebb54 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/tools/gimprectangleoptions.[ch]
	* app/tools/gimprectangleselecttool.c
	* app/tools/gimprectangletool.c
	* app/tools/gimpselectionoptions.c: move "auto-shrink"
	and "shrink-merged" from selection options to
	rectangle options where they belong; now shown
	for crop tool as well as rect select.
2006-09-23 20:45:06 +00:00
William Skaggs bc355f4f45 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/widgets/gimppropwidgets.c
	* app/tools/gimprectangleoptions.c: add functionality
	for aspect ratio control.
2006-09-23 19:40:40 +00:00
William Skaggs 2c07e922a2 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/actions/tools-actions.c
	* app/actions/tools-commands.[ch]: add new actions for
	toggling "fixed-aspect" and "fixed-center" options of
	rectangle tools.

	* app/tools/gimprectangletool.[ch]
	* app/tools/gimprectangleselecttool.c
	* app/tools/gimpcroptool.c: rely on new actions for
	keyboard control, not on modifiers pressed after
	mouse1-down.
2006-09-23 19:38:26 +00:00
William Skaggs 7b8d12e0b6 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/widgets/gimppropwidgets.[ch]
	* app/tools/gimprectangleoptions.c
	* app/tools/gimprectangletool.c: more work on option
	layout and handling.
2006-09-22 18:27:21 +00:00
Michael Natterer d271c7387c terminate the spaces string correctly. Spotted by bill.
2006-09-22  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpstatusbar.c (gimp_statusbar_progress_style_set):
	terminate the spaces string correctly. Spotted by bill.
2006-09-22 17:57:11 +00:00
Michael Natterer 1419751614 changed all message setting functions to use printf-style argument lists.
2006-09-22  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpstatusbar.[ch]: changed all message setting
	functions to use printf-style argument lists. Added new API to
	show a temporary message that stays on top regardless of any other
	message activity and disappears after 3 seconds.

	* app/actions/edit-commands.c: show a statusbar message when
	pasting fails because the clipboard contains no image data. Pop a
	dialog when "Paste as New" fails. Addresses bug #357059 for
	internal functions.

	* app/display/gimpdisplayshell-title.c
	* app/gui/gui.c
	* app/tools/gimptool.c: changed accordingly.
2006-09-22 16:44:47 +00:00
Sven Neumann 9789d18b94 always recalculate the selection when restarting it.
2006-09-22  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-selection.c: always recalculate the
	selection when restarting it.
2006-09-22 14:27:07 +00:00
Michael Natterer 59a3dd1405 also look at shell->space_release_pending when deciding whether to return
2006-09-22  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_space_released): also look at
	shell->space_release_pending when deciding whether to return early.
2006-09-22 14:17:33 +00:00
Sven Neumann a69c1ff174 app/gui/gui-message.c moved utility function to gimpwidgets-utils.
2006-09-22  Sven Neumann  <sven@gimp.org>

	* app/gui/gui-message.c
	* app/widgets/gimpwidgets-utils.[ch]: moved utility function to
	gimpwidgets-utils.

	* app/core/gimp-gui.[ch]
	* app/gui/gui-vtable.c: added a progress parameter to
	gimp_pdb_dialog_new() and make the dialog transient to the progress
	window.

	* tools/pdbgen/pdb/brush_select.pdb
	* tools/pdbgen/pdb/font_select.pdb
	* tools/pdbgen/pdb/gradient_select.pdb
	* tools/pdbgen/pdb/palette_select.pdb
	* tools/pdbgen/pdb/pattern_select.pdb: pass progress to
	gimp_pdb_dialog_new().

	* app/pdb/brush_select_cmds.c
	* app/pdb/font_select_cmds.c
	* app/pdb/gradient_select_cmds.c
	* app/pdb/palette_select_cmds.c
	* app/pdb/pattern_select_cmds.c: regenerated.

	* libgimp/gimpselectbutton.c: cosmetics.
2006-09-22 09:24:41 +00:00
William Skaggs 24546bc818 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/widgets/gimppropwidgets.c (gimp_prop_aspect_ratio_new):
	some small bug-fixes.

	* app/tools/gimprectangleoptions.[ch]: major revision.  Got
	rid of lots of unneeded getter/setter-clutter, simplified
	set of options and appearance of gui.  Still work in progress.

	* app/tools/gimprectangleselectoptions.c
	* app/tools/gimprectangletool.c: corresponding changes.
2006-09-21 20:16:25 +00:00
William Skaggs 43eb155668 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/tools/gimpselectionoptions.[ch]: remove
	rectangle-related options no longer used anywhere.
2006-09-21 20:12:23 +00:00
William Skaggs 6a625ced0c Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/paint-funcs/scale-funcs.[ch]:  commit patch from "gg"
	to fix Lanczos problems, addresses bug #167956 and
	bug #355178.
2006-09-21 19:48:44 +00:00
Sven Neumann 26ecfe60b7 use the same code on all platforms. The optimization for bytes == 4 was
2006-09-21  Sven Neumann  <neumann@jpk.com>

	* app/base/tile-manager.c (read_pixel_data_1) (write_pixel_data_1):
	use the same code on all platforms. The optimization for bytes == 4
	was pointless anyway.
2006-09-21 09:45:07 +00:00
Michael Natterer a9c03ad6b6 fix build on big endian.
2006-09-21  Michael Natterer  <mitch@gimp.org>

	* app/base/tile-manager.c (read_pixel_data_1): fix build on
	big endian.
2006-09-21 01:16:09 +00:00
William Skaggs 7903feff20 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/display/gimpcanvas.[ch]
	* app/tools/gimpdrawtool.[ch]: remove recently added code relating
	to stippled xor drawing -- not handled well by some display
	drivers.

	* app/tools/gimprectangletool.c: improve drawing of handles.
2006-09-20 20:23:49 +00:00
Sven Neumann d3904c6d85 fixed endian issues (bug #340965).
2006-09-20  Sven Neumann  <sven@gimp.org>

	* app/base/tile-manager.c (read_pixel_data_1) (write_pixel_data_1):
	fixed endian issues (bug #340965).
2006-09-20 10:38:42 +00:00
Michael Natterer 11abe64f58 if the plug-in is in a different process group than GIMP, kill the entire
2006-09-20  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimpplugin.c (gimp_plug_in_close): if the plug-in is
	in a different process group than GIMP, kill the entire group so
	the plug-in's children are killed too.

	* plug-ins/uri/uri-backend-wget.c (uri_backend_load_image): open
	a process group so the wget process gets killed (bug #356643).
2006-09-20 10:31:22 +00:00
Sven Neumann 715d452e2e draw slider positions more accurately, fixed incorrect use of
2006-09-20  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphistogrambox.c: draw slider positions more
	accurately, fixed incorrect use of GtkAdjustments.
2006-09-20 10:19:49 +00:00
Sven Neumann 9721459f87 removed unused variables and unused macro.
2006-09-20  Sven Neumann  <sven@gimp.org>

	* app/paint/gimpperspectiveclone.c: removed unused variables and
	unused macro.
2006-09-20 08:20:56 +00:00
Michael Natterer 7b0531aa91 implement GimpPaintCore::start() and set paint_core->use_saved_proj to
2006-09-20  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpsourcecore.c: implement GimpPaintCore::start()
	and set paint_core->use_saved_proj to TRUE when we are using
	the destination drawable image's projection as source. Return
	FALSE from start() if there is no src_drawable set and removed
	checks for src_drawable != NULL further down in the code path.

	* app/tools/gimpperspectiveclonetool.c (button_press)
	* app/tools/gimpsourcetool.c (button_press): don't fiddle with
	paint_core->use_saved_proj here.

	* app/paint/gimpclone.c: implement GimpPaintCore::start() and
	return FALSE if we are in pattern mode and there is no pattern to
	clone from. Removed GimpPaintCore::paint() implementation because
	all it did was popping a message if there is no pattern. Removed
	check for pattern != NULL and cleaned up the file a bit.

	* app/paint/gimpperspectiveclone.c (paint): removed message about
	no pattern to clone from.
2006-09-19 23:14:50 +00:00
Michael Natterer ca6afdf530 added gimp_gradient_flatten() which creates a copy of a gradient with all
2006-09-20  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpgradient.[ch]: added gimp_gradient_flatten() which
	creates a copy of a gradient with all colors that refer to FG or
	BG turned into constant colors.

	* app/core/gimpdrawable-blend.c (gradient_fill_region): create a
	flat copy of the gradient if it contains FG/BG colors. Avoids
	gazillions of context color lookups while rendering, depending on
	gradient and blend complexity.
2006-09-19 22:17:06 +00:00
Sven Neumann 3dc50859a7 don't leak the message.
2006-09-19  Sven Neumann  <sven@gimp.org>

	* app/core/gimp.c (gimp_message): don't leak the message.

	* app/file/file-utils.c (file_utils_find_proc): clear the error
	if we found a file procedure by matching the file extension.

	* plug-ins/common/png.c (load_image): don't call gimp_quit() if
	opening the file fails but return with GIMP_PDB_EXECUTION_ERROR.
2006-09-19 14:26:48 +00:00
Michael Natterer db51ce3a49 Fix disabling of deprecated procedures (bug #345733):
2006-09-19  Michael Natterer  <mitch@gimp.org>

	Fix disabling of deprecated procedures (bug #345733):

	* app/pdb/gimppdb.c (gimp_pdb_register_procedure): silently drop
	deprecated procedures if they are disabled via --pdb-compat-mode.

	* app/plug-in/gimpplugin-message.c (gimp_plug_in_handle_proc_run):
	remove code that handles deprecated procedures even when they are
	disabled, the change above makes this impossible.
	Call plug_in_params_to_args() also if we didn't find the
	procedure, so the PDB doesn't choke on NULL args.
2006-09-19 11:58:57 +00:00
William Skaggs 73a25c2a61 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/tools/gimpairbrushtool.c
	* app/tools/gimpaligntool.c
	* app/tools/gimpblendtool.c
	* app/tools/gimpbrightnesscontrasttool.c
	* app/tools/gimpbucketfilltool.c
	* app/tools/gimpbycolorselecttool.c
	* app/tools/gimpclonetool.c
	* app/tools/gimpcolorbalancetool.c
	* app/tools/gimpcolorizetool.c
	* app/tools/gimpcolorpickertool.c
	* app/tools/gimpconvolvetool.c
	* app/tools/gimpcroptool.c
	* app/tools/gimpcurvestool.c
	* app/tools/gimpdodgeburntool.c
	* app/tools/gimpellipseselecttool.c
	* app/tools/gimperasertool.c
	* app/tools/gimpfliptool.c
	* app/tools/gimpforegroundselecttool.c
	* app/tools/gimpfreeselecttool.c
	* app/tools/gimpfuzzyselecttool.c
	* app/tools/gimphealtool.c
	* app/tools/gimphuesaturationtool.c
	* app/tools/gimpinktool.c
	* app/tools/gimpiscissorstool.c
	* app/tools/gimplevelstool.c
	* app/tools/gimpmagnifytool.c
	* app/tools/gimpmeasuretool.c
	* app/tools/gimpmovetool.c
	* app/tools/gimppaintbrushtool.c
	* app/tools/gimppenciltool.c
	* app/tools/gimpperspectiveclonetool.c
	* app/tools/gimpperspectivetool.c
	* app/tools/gimpposterizetool.c
	* app/tools/gimprectangleselecttool.c
	* app/tools/gimprectangletool.c
	* app/tools/gimprotatetool.c
	* app/tools/gimpscaletool.c
	* app/tools/gimpsheartool.c
	* app/tools/gimpsmudgetool.c
	* app/tools/gimptexttool.c
	* app/tools/gimpthresholdtool.c
	* app/tools/gimpvectortool.c:  Apply patch from J. Baker,
	with some modifications, to improve tooltips and tool
	names.  Almost fixes bug #356137.
2006-09-18 18:00:22 +00:00
Sven Neumann b39784d20a rewrote the UI without tables and separators (eek). Also fixes bug
2006-09-18  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpaligntool.c: rewrote the UI without tables and
	separators (eek). Also fixes bug #355986.
2006-09-18 13:26:12 +00:00
Sven Neumann 152af52bfe do not migrate toolrc and the tool-options folder.
2006-09-17  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-user-install.c (user_install_migrate_files):
	do not migrate toolrc and the tool-options folder.
2006-09-17 19:29:07 +00:00
Michael Natterer 334f160ea3 app/tools/gimpperspectiveclonetool.c (button_press) need to instruct the
2006-09-16  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpperspectiveclonetool.c (button_press)
	* app/tools/gimpsourcetool.c (button_press): need to instruct the
	paint_core to make a copy of the projection whenever we clone from
	the same *image*, not from the same display. Fixes crash when
	cloning from the same image's projection in another view
	(bug #356209).
2006-09-16 21:49:53 +00:00
William Skaggs 3c2c165b9c Bill Skaggs <weskaggs@primate.ucdavis.edu>
Trying to implement some usability recommendations from
	Peter Sikking: bigger handles, more feedback to user.

	* app/display/gimpcanvas.[ch]: add
	GIMP_CANVAS_STYLE_XOR_STIPPLED to set of styles.

	* app/tools/gimpdrawtool.[ch]
	(gimp_draw_tool_draw_rectangle_stippled): new function.
	Needs a better stipple pattern, though.

	* app/tools/gimprectangletool.c: bigger handles in corners,
	and highlight thing that user is currently moving.
2006-09-15 00:01:59 +00:00
William Skaggs 769fd8c5a3 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/widgets/gimprectangletool.c: even if constraining to boundaries,
	keep updating rectangel when pointer goes outside boundaries.
	Fixes bug #355740.
2006-09-14 21:51:35 +00:00
William Skaggs 4ff0ca1c38 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/widgets/gimppropwidgets.[ch]: add prop widget specially
	for controlling aspect ratio.

	* app/tools/gimprectangleoptions.ch]: use "aspect-numerator"
	and "aspect-denominator" properties instead of "aspect",
	and use new prop widget in gui to set and display them.

	* app/tools/gimprectangletool.c: calculate aspect from
	numerator and denominator.
2006-09-14 17:11:24 +00:00
Michael Natterer 1db7c2075a when editing a "smooth" curve, update the image while dragging instead of
2006-09-14  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcurvestool.c (curves_graph_events): when editing a
	"smooth" curve, update the image while dragging instead of on
	button_release. Suggested by Joel Becker.
2006-09-14 17:05:43 +00:00
Sven Neumann 730e5ab597 app/widgets/gimpcontrollereditor.[ch] pass a GimpContext to
2006-09-14  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontrollereditor.[ch]
	* app/widgets/gimpcontrollerlist.c: pass a GimpContext to
	gimp_viewable_dialog_new().
2006-09-14 08:44:17 +00:00
Sven Neumann 14d80ba157 app/actions/image-actions.c app/dialogs/preferences-dialog.c
2006-09-14  Sven Neumann  <sven@gimp.org>

	* app/actions/image-actions.c
	* app/dialogs/preferences-dialog.c
	* app/tools/gimpvectortool.c
	* app/widgets/gimpcontrollereditor.c:
	* plug-ins/common/autocrop.c
	* plug-ins/common/max_rgb.c: resolved conflicting mnemonics, added
	some new ones (bug #355761).
2006-09-14 08:24:05 +00:00
Michael Natterer c133b39798 set a context on the GimpContainerEntry.
2006-09-14  Michael Natterer  <mitch@gimp.org>

	* app/dialogs/file-open-location-dialog.c: set a context on the
	GimpContainerEntry.
2006-09-13 23:44:20 +00:00
Michael Natterer 70cf90b0c8 Don't popup the completion when there is only a single match because we
2006-09-14  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcontainerentry.c: Don't popup the completion
	when there is only a single match because we already use inline
	completion.
2006-09-13 22:51:52 +00:00
Michael Natterer 936ee063e1 implement GimpContainerView::set_context() and set the renderers'
2006-09-14  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcontainerentry.c: implement
	GimpContainerView::set_context() and set the renderers'
	contexts. Fixes more preview rendering warnings.
	Connect to GtkEntryCompletion::match-selected in addition to
	GtkEntry::changed to select the active item. Makes the whole
	thing work a lot better.
2006-09-13 22:40:24 +00:00
Michael Natterer bb0d526498 Need to be more careful with setting a tool's focus_dislay now that tools
2006-09-13  Michael Natterer  <mitch@gimp.org>

	Need to be more careful with setting a tool's focus_dislay now
	that tools can receive modifier events in more circumstances
	(fixes warnings with GimpEditSelectionTool)

	* app/tools/gimptool.c (gimp_tool_button_release): ref the tool
	around the function's body (GimpEditSelectionTool unrefs itself in
	button_release()), don't reset the active_modifier_state if it is 0.

	(gimp_tool_set_focus_display): reset the active_modifier_state if
	it is != 0 and the tool had an old focus_display.

	* app/tools/tool_manager.c (tool_manager_push,pop_tool): set the
	old active_tool's focus_display on the new one.
2006-09-13 21:28:17 +00:00
Michael Natterer ca9825ecc5 added macro GIMP_PERSPECTIVE_CLONE_TOOL_GET_OPTIONS()
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpperspectiveclonetool.h: added macro
	GIMP_PERSPECTIVE_CLONE_TOOL_GET_OPTIONS()

	* app/tools/gimpperspectiveclonetool.c: use it. Some minor
	cleanups, removed unused includes.
2006-09-13 18:00:30 +00:00
Sven Neumann 1303b872e7 tools/pdbgen/pdb/color.pdb tools/pdbgen/pdb/drawable.pdb
2006-09-13  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/color.pdb
	* tools/pdbgen/pdb/drawable.pdb
	* tools/pdbgen/pdb/image.pdb
	* tools/pdbgen/pdb/layer.pdb
	* tools/pdbgen/pdb/paint_tools.pdb
	* tools/pdbgen/pdb/selection_tools.pdb: use the canonical form
when
	refering to parameters in the procedure description.
2006-09-13 17:56:40 +00:00
Michael Natterer d607b7da4d cosmetic cleanups, renamed gimp_smudge_nonclipped_painthit_coords() to
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpsmudge.c: cosmetic cleanups, renamed
	gimp_smudge_nonclipped_painthit_coords() to
	gimp_smudge_brush_coords ().
2006-09-13 17:32:36 +00:00
Sven Neumann 0fb9104817 removed "Resize" from the tool name and description.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcroptool.c (gimp_crop_tool_register): removed
	"Resize" from the tool name and description.
2006-09-13 16:03:24 +00:00
Sven Neumann 56cf1aba38 changed mnemonics (bug #355761).
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/dialogs/preferences-dialog.c: changed mnemonics (bug #355761).
2006-09-13 15:50:39 +00:00
Sven Neumann 7b53b46ba1 ref the context before destroying the dialog.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/dialogs/image-new-dialog.c (image_new_create_image): ref the
	context before destroying the dialog.
2006-09-13 12:13:33 +00:00
Michael Natterer a4edd11b28 simplified by calling gimp_draw_tool_pause/resume() unconditionally (it
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpbrushtool.c: simplified by calling
	gimp_draw_tool_pause/resume() unconditionally (it does no harm,
	regardless of whether the tool is in color picking mode or not).
	Return early in gimp_brush_tool_draw() if color picking is
	enabled.

	* app/tools/gimpsmudgetool.c (gimp_smudge_tool_init): don't enable
	color picking, the tool doesn't use FG or BG.
2006-09-13 11:04:49 +00:00
Michael Natterer 2e0f6b6b02 chain up before clearing src_drawable and src_display, so the draw tool
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpsourcetool.c (gimp_source_tool_control): chain
	up before clearing src_drawable and src_display, so the draw
	tool can undraw the source marker. Fixes bug #355746.
2006-09-13 10:56:24 +00:00
Michael Natterer c8800a628b don't access the src_pickable when cloning from a pattern. Fixes runtime
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpclone.c (gimp_clone_motion): don't access the
	src_pickable when cloning from a pattern. Fixes runtime warnings.
2006-09-13 10:53:22 +00:00
Michael Natterer 0a341138e2 app/tools/gimpmeasuretool.h fixed _GET_OPTIONS() macros.
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpmeasuretool.h
	* app/tools/gimppainttool.h: fixed _GET_OPTIONS() macros.
2006-09-13 10:44:40 +00:00
Sven Neumann bd754a97b0 update coordinates in status bar.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpblendtool.c (gimp_blend_tool_active_modifier_key):
	update coordinates in status bar.
2006-09-13 10:06:49 +00:00
Sven Neumann 7dc4ad0f8e update status bar and optional dialog window.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpmeasuretool.c
(gimp_measure_tool_active_modifier_key):
	update status bar and optional dialog window.
2006-09-13 06:49:20 +00:00