2004-01-28 Michael Natterer <mitch@gimp.org>
Added infrastructure to make sure we don't write to the global
brush, pattern etc. directories. Needed to make this configurable
because we can't rely on the global directories being read-only,
having certain names or being otherwise detectable at runtime in a
sane way. Fixes bug #132214.
* libgimpbase/gimpdatafiles.[ch]: added "const gchar *dirname" to
the GimpDataFileData struct so callbacks don't need to call
g_path_get_dirname() for each file.
* libgimpwidgets/gimpfileentry.c: made it work with non UTF-8
encoded filenames.
* libgimpwidgets/gimppatheditor.[ch]: ditto. Added GUI and API for
setting/getting a second "writable_path". The widget makes sure
that the writable_path is always a subset of the path.
* app/config/gimpconfig-utils.[ch]: added new function
gimp_config_build_writable_path().
* app/config/gimpcoreconfig.[ch]: added separate properties for
the writable brush, pattern, gradient, palette and font paths.
* app/config/gimprc-blurbs.h: added (still empty) blurbs for the
new properties.
* app/core/gimpdata.[ch] (gimp_data_set_filename): added parameter
"gboolean writable". Set data->writable to FALSE by default. If
"writable" is passed as TRUE, still check if we can write to the
file before setting data->writable to TRUE.
(gimp_data_create_filename): changed "data_path" parameter to
"dest_dir" and assume dest_dir is writable.
(gimp_data_duplicate): set data->dirty to TRUE to make sure
duplicated things will be saved.
* app/core/gimpbrush.c
* app/core/gimpbrushgenerated.c
* app/core/gimpbrushpipe.c
* app/core/gimpgradient.c
* app/core/gimppalette.c
* app/core/gimppattern.c: don't set the data's filename and don't
touch data->dirty in the _load() functions because that's done by
the data factory now. Don't touch data->dirty in the _duplicate()
functions because that's done by gimp_data_duplicate() itself now.
* app/core/gimpdatafactory.[ch] (gimp_data_factory_new): added
"writable_property_name" and remember it.
Added utility function gimp_data_factory_get_save_dir() which
determines the directory to save new datas to.
Added public function gimp_data_factory_data_save_single() which
saves a single data object.
Make sure new things get saved to the first writable directory
as specified in preferences.
* app/core/gimp.c (gimp_real_initialize): pass the writable_paths'
property names to gimp_data_factory_new().
* app/widgets/gimpdataeditor.c (gimp_data_editor_save_dirty): use
gimp_data_factory_data_save_single() instead of implementing
saving here.
* app/widgets/gimppropwidgets.[ch] (gimp_prop_path_editor_new):
added "const gchar *writable_property_name" parameter (can be
NULL).
Added the needed callbacks to handle the writable_path and made
the path_editor and file_entry code aware of non UTF-8 filename
encodings. Some general cleanup.
* app/gui/preferences-dialog.c: changed accordingly.
2004-01-28 Sven Neumann <sven@gimp.org>
* configure.in: according to the automake docs, we need to add
$(EXEEXT) explicitely for programs that are conditionally built
using configure substitutions instead of automake conditionals.
2004-01-28 Michael Natterer <mitch@gimp.org>
* app/config/gimpconfig-path.c (gimp_config_path_expand): return
early if gimp_config_path_expand_only() fails.
2004-01-28 Dave Neary <bolsh@gimp.org>
* plug-ins/common/tiff.c: Removed duplicate TIFF entry from save
dialog, and made the save handler point to the one that doesn't
pre-multiply by alpha. Reported on gimp-user by misfit-x. Also
changed default value to not destroy data on save.
2004-01-28 Pedro Gimeno <pggimeno@wanadoo.es>
* plug-ins/script-fu/scripts/grid-system.scm: Fix typo that prevented
using the inverse of the golden ratio (1/g) as a weight in the list.
2004-01-28 Michael Natterer <mitch@gimp.org>
* app/widgets/gimphelp-ids.h: updated help IDs for new/reordered
pages in the prefs dialog.
* app/gui/preferences-dialog.c (prefs_dialog_new): changed
accordingly.
2004-01-28 Manish Singh <yosh@gimp.org>
* plug-ins/script-fu/siod-wrapper.c (marshall_proc_db_call): validate
the types of the individual list members when passing parasites.
Fixes#93806.
2004-01-27 Manish Singh <yosh@gimp.org>
* app/paint-funcs/paint-funcs.c: inlined rotate_pointers, changed
prototypes and casts around so that we're compliant with C99 aliasing
rules.
2004-01-27 Manish Singh <yosh@gimp.org>
* app/composite/gimp-composite-generic.c
(gimp_composite_overlay_any_any_any_generic)
* app/paint-funcs/paint-funcs-generic.h (overlay_pixels): use more
than one temporary when stacking INT_MULTs, to avoid undefined
values.
2004-01-27 Manish Singh <yosh@gimp.org>
* app/paint/gimppaintcore.c (gimp_paint_core_interpolate): Use a real
GimpVector2 for vector operations, instead of stuffing everything
into a GimpCoords. C99 aliasing fix.
2004-01-27 Manish Singh <yosh@gimp.org>
* plug-ins/common/plugindetails.c: removed unused variable.
* plug-ins/common/nlfilt.c: declare nlfiltRow as inline in the
function definition as well.
2004-01-27 Manish Singh <yosh@gimp.org>
* configure.in: use AM_PATH_GIMPPRINT to get some additional
sanity checks.
* acinclude.m4: define AM_PATH_GIMPPRINT here, so we don't have
add a new autogen dependency.
* plug-ins/print/Makefile.am: Use GIMPPRINT_{CFLAGS,LIBS}
2004-01-28 Simon Budig <simon@gimp.org>
Argh, this is getting silly.
* app/core/gimpscanconvert.c: Fix dumb bug I introduced
while fixing bug #132036. Instead of always closing a
polyline to the first point of the vpath close to the
first point of the current polyline
I'll close#132036 for the third time now, feel free to
reopen it when bugs appear...
2004-01-27 Dave Neary <bolsh@gimp.org>
* plug-ins/common/tiff.c: Apply patch from Andrey Kiselev to
improve defaults when there is no photometric specified for
CCITT encoded tiffs. Closes bug #131902.
2004-01-27 Michael Natterer <mitch@gimp.org>
* app/gui/layers-commands.c (layers_add_mask_query): use the
new GIMP_STOCK_LAYER_MASK icon for "Add Layer Mask" dialog.
2004-01-27 Michael Natterer <mitch@gimp.org>
Re-enabled filling the whole selection using the bucket fill
tool. Fixes bug #132649.
* app/tools/gimpbucketfilloptions.[ch]: added boolean property
"fill-selection" and a GUI for it.
* app/tools/gimpbucketfilltool.c: changed accordingly.
2004-01-27 Michael Natterer <mitch@gimp.org>
* app/gui/image-menu.c (image_menu_entries)
* app/gui/layers-menu.c (layers_menu_entries): use the new
GIMP_STOCK_LAYER_MASK icons for "Add Layer Mask".
2004-01-27 Michael Natterer <mitch@gimp.org>
* themes/Default/images/Makefile.am
* themes/Default/images/stock-channel-indexed-16.png
* themes/Default/images/stock-channel-indexed-24.png
* themes/Default/images/stock-channel-indexed-32.png
* themes/Default/images/stock-channel-indexed-48.png
* libgimpwidgets/gimpstock.[ch]: added placeholders for an INDEXED
channel icon (copied from the GRAY channel icon). To be replaced...
* app/widgets/gimppreviewrendererimage.c: use
GIMP_STOCK_CHANNEL_INDEXED instead of GIMP_STOCK_QUESTION for the
indexed channel.
2004-01-27 Sven Neumann <sven@gimp.org>
* plug-ins/script-fu/scripts/comic-logo.scm: applied a patch from
Pedro Gimeno to make the logo behave more like it used to in 1.2
(bug #132493).
2004-01-27 Michael Natterer <mitch@gimp.org>
* app/display/gimpdisplayshell-title.c
(gimp_display_shell_format_title): added '%P' which expands to the
PDB id of the active drawable. Moved local variables to local
scopes where they are needed.
* app/config/gimpconfig-dump.c: document it.
2004-01-27 Michael Natterer <mitch@gimp.org>
* app/display/gimpdisplayshell-dnd.c: some cleanup.
(gimp_display_shell_bucket_fill): don't use the bucket fill
options but behave like "Edit -> Fill" and fill with NORMAL/100%.
Fixes bug #132596.
2004-01-26 Manish Singh <yosh@gimp.org>
* configure.in: add m4_defines for gimp_unstable and gimp_full_name,
and define a GIMP_VISIBLE_NAME based on that.
* data/misc/Makefile.am
* data/misc/gimp.applications.in
* data/misc/gimp.keys.in: made these configured files, so they can
use GIMP_APP_VERSION and GIMP_VISIBLE_NAME.
* data/misc/gimp.desktop.in.in: use GIMP_APP_VERSION and
GIMP_VISIBLE_NAME.
2004-01-27 Michael Natterer <mitch@gimp.org>
* themes/Default/images/Makefile.am
* themes/Default/images/stock-layer-mask-16.png
* themes/Default/images/stock-layer-mask-24.png
* themes/Default/images/stock-layer-mask-32.png
* themes/Default/images/stock-layer-mask-48.png
* themes/Default/images/stock-selection-border-16.png
* libgimpwidgets/gimpstock.[ch]: added forgotten layer mask and
new "border selection" icons from Jimmac (-32 and -48 ones to be
updated, they are currently copies of the channel icons).
* app/core/gimplayermask.c (gimp_layer_mask_class_init)
* app/gui/image-menu.c (image_menu_entries): use them.
2004-01-27 Sven Neumann <sven@gimp.org>
* plug-ins/gimpressionist/brush.c
* plug-ins/gimpressionist/gimp.c
* plug-ins/gimpressionist/gimpressionist.[ch]
* plug-ins/gimpressionist/paper.c
* plug-ins/gimpressionist/presets.c: fixed a crash (bug #132027),
got rid of some possible buffer overflows and fixed platform issues
like hardcoding '/' as the path separator.
2004-01-26 Michael Natterer <mitch@gimp.org>
* app/gui/image-menu.c (image_menu_entries): use
GIMP_STOCK_FLOATING_SELECTION for "Select->Float".
(image_menu_update): set "Layer->Merge Down" insensitive for the
bottom layer.
2004-01-26 Simon Budig <simon@gimp.org>
* app/core/gimpscanconvert.c: use the modern libart way
to uncross/rewind a libart SVP. This time really fixes
bug #132036 (please test it though...).
2004-01-26 Sven Neumann <sven@gimp.org>
* app/display/gimpdisplayshell-selection.c: don't draw the
outbounds selection when the selection is hidden (bug #132595).
2004-01-26 Sven Neumann <sven@gimp.org>
* app/text/gimptext-xlfd.c (gimp_text_font_size_from_xlfd):
account for the fact that XLFD stores point sizes in decipoints.
* app/text/gimptext-vectors.c: s/TEXT_DEBUG/GIMP_TEXT_DEBUG/
2004-01-26 Sven Neumann <sven@gimp.org>
* app/tools/gimpcurvestool.c
* app/widgets/gimphistogramview.c: use dark_gc instead of
text_aa_gc to draw the histogram and curves grid lines. dark_gc is
slightly lighter, looks better and fixes bug #132565.
2004-01-26 Michael Natterer <mitch@gimp.org>
* plug-ins/script-fu/scripts/unsharp-mask.scm: add the layer to
the image before pasting to it. Fixes bug #132504.
Fixed the underlying problem: make it impossible to attach
floating selections to drawables which are not currently part of
the image's layer or channel stacks.
Also cleaned up image <-> floating_sel interaction:
* app/core/gimplayer-floating-sel.[ch] (floating_sel_attach):
added assertion that the drawable is part of the image (see below).
Don't call gimp_image_floating_selection_changed(), it's emitted
by gimp_image_add_layer() now.
(floating_sel_remove)
(floating_sel_anchor): don't emit "floating_selection_changed",
it's emitted by gimp_image_remove_layer() now.
(floating_sel_anchor): removed the fix for bug #132162 because
gimp_image_remove_layer() behaves correctly now (see below).
Renamed floating_sel_reset() to floating_sel_activate_drawable().
Added g_return_if_fail() all over the place.
* app/core/gimpimage.[ch]: added new function gimp_image_owns_item()
which return TRUE if the passed item is part of the image.
(gimp_image_add_layer): emit "floating_selection_changed" here if
needed.
(gimp_image_remove_layer): emit "floating_selection_changed" if
needed, don't try to activate a layer if we called
floating_sel_activate_drawable().
This is the real fix for bug #132162.
* app/core/gimpimage-undo-push.c (undo_pop_layer): apply the same
fixes as to gimp_image_add,remove_layer(). Don't call
gimp_drawable_invalidate_preview() on the previously active layer
because that's done by gimp_image_set_active_layer() now.
* app/xcf/xcf-load.c: remember the "floating_sel_drawable" in the
XcfInfo struct and attach it *after* all layers and channels are
loaded to avoid attaching the floating selection to an
out-of-image drawable.
* app/core/gimp-edit.c (gimp_edit_paste)
* app/core/gimpdrawable-transform.c (gimp_drawable_transform_affine,
gimp_drawable_transform_flip, gimp_drawable_transform_rotate)
* app/core/gimpselection.c (gimp_selection_float)
* app/text/gimptext-compat.c (text_render): added checks for
gimp_image_owns_item() in all functions which can produce
floating selections.
* tools/pdbgen/pdb/edit.pdb
* tools/pdbgen/pdb/floating_sel.pdb
* tools/pdbgen/pdb/selection.pdb
* tools/pdbgen/pdb/text_tool.pdb
* tools/pdbgen/pdb/transform_tools.pdb: added checks for
gimp_item_owns_image() and return an execution error if invoked
with a drawable which is not part of the image.
* app/pdb/edit_cmds.c
* app/pdb/floating_sel_cmds.c
* app/pdb/selection_cmds.c
* app/pdb/text_tool_cmds.c
* app/pdb/transform_tools_cmds.c: regenerated.
2004-01-26 Michael Natterer <mitch@gimp.org>
* app/xcf/xcf-save.c (xcf_save_channel): store the correct offset
of the floating selection's drawable. This bug has been around
since 1.2 (!!!) and made it impossible to save images correctly
where the floating selection's drawable was a channel or layer
mask.
2004-01-26 Manish Singh <yosh@gimp.org>
* app/core/gimpdrawable-blend.c (gradient_fill_region): use memcpy
instead of casted assignment for storing HSV values in rbd.fg/bg,
for C99 aliasing compliance.
* app/xcf/xcf-load.c (xcf_load_layer_mask): use a GimpChannel *
explictly for xcf_load_channel_props, for the above reason.
* app/xcf/xcf-save.c (xcf_save_prop): use a temporary guint32 for
saving property types, for the above reason.
* app/core/gimpparasitelist.c (gimp_parasite_list_deserialize): plug
a memory leak, since data is copied on parasite creation.
Michael Natterer