If the passed dialog is a GimpColorProfileChooserDialog, handle its
"response" signal automatically and also destroy it when the combo box
is destroyed (before we leaked all dialogs). Remove the same callback
from all places using GimpColorProfileComboBox.
and improve gimp_color_profile_combo_box_set_active() to get the
profile's label from the ICC file if no label was provided. Simplifies
all its callers and removes code duplication.
which returns a string meant to label the profile in the GUI, it's
either the profile's description, its model, or "(unnamed profile)" as
a fallback. Use the function instead of duplicating that logic
inconsistently and imcompletely all over the place.
Add functions to get a profile's description, manufacturer, model and
copyright, and use them instead of implementing the same 10 times.
Also add a GimpColorProfile typedef which avoids both having to
include lcms globally or using a gpointer instead (which looks bad and
non-descriptive in an API).
So it works with all GObject versions, until we determine how useful
it is generally, and what API it should get for possible
libgimpwidgets inclusion.
Swallow GtkHSV back into GIMP and call it GimpColorWheel. Keep it in
modules/ for the time being. Clean up and undeprecate it. Replace
set_metrics() API by set_ring_fraction() and make it follow the size
of its parent container, making its use straightforward. Kept it clean
of GIMP color types so it can be easily adapted by e.g. Inkscape.
This symbol is not available to 64-bit applications. So put another
approach in place.
I can confirm that the code does not crash, but I do not know if it
works properly. Mitch forced me to push anyway.
Don't call gimp_input_device_store_lookup() with a NULL name. Unplug
seems broken because we always get name == NULL, I need to fix this
but at least it doesn't crash any longer (and the fix is generally
correct and not a workaround).
Create and use Cairo-compatible API for display filters. Also
includes logic changes to the display filters to deal with cairo's
ARGB32 pre-multiplied buffer format.
When a color gets set on the module via GimpColorSelector::set_color(),
make sure that the result of its transformation to CMYK doesn't
get set back on GIMP. Also, when the color profile changes, make
sure we only re-transform the RGB value to CMYK and don't set that
result back on GIMP either.
2009-03-22 Michael Natterer <mitch@gimp.org>
* modules/color-selector-wheel.c: remove GTK+ version check and
related evilness because we depend on a proper GKT+ version now.
svn path=/trunk/; revision=28195
2009-01-17 Michael Natterer <mitch@gimp.org>
* all files with a GPL header and all COPYING files:
Change licence to GPLv3 (and to LGPLv3 for libgimp).
Cleaned up some copyright headers and regenerated the parsers in
the ImageMap plugin.
svn path=/trunk/; revision=27913
2008-09-25 Michael Natterer <mitch@gimp.org>
Bug 553530 – fatal error: Segmentation fault - when attempting to
bring up color-picker:
* modules/color-selector-wheel.c: declare gtk_hsv_get_type() if
not already done by GTK+. Fixes confusion about its return value
being 32 or 64 bit on 64 bit machines.
svn path=/trunk/; revision=27054
2008-09-25 Michael Natterer <mitch@gimp.org>
Bug 549195 – Color Wheel not working (GtkHSV):
* modules/color-selector-wheel.c: change packing and size requests
of the GtkHSV and its optional GtkAligmnent depending on the GTK+
version used to make it work with both the old and the new version
of the widget. Evil hacks, better don't look :)
svn path=/trunk/; revision=27053
2008-09-03 Michael Natterer <mitch@gimp.org>
* app/display/gimpdisplayshell-callbacks.c
* libgimpwidgets/gimpcolorselect.c
* modules/color-selector-water.c
* plug-ins/ifs-compose/ifs-compose.c: instead of using
gdk_window_get_pointer() if GdkEventMotion::is_hint is TRUE,
simply always use the coords from the event and call
gdk_event_request_motions() to ask for more motion events. This is
the recommended way and also works for events from devices other
than the core pointer.
* plug-ins/ifs-compose/ifs-compose.c (design_area_motion): some
code cleanup while i was at it.
svn path=/trunk/; revision=26843
2008-08-12 Michael Natterer <mitch@gimp.org>
* modules/color-selector-wheel.c: override the wheel's
size-allocate and return a small requisition that allows to be
resized smaller again.
svn path=/trunk/; revision=26511
2008-08-11 Michael Natterer <mitch@gimp.org>
* modules/Makefile.am
* modules/*.c: renamed all modules to color-selector-foo.c,
display-filter-foo.c and controller-foo.c
svn path=/trunk/; revision=26506
2008-08-11 Michael Natterer <mitch@gimp.org>
* configure.in: check for lcms with PKG_CHECK_MODULES(). Remove
check for <lcms.h> vs. <lsmc/lsmc.h> because the pc file should
give us the right location now.
* modules/cdisplay_lcms.c
* modules/cdisplay_proof.c
* modules/colorsel_cmyk_lcms.c
* plug-ins/file-jpeg/jpeg-load.c
* plug-ins/common/lcms.c: #include <lcms.h> and nothing else.
* modules/Makefile.am
* plug-ins/file-jpeg/Makefile.am
* plug-ins/common/plugin-defs.pl: add LCMS_CFLAGS where appropriate.
* plug-ins/common/Makefile.am: regenerated.
svn path=/trunk/; revision=26503
2008-08-11 Michael Natterer <mitch@gimp.org>
* configure.in: change all LIBFOO variables to FOO_LIBS for
consistency, could get rid of some variables alltogether since
PNG_CHECK_MODULES() already defined FOO_LIBS.
* tools/Makefile.am
* modules/Makefile.am
* plug-ins/file-ico/Makefile.am
* plug-ins/file-jpeg/Makefile.am
* plug-ins/file-psd/Makefile.am
* plug-ins/file-xjt/Makefile.am
* plug-ins/common/plugin-defs.pl
* plug-ins/common/mkgen.pl: changed accordingly.
* plug-ins/common/Makefile.am: regenerated.
svn path=/trunk/; revision=26498
2008-08-08 Michael Natterer <mitch@gimp.org>
* modules/colorsel_triangle.c: removed.
* modules/colorsel_wheel.c: new module using the GtkHSV widget
which was originally developed from above triangle selector.
* modules/Makefile.am: chaged accordingly.
svn path=/trunk/; revision=26448
2008-06-12 Michael Natterer <mitch@gimp.org>
* modules/controller_midi.c: applied patch from S. Fielding which
passes the right MIDI channel from the ALSA event to midi_event().
Fixes bug #537960.
svn path=/trunk/; revision=25931
2008-01-13 Michael Natterer <mitch@gimp.org>
* modules/colorsel_cmyk_lcms.c (colorsel_cmyk_config_changed): set
a tooltip on the profile name label because it's often ellipsized.
svn path=/trunk/; revision=24606
2007-12-05 Sven Neumann <sven@gimp.org>
* modules/gimpinputdevicestore-dx.c
* modules/gimpinputdevicestore-hal.c: the code for !HAVE_LIBHAL
ended up in the wrong file.
svn path=/trunk/; revision=24267
2007-12-04 Sven Neumann <sven@gimp.org>
* modules/Makefile.am
* modules/gimpinputdevicestore.c: split into two new files:
* modules/gimpinputdevicestore-dx.c: DirectX Input
implementation
* modules/gimpinputdevicestore-hal.c: HAL implementation
svn path=/trunk/; revision=24259
2007-11-10 Michael Natterer <mitch@gimp.org>
* libgimpwidgets/gimppropwidgets.c: remove event boxes that were
only there for the old tooltips.
* modules/cdisplay_lcms.c: ditto. Also remove some code that was
only needed because of the event box hack.
svn path=/trunk/; revision=24110
2007-10-30 Michael Natterer <mitch@gimp.org>
* modules/cdisplay_lcms.c: applied patch from Sven Neumann and
Marianne Gagnon which adds support for getting the system monitor
profile on OS/X. Fixes bug #488170.
svn path=/trunk/; revision=23990
2007-10-18 Sven Neumann <sven@gimp.org>
* modules/cdisplay_lcms.c (cdisplay_lcms_get_display_profile):
introduced a utility function to retrieve the screen and
monitor.
svn path=/trunk/; revision=23878
2007-10-18 Sven Neumann <sven@gimp.org>
* modules/colorsel_cmyk_lcms.c: ellipsize the profile label. If
possible, use the profile description as we do in other places.
svn path=/trunk/; revision=23877
2007-10-05 Sven Neumann <sven@gimp.org>
* modules/cdisplay_lcms.c (cdisplay_lcms_get_display_profile):
corrected a mistake caused by a misinterpretation of the spec.
svn path=/trunk/; revision=23742
2007-10-05 Sven Neumann <sven@gimp.org>
* modules/cdisplay_lcms.c (cdisplay_lcms_get_display_profile):
support the new revision of the ICC Profiles In X specification
which handles Xinerama setups.
svn path=/trunk/; revision=23738
2007-10-05 Sven Neumann <sven@gimp.org>
* modules/colorsel_cmyk_lcms.c: always use the configured CMYK
profile, regardless of the color management mode.
svn path=/trunk/; revision=23731
2007-10-05 Sven Neumann <sven@gimp.org>
* libgimpconfig/gimpcolorconfig.[ch]: added settings for marking
out-of-gamut colors in the Print Simulation (bug #476824).
* app/dialogs/preferences-dialog.c: added a check-button for the
out-of-gamut warning and tweaked the layout of the Color Management
page to make the relationship of the settings more obvious.
* modules/cdisplay_lcms.c: mark out-of-gamut colors.
svn path=/trunk/; revision=23729
2007-10-04 Sven Neumann <sven@gimp.org>
* modules/colorsel_cmyk_lcms.c: use the
display rendering intent as set in the user's color management
preferences. Use black point compensation if the rendering intent
is relative colorimetric.
svn path=/trunk/; revision=23723
2007-10-03 Sven Neumann <sven@gimp.org>
* modules/cdisplay_lcms.c: use black point compensation if the
rendering intent is relative colorimetric.
svn path=/trunk/; revision=23720
2007-09-17 Sven Neumann <sven@gimp.org>
* modules/cdisplay_proof.c: use a GimpColorProfileComboBox for
profile selection.
svn path=/trunk/; revision=23571
2007-08-13 Sven Neumann <sven@gimp.org>
* modules/cdisplay_lcms.c: include glib.h before checking for
G_OS_WIN32. Also #define STRICT for strict type checks.
svn path=/trunk/; revision=23242
2007-08-13 Sven Neumann <sven@gimp.org>
* modules/Makefile.am (libcdisplay_lcms_la_LIBADD): link with
gdi32 on PLATFORM_WIN32.
* modules/cdisplay_lcms.c: changed include order to fix the
build
on MingW (see bug #78265).
svn path=/trunk/; revision=23229
2007-08-12 Sven Neumann <sven@gimp.org>
* modules/cdisplay_lcms.c (cdisplay_lcms_get_display_profile):
applied patch from Yoshinori Yamakawa that adds code to get the
monitor profile from Win32.
* app/dialogs/preferences-dialog.c: enabled the toggle for
"display-profile-from-gdk" on all systems.
svn path=/trunk/; revision=23222
2007-08-07 Sven Neumann <sven@gimp.org>
* app/plug-in/Makefile.am
* app/plug-in/plug-in-error.[ch]: new files defining the
GimpPlugIn error domain.
* app/plug-in/plug-in-icc-profile.c (plug_in_icc_profile_apply_rgb):
set an error code.
* app/file/file-open.c (file_open_profile_apply_rgb): only do the
profile conversion if color management is enabled. If the plug-in
is missing, show a warning and disable color management.
Fixes bug #434205.
* modules/cdisplay_lcms.c (cdisplay_lcms_get_rgb_profile): check
if we actually got a profile before checking its color space.
* libgimpwidgets/gimpwidgetstypes.h: removed leftover typedef
for GimpResolutionEntry.
svn path=/trunk/; revision=23130
2007-08-06 Sven Neumann <sven@gimp.org>
* libgimpwidgets/gimpcolordisplay.[ch]: added GimpColorConfig
and
GimpColorManaged as construct-only properties.
Deprecated gimp_color_display_new().
* libgimpwidgets/gimpwidgets.def: updated for new symbols.
* app/widgets/gimpcolordisplayeditor.c: use g_object_new()
instead
of gimp_color_display_new().
* modules/cdisplay_lcms.c: use the image's embedded color
profile
for the display filter. Assume sRGB if no monitor profile is
configured.
* app/display/gimpdisplayshell.c:
* app/display/gimpdisplayshell-filter.[ch]: pass the display as
color-managed object to the display filter.
svn path=/trunk/; revision=23127
2007-05-05 Simon Budig <simon@gimp.org>
* tools/pdbgen/pdb/edit.pdb: make gimp-edit-paste-as-new not fail
at an empty clipboard, but return -1 as image id.
* app/pdb/edit_cmds.c
* libgimp/gimpedit_pdb.c: regenerated.
* plug-ins/script-fu/scripts/paste-as-brush.scm
* plug-ins/script-fu/scripts/paste-as-pattern.scm: Changed
accordingly, fixes bug #357059.
* modules/controller_linux_input.c: changed some axis names to
make more sense.
svn path=/trunk/; revision=22429
2007-02-21 Tor Lillqvist <tml@novell.com>
* modules/Makefile.am: It's pointless to build
libcontroller_midi.la on Windows, even if it happens to compile
and build. There are no MIDI "device files" on Windows. A totally
specific MIDI API would have to be used.
svn path=/trunk/; revision=21968
2007-02-20 Tor Lillqvist <tml@novell.com>
* modules/controller_dx_dinput.c: New file. Low level
GimpController support for DirectInput controllers on Win32.
* modules/gimpinputdevicestore.c: Add implementation for
DirectInput devices.
* modules/Makefile.am: Add libcontroller_dx_dinput.la with above
source files.
svn path=/trunk/; revision=21962
2007-02-19 Manish Singh <yosh@gimp.org>
* modules/gimpinputdevicestore.c: gimp_input_device_store_type
should be set to G_TYPE_NONE in the !HAVE_LIBHAL case.
* modules/controller_linux_input.c: we can't use
GIMP_TYPE_INPUT_DEVICE_STORE in the !HAVE_LIBHAL case.
svn path=/trunk/; revision=21954
2007-02-19 Michael Natterer <mitch@gimp.org>
* modules/gimpinputdevicestore.c: define gimp_input_device_store_type
also for the !HAVE_LIBHAL case.
svn path=/trunk/; revision=21953
2007-02-13 Raphael Quinet <raphael@gimp.org>
* modules/gimpinputdevicestore.c (gimp_input_device_store_new):
fix function prototype for when libhal is not available.
svn path=/trunk/; revision=21914
2007-02-13 Michael Natterer <mitch@gimp.org>
* modules/gimpinputdevicestore.[ch]: made dynamically loadable
using GTypeModule.
* modules/controller_linux_input.c (gimp_module_register):
register the new dynamic type.
svn path=/trunk/; revision=21909
2007-02-12 Sven Neumann <sven@gimp.org>
* libgimpwidgets/gimpstringcombobox.c: fixed some issues with the
new widget.
* modules/controller_linux_input.c: define a property for the
device store and use the device file as provided by the store.
* modules/gimpinputdevicestore.c: removed debug output.
svn path=/trunk/; revision=21902
2007-02-12 Sven Neumann <sven@gimp.org>
* libgimpwidgets/Makefile.am
* libgimpwidgets/gimpwidgetstypes.h
* libgimpwidgets/gimpwidgets.h
* libgimpwidgets/gimpstringcombobox.[ch]: added GimpStringComboBox.
* libgimpwidgets/gimppropwidgets.[ch]: added a prop widget
constructor that uses the new widget.
* libgimpwidgets/gimpwidgets.def: updated.
* app/widgets/gimpcontrollereditor.c: use a GimpStringComboBox if
the module specifies a tree model with string values.
* modules/gimpinputdevicestore.c: minor cleanup.
* modules/controller_linux_input.c: keep a pointer to the input
device store and unref it in the finalizer.
svn path=/trunk/; revision=21900
2007-02-12 Sven Neumann <sven@gimp.org>
* modules/cdisplay_colorblind.c: set translation domain for the
registered enum type.
svn path=/trunk/; revision=21895
2007-02-12 Sven Neumann <sven@gimp.org>
* configure.in: lower minimum required version of libhal to
0.5.7.
* modules/gimpinputdevicestore.c: don't list PC Speaker, even
though the kernel claims that it would be an input device.
svn path=/trunk/; revision=21894
2007-02-11 Sven Neumann <sven@gimp.org>
* modules/gimpinputdevicestore.c: don't limit the store to
"input.mouse", list all input devices.
svn path=/trunk/; revision=21892
2007-02-11 Sven Neumann <sven@gimp.org>
* configure.in: check for libhal if Linux Input support is
enabled.
* modules/Makefile.am
* modules/gimpinputdevicestore.[ch]: added class derived from
GtkListStore that keeps a list of devices with capability
"input.mouse".
* modules/controller_linux_input.c: for now, just instantiate a
GimpInputDeviceStore.
svn path=/trunk/; revision=21891
2007-02-10 Michael Natterer <mitch@gimp.org>
* modules/controller_linux_input.c: added some code stolen from
DirectFB and forgotten on my disk a long time ago which queries
the input device for available keys and axes (just for debugging
purposes for now). Also add one more button event and some
debugging output for incoming events.
svn path=/trunk/; revision=21887
2007-02-09 Michael Natterer <mitch@gimp.org>
* modules/controller_linux_input.c (linux_input_read_event): fix
last commit a bit...
svn path=/trunk/; revision=21886
2007-02-09 Michael Natterer <mitch@gimp.org>
* modules/controller_linux_input.c (linux_input_read_event): emit
GIMP_CONTROLLER_EVENT_VALUE, not TRIGGER for movements on relative
axes. Reduces the number of events significantly. Now we can start
thinking what to do with them...
svn path=/trunk/; revision=21885
2007-01-21 Michael Natterer <mitch@gimp.org>
* modules/controller_midi.c (midi_set_device): set the name
of the alsa client to "GIMP" and the name of the port to
"GIMP MIDI Input Controller". Provides reasonable strings in
apps which display "client::port" as well as in apps which
display only "port".
svn path=/trunk/; revision=21747
2007-01-10 Simon Budig <simon@gimp.org>
* modules/controller_linux_input.c: fix the directions of the
relative events.
* plug-ins/common/normalize.c: fix warning about comment starting
inside a comment. Untabbified.
svn path=/trunk/; revision=21683
2007-01-02 Sven Neumann <sven@gimp.org>
* modules/cdisplay_lcms.c: fixed order of parameters (pointed
out
by Yoshinori Yamakawa).
svn path=/trunk/; revision=21624
2006-12-10 Sven Neumann <sven@gimp.org>
* modules/controller_midi.c (midi_set_device): use
g_get_application_name() for the client name; made the name of
the
ALSA port translatable.
Michael Henning