Commit Graph

8701 Commits

Author SHA1 Message Date
Michael Natterer 8e2e464f67 converted tabs to spaces, cleanup, reviewed new API docs.
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpitem.c: converted tabs to spaces, cleanup,
	reviewed new API docs.
2004-07-14 11:52:03 +00:00
Sven Neumann 00fed8dcba applied a patch done by Brion Vibber and Philip Lafleur that fixes loading
2004-07-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/tiff.c: applied a patch done by Brion Vibber
	and Philip Lafleur that fixes loading of CMYK TIFF images on
	big-endian hardware (bug #147328).
2004-07-14 10:57:13 +00:00
Philip Lafleur cf6ae91996 Properly check the return value of find_unused_ia_color(). The plugin will
2004-07-14  Philip Lafleur  <plafleur@cvs.gnome.org>

	* plug-ins/common/mng.c (respin_cmap): Properly check the return
	value of find_unused_ia_color(). The plugin will now save indexed
	MNGs correctly; fixes bug #139947. Also converted tabs to spaces.
2004-07-14 10:55:31 +00:00
Michael Natterer fe9d9be66b Code review & cleanup:
2004-07-14  Michael Natterer  <mitch@gimp.org>

	Code review & cleanup:

	* app/config/gimpguiconfig.[ch]: removed transparency-size,
	transparency-type and snap-distance properties...

	* app/config/gimpdisplayconfig.[ch]: ...and added them here.

	* app/display/gimpdisplayshell.c
	* app/tools/gimpmovetool.c: changed accordingly.

	* app/core/gimpimage-scale.[ch] (gimp_layer_scale_check): added a
	"max_memsize" parameter instead of looking it up in GimpGuiConfig.

	* app/actions/image-commands.c: changed accordingly.

	* app/core/gimparea.c
	* app/core/gimpdrawable.c: converted tabs to spaces, cleanup.

	* app/core/gimpprojection.[ch]: renamed IdleRenderStruct to
	GimpProjectionIdleRender, reordered functions, cleanup.

	* app/display/gimpdisplay-handlers.c
	* app/display/gimpdisplay.c: removed unused #includes.

	* app/display/gimpdisplayshell.[ch]
	* app/display/gimpdisplayshell-close.c: renamed
	shell->warning_dialog to shell->close_dialog, some random
	cleanups.

	* app/display/gimpdisplayshell-handlers.c
	* app/widgets/gimpselectioneditor.c: minor coding style cleanup.
2004-07-14 10:31:59 +00:00
William Skaggs 53249872f6 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/core/gimpitem.c: added documentation comments to some
	of the functions.
2004-07-14 00:32:09 +00:00
Michael Natterer 2226ddf7e4 app/display/Makefile.am new files for gimp_display_shell_close() and its
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/display/Makefile.am
	* app/display/gimpdisplayshell-close.[ch]: new files for
	gimp_display_shell_close() and its dialog & callback.

	* app/display/gimpdisplayshell.[ch]: removed from here.

	* app/actions/view-actions.c (view_close_view_cmd_callback):
	changed accordingly.
2004-07-14 00:15:57 +00:00
Sven Neumann 2f16b5f824 code cleanup. Use enums instead of a plethora of booleans. Added some
2004-07-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/pagecurl/pagecurl.c: code cleanup. Use enums instead of
	a plethora of booleans. Added some macros for readability. Allow
	to use a reversed gradient for colorizing the curl.
2004-07-13 23:05:11 +00:00
Michael Natterer 54cc251b08 app/core/Makefile.am app/core/core-types.h new interface which has
2004-07-14  Michael Natterer  <mitch@gimp.org>

	* app/core/Makefile.am
	* app/core/core-types.h
	* app/core/gimppickable.[ch]: new interface which has
	get_image_type(), get_tiles() and get_color_at() methods.

	* app/core/gimpdrawable.[ch]
	* app/core/gimpimagemap.[ch]
	* app/core/gimpprojection.[ch]: implement GimpPickableInterface
	and removed public get_colot_at() functions.

	* app/core/gimpimage-pick-color.[ch]: removed typedef
	GimpImagePickColorFunc and gimp_image_pick_color_by_func(). Use
	gimp_pickable_pick_color() instead.

	* app/core/gimpimage-contiguous-region.c
	* app/core/gimpimage-crop.c
	* app/gui/info-window.c
	* app/paint/gimpconvolve.c
	* app/paint/gimpsmudge.c
	* app/tools/gimpbycolorselecttool.c
	* app/tools/gimpimagemaptool.c
	* app/widgets/gimpselectioneditor.c: use GimpPickable functions
	instead of the various get_color_at() functions. Simplifies code
	which has a "sample_merged" boolean. Various cleanups.
2004-07-13 23:04:05 +00:00
Shlomi Fish 0c3377bce8 plug-ins/gimpressionist/presets.c: Added underscores between
words in function names according to the GIMP's (and common
sense) convention.
2004-07-13 21:55:35 +00:00
Shlomi Fish 8252d3887d Moved the global declarations of img_has_alpha and create_colorpage to
* plug-ins/gimpressionist/: Moved the global declarations of
img_has_alpha and create_colorpage to more specialized headers.
2004-07-13 20:58:02 +00:00
Shlomi Fish 3aa90e2818 Added the paper.h header for the functions defined in the paper.c module.
* plug-ins/gimpressionist/: Added the paper.h header for the functions
defined in the paper.c module. (thus removing more declarations
from gimpressionist.h)
2004-07-13 19:38:59 +00:00
William Skaggs 784dde6482 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* plug-ins/gfig/gfig-dialog.c
	* plug-ins/gfig/gfig-preview.[ch}
	* plug-ins/gfig/gfig.h: Made Cancel work properly.  Moved "show grid",
	"snap to grid", and "show image" checkbuttons back onto main
	interface.  Eliminated GtkPreview and removed undef of
	GTK_DISABLE_DEPRECATED from gfig-preview.c.  Removed some
	unused code.
2004-07-13 18:47:53 +00:00
Sven Neumann 93d329db4c use gtk_widget_queue_draw_area() instead of the deprecated
2004-07-13  Sven Neumann  <sven@gimp.org>

	* plug-ins/gflare/gflare.c (preview_handle_idle): use
	gtk_widget_queue_draw_area() instead of the deprecated
	gtk_widget_draw() routine.

	* plug-ins/gimpressionist/orientmap.c
	* plug-ins/gimpressionist/paper.c
	* plug-ins/gimpressionist/sizemap.c: use gtk_widget_queue_draw()
	instead of the deprecated gtk_widget_draw() routine.
2004-07-13 17:29:15 +00:00
Shlomi Fish ce4319caa2 plug-ins/gimpressionist/preview.c Eliminated two compile-time warnings.
* plug-ins/gimpressionist/preview.c
* plug-ins/gimpressionist/sizemap.c:
Eliminated two compile-time warnings.
2004-07-13 17:11:08 +00:00
Michael Natterer c5ec0d4f70 *** empty log message *** 2004-07-13 16:36:29 +00:00
Sven Neumann 28cbe15ed7 declared GimpPixmap as deprecated.
2004-07-13  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppixmap.[ch]: declared GimpPixmap as deprecated.

	* libgimpwidgets/gimpwidgets.[ch]: ditto for gimp_pixmap_button_new().

	* plug-ins/Lighting/ChangeLog: removed outdated and unused ChangeLog.

	* plug-ins/Lighting/Makefile.am
	* plug-ins/Lighting/*.xpm: removed XPM files...

	* configure.in
	* plug-ins/Lighting/images: ... and added them as PNG images here.
	These should be redone with antialiased edges.

	* plug-ins/Lighting/lighting_stock.[ch]
	* plug-ins/Lighting/lighting_ui.c: register stock icons and use
	those instead of GimpPixmaps.

	* plug-ins/MapObject/Makefile.am
	* plug-ins/MapObject/*.xpm: removed duplicated XPM files.

	* plug-ins/MapObject/mapobject_stock.[ch]: register stock icons
	reusing the generated header from the Lighting plug-in.

	* plug-ins/MapObject/mapobject_ui.c: use them.

	* plug-ins/pagecurl/pagecurl.c: undef GIMP_DISABLE_DEPRECATED until
	GimpPixmap has been replaced here as well.
2004-07-13 15:59:52 +00:00
Shlomi Fish 00645d1018 fixed Bug # 147483 (gimpressionist will delete global presets if the user
* plug-ins/gimpressionist/presets.c: fixed Bug # 147483 (gimpressionist
will delete global presets if the user running GIMP has priviliges to
do so ). This was done by creating a function to check if a preset is
global, and by making sure the delete button is in-sensitive when this
is the case.
2004-07-13 15:10:46 +00:00
Sven Neumann 45a7f5e459 libgimpwidgets/gimpcolorbutton.c libgimpwidgets/gimpcolornotebook.c
2004-07-13  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpcolorbutton.c
	* libgimpwidgets/gimpcolornotebook.c
	* libgimpwidgets/gimpcolorscale.c
	* libgimpwidgets/gimpcolorscales.c
	* libgimpwidgets/gimpcolorselect.c
	* libgimpwidgets/gimpcolorselection.c
	* libgimpwidgets/gimpframe.c
	* libgimpwidgets/gimppickbutton.c
	* libgimpwidgets/gimpunitmenu.c: some code review and cosmetics.
2004-07-13 14:55:16 +00:00
Shlomi Fish 6d3d212973 normalized some of brush.c's identifiers (= variable names and function
* plug-ins/gimpressionist/*.[ch]: normalized some of brush.c's
identifiers (= variable names and function name)
2004-07-13 13:27:47 +00:00
Sven Neumann 6e77b577dc handle NULL string values.
2004-07-13  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-utils.c (gimp_g_value_get_memsize): handle NULL
	string values.
2004-07-13 11:54:09 +00:00
Sven Neumann c7f25d0c81 override the output_message error handler in order to propagate warnings
2004-07-13  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/jpeg.c: override the output_message error
	handler in order to propagate warnings to the user interface
	(related to bug #145212).
2004-07-13 11:14:05 +00:00
Sven Neumann f274dce25b added new function gimp_g_value_get_memsize() that attempts to calculate
2004-07-13  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-utils.[ch]: added new function
	gimp_g_value_get_memsize() that attempts to calculate the memory
	requirements for a GValue.

	* app/text/gimptextundo.c (gimp_text_undo_get_memsize): use the
	new function to obtain a better estimate for the size of the text
	undo.
2004-07-13 10:09:22 +00:00
Sven Neumann 11795e78f4 plugged a tiny memory leak.
2004-07-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptexttool.c (gimp_text_tool_create_layer): plugged
	a tiny memory leak.
2004-07-13 08:59:10 +00:00
Sven Neumann 5cff101603 resurrected some bit-rotting debug code. Might become useful one day.
2004-07-13  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-undo.c: resurrected some bit-rotting debug
	code. Might become useful one day.
2004-07-13 08:30:22 +00:00
Sven Neumann 3aff97c3aa when automake 1.8 is being used, require at least version 1.8.3. Earlier
2004-07-13  Sven Neumann  <sven@gimp.org>

	* autogen.sh: when automake 1.8 is being used, require at least
	version 1.8.3. Earlier versions of the automake-1.8 series don't
	handle gimp-console correctly.
2004-07-12 23:51:38 +00:00
Michael Natterer 1175a64b3f app/config/gimpconfig-dump.c applied patch from Dave Neary which adds %B
2004-07-13  Michael Natterer  <mitch@gimp.org>

	* app/config/gimpconfig-dump.c
	* app/display/gimpdisplayshell-title.c
	(gimp_display_shell_format_title): applied patch from Dave Neary
	which adds %B which expands to (modified) if the image is
	dirty. Also added %A which expands to (clean) because we also have
	a short indicator for the clean image. Fixes bug #130943.
2004-07-12 23:36:45 +00:00
Sven Neumann 1e7a0f341d removed hack for gimp-console compilation. automake seems to handle it
2004-07-13  Sven Neumann  <sven@gimp.org>

	* app/Makefile.am: removed hack for gimp-console compilation.
	automake seems to handle it correctly all by itself.
2004-07-12 22:34:37 +00:00
Michael Schumacher d2b7bdc735 added #ifdef G_OS_WIN32 #include <windows.h> #endif
2004-07-12  Michael Schumacher <schumaml@cvs.gnome.org>

	* app/app_procs.c: added
	#ifdef G_OS_WIN32
	#include <windows.h>
	#endif
2004-07-12 21:32:29 +00:00
Michael Natterer d41e45b1f4 added a preview of the global buffer.
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpbufferview.[ch]: added a preview of the global
	buffer.
2004-07-12 20:25:05 +00:00
Sven Neumann 8deb11ddf2 make sure that gimp-console is enabled for 'make dist'. Use it to dump the
2004-07-12  Sven Neumann  <sven@gimp.org>

	* app/Makefile.am: make sure that gimp-console is enabled for
	'make dist'. Use it to dump the system gimprc and gimprc man-page.
2004-07-12 17:14:02 +00:00
Michael Natterer a81e96450a removed member "guint time"...
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* app/text/gimptextundo.[ch]: removed member "guint time"...

	* app/core/gimpundo.[ch]: ...and added it here.

	* app/tools/gimptexttool.c (gimp_text_tool_apply): changed
	accordingly. Reordered undo compression code to look like other
	pieces of code which do undo compression.
2004-07-12 17:10:34 +00:00
Michael Natterer da74f1269e app/core/gimpundo.[ch] app/core/gimpitemundo.[ch] removed all _new()
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpundo.[ch]
	* app/core/gimpitemundo.[ch]
	* app/text/gimptextundo.[ch]: removed all _new() functions and
	added properties and GObject::constructor() implementations
	instead.

	* app/core/gimpimage-undo.[ch] (gimp_image_undo_push): added
	"GType undo_gtype" parameter and allow to pass name-value pairs as
	"...". Une the new GParameter utility functions to construct the
	appropriate undo step with g_object_newv().

	(gimp_image_undo_push_item): removed.

	(gimp_image_undo_push_undo): removed. Merged its code back into
	gimp_image_undo_push(), where it originally came from.

	* app/core/gimpimage-undo-push.c
	* app/core/gimpundostack.c
	* app/paint/gimppaintcore-undo.c
	* app/tools/gimptransformtool-undo.c
	* app/widgets/gimpundoeditor.c: changed accordingly.
2004-07-12 16:59:36 +00:00
Sven Neumann 9593e52ef2 plug-ins/gfig/gfig-dialog.c plug-ins/gfig/gfig-preview.c
2004-07-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/gfig/gfig-dialog.c
	* plug-ins/gfig/gfig-preview.c
	* plug-ins/gfig/gfig-style.c
	* plug-ins/gfig/gfig.c: some include cleanups. Use
	libgimpbase/gimpwin32-io.h instead of defining W_OK explicitely.
	Don't undef GTK_DISABLE_DEPRECATED except for gfig-preview.c.
2004-07-12 16:57:29 +00:00
Michael Natterer bfed40e9da applied patch from Dave Neary that changes the behavior from undo
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* plug-ins/script-fu/scripts/round-corners.scm: applied patch from
	Dave Neary that changes the behavior from undo disable/enable to
	using an undo group if the script doesn't work on a copy of the
	image. Fixes bug #146344.
2004-07-12 16:14:22 +00:00
Michael Natterer 5e25cdd239 applied patch from Brion Vibber which adds <Toolbox>/Acquire/Paste as new.
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* menus/toolbox-menu.xml.in: applied patch from Brion Vibber
	which adds <Toolbox>/Acquire/Paste as new. Fixes bug #147358.
2004-07-12 16:09:01 +00:00
Sven Neumann cbe7552189 NEWS update, fixed UTF-8 in ChangeLog 2004-07-12 15:30:45 +00:00
Michael Natterer ca5026a51f don't do anything if gimp->no_interface is TRUE.
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* app/core/gimp-modules.c: don't do anything if gimp->no_interface
	is TRUE.
2004-07-12 14:43:24 +00:00
Michael Natterer 84c29b4861 Made the gimp-console binary compile. Finishes core/GUI separation and
2004-07-12  Michael Natterer  <mitch@gimp.org>

	Made the gimp-console binary compile.
	Finishes core/GUI separation and fixes bug #71514:

	* configure.in: removed the crazy-hacker warning for
	--enable-gimp-console.

	* app/Makefile.am: for gimp-console, copy app_procs.c to
	app_procs_console.c and compile it instead of app_procs.c with
	-DGIMP_CONSOLE_COMPILATION

	* app/app_procs.[ch]: added some #ifndef GIMP_CONSOLE_COMPILATION
	to skip GUI stuff for the gimp-console case.
	Renamed app_gui_libs_init() to app_libs_init(), renamed
	app_gui_abort() to app_abort() and added app_exit() so everything
	that needs #ifdefs lives here now.

	* app/main.c: changed accordingly.

	* app/gui/gui.c (gui_abort): really abort (call exit()).
2004-07-12 14:32:31 +00:00
Sven Neumann 58a91da574 made the suggestion to use binary packages more prominent, mention
2004-07-12  Sven Neumann  <sven@gimp.org>

	* INSTALL: made the suggestion to use binary packages more
	prominent, mention --enable-gimp-console.
2004-07-12 14:09:33 +00:00
Sven Neumann 1abeb90523 removed the gtk+ sanity check here ...
2004-07-12  Sven Neumann  <sven@gimp.org>

	* app/sanity.[ch]: removed the gtk+ sanity check here ...

	* app/gui/gui.c: ... and do it here from gui_libs_init().

	* app/main.c: changed accordingly.
2004-07-12 13:22:28 +00:00
Sven Neumann 3b553547db don't use gtk_main() / gtk_main_quit() but run our own main-loop like we
2004-07-12  Sven Neumann  <sven@gimp.org>

	* app/app_procs.s: don't use gtk_main() / gtk_main_quit() but run
	our own main-loop like we already used to do when being run
	non-interactively.
2004-07-12 12:56:35 +00:00
Michael Natterer 5b83b759d7 set/unset the busy cursor on all windows which have widget->window, not
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdialogfactory.c
	(gimp_dialog_factories_set_busy_foreach)
	(gimp_dialog_factories_unset_busy_foreach): set/unset the busy
	cursor on all windows which have widget->window, not only for
	those which are GTK_WIDGET_VISIBLE. Fixes stale busy cursors when
	dialogs are hidden while the busy cursor is active and later shown
	again.
2004-07-12 11:47:54 +00:00
Michael Natterer 87c1722700 added an "id" CONSTRUCT_ONLY property. Some minor cleanup.
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplay.c: added an "id" CONSTRUCT_ONLY
	property. Some minor cleanup.
2004-07-12 11:43:00 +00:00
Michael Natterer 509a6c57c5 app/core/Makefile.am new files defining a GimpGui vtable struct and
2004-07-12  Michael Natterer  <mitch@gimp.org>

	* app/core/Makefile.am
	* app/core/gimp-gui.[ch]: new files defining a GimpGui vtable
	struct and contianing all the vtable wrapper functions. Reordered
	and renamed some functions for consistency.

	* app/core/gimp.[ch]: removed all the vtable code.

	* app/gui/gui-vtable.c: changed accordingly.
2004-07-12 11:41:19 +00:00
Sven Neumann ce09783780 changelog cosmetics 2004-07-12 11:28:16 +00:00
Sven Neumann 95e7d5ee0a removed images from the container when they become clean. Should move to
2004-07-12  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplay-foreach.c
	(gimp_displays_get_dirty_images): removed images from the
	container when they become clean. Should move to the Gimp object.

	* app/gui/quit-dialog.c: some cosmetic changes.
2004-07-12 11:12:19 +00:00
Sven Neumann a4cdae89b1 applied a patch from Brion Vibber that sets the 'Save color values from
2004-07-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/tiff.c: applied a patch from Brion Vibber that
	sets the 'Save color values from transparent pixels' insensitive
	when there's no alpha channel.
2004-07-12 07:41:23 +00:00
Hans Breuer b56eb39ead updated app/actions/makefile.msc app/menus/makefile.msc : (new files)
2004-07-11  Hans Breuer  <hans@breuer.org>

	* **/makefile.msc : updated
	  app/actions/makefile.msc app/menus/makefile.msc : (new files)
	  app/actions/Makefile.msc app/menus/Makefile.am : added to EXTRA_DIST

	* libgimpbase/gimputils.c libgimpwidgets/gimpmemsizeentry.c
	  app/widgets/gimppropwidgets.c : bumped compiler version check,
	msvc6 still can't cast from unsigned __int64 to double

	* app/actions/debug-actions.c : only use debug_*_callback
	and thus debug_action if ENABLE_DEBUG_MENU

	* app/core/gimpalette-import.c : added gimpwin32-io.h

	* plug-ins/common/convmatrix.c : s/snprintf/g_snprintf/

	* plug-ins/common/screenshot.c : make it compile with msvc,
	but still no win32 specific implementation ...
2004-07-11 21:53:17 +00:00
William Skaggs 5d0d0c2eb8 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* plug-ins/gfig/gfig-dobject.h: fix commit error that
	broke build.
2004-07-11 19:39:05 +00:00
William Skaggs 08319b790e Bill Skaggs <weskaggs@primate.ucdavis.edu>
* plug-ins/gfig/gfig-dialog.c
	* plug-ins/gfig/gfig-dobject.[ch]
	* plug-ins/gfig/gfig.c: added buttons to select an object, and
	raise or lower the selected object; also a few minor cleanups.
2004-07-11 18:39:30 +00:00