2002-08-26 Michael Natterer <mitch@gimp.org>
Color correction tool chopping:
* app/Makefile.am
* app/image_map.[ch]: removed...
* app/core/Makefile.am
* app/core/core-types.h
* app/core/gimpimagemap.[ch]: ...and added here as object.
* app/base/Makefile.am
* app/base/base-types.h
* app/base/color-balance.[ch]
* app/base/curves.[ch]
* app/base/hue-saturation.[ch]
* app/base/threshold.[ch]: the lowlevel color correction functions
plus their parameter structs cut out of the resp. tools.
* app/core/core-enums.[ch]: removed GimpTransferMode enum...
* app/base/base-enums.[ch]: ...added it here. Also added
GimpHueRange for the new hue-saturation files.
* tools/pdbgen/enums.pl
* libgimp/gimpenums.h
* plug-ins/script-fu/script-fu-constants.c: regenerated.
* app/tools/Makefile.am
* app/tools/gimpcolorbalancetool-transfer.c: removed (code went
to base/color-balance.c).
* app/tools/gimpimagemaptool.[ch]: added most code which was
diplicated in subclasses. Create the dialog here with a nice title
bar including image preview and name (fixes#66033). Added virtual
functions map(), dialog() and reset() which need to be implemented
by subclasses.
* app/tools/gimpbrightnesscontrasttool.[ch]
* app/tools/gimpcolorbalancetool.[ch]
* app/tools/gimpcurvestool.[ch]
* app/tools/gimphuesaturationtool.[ch]
* app/tools/gimplevelstool.[ch]
* app/tools/gimpposterizetool.[ch]
* app/tools/gimpthresholdtool.[ch]: removed tons of duplicated
code and simply implement GimpImageMapTool's virtual functions.
Removed all dialog structs and keep the variables in the tool
structs. The dialogs are now created on-the-fly and destroyed when
the tool goes away, which makes all callbacks much simpler and
safer. Lots of GUI & code cleanup in all dialogs.
* app/tools/gimpcurvestool.c
* app/tools/gimplevelstool.c: added separate "Reset Channel"
buttons and let the global "Reset" buttons reset all color
channels.
* app/tools/tools.c: the various antique foo_free() functions
don't exist any more.
* app/tools/gimphistogramtool.c: removed ImageMap field from
dialog struct (it was unused). Cleaned up dialog a bit.
* tools/pdbgen/Makefile.am: don't scan tools/gimphuesaturationtool.h
for enums.
* tools/pdbgen/pdb/color.pdb: use the new stuff from base/ and
don't include stuff from tools/ any more.
* app/pdb/color_cmds.c
* app/pdb/paint_tools_cmds.c: regenerated.
2002-08-22 Michael Natterer <mitch@gimp.org>
* themes/Default/images/stock-all-16.png
* themes/Default/images/stock-none-16.png
* themes/Default/images/stock-grow-16.png
* themes/Default/images/stock-shrink-16.png: new icons from Jimmac.
* themes/Default/images/Makefile.am
* themes/Default/imagerc
* libgimpwidgets/gimpstock.[ch]: added them to the stock system.
* app/gui/menus.c: use them.
* app/widgets/gimpselectioneditor.[ch]: use the icons and added
a "Save to Channel" button.
2002-08-22 Sven Neumann <sven@gimp.org>
* tools/pdbgen/pdb/gimprc.pdb
* app/pdb/gimprc_cmds.c (gimprc_query_invoker): don't leak the
result of gimprc_value_to_str().
* app/core/gimpdrawable-preview.c (gimp_drawable_preview_scale):
use g_new0() instead of g_new() followed by memset().
* plug-ins/script-fu/script-fu-server.c (server_log): free the
string after logging it.
2002-08-22 Michael Natterer <mitch@gimp.org>
* app/paint/paint.c: unref the paint info objects after adding
them to their container.
* app/widgets/toolbox.c: free the tooltip string after setting it.
* app/gui/session.c: spit out the correct warning if (position x y)
could not be parsed.
2002-08-22 Michael Natterer <mitch@gimp.org>
* configure.in: bumped version number to 1.3.9
* app/tools/gimpbycolorselecttool.[ch]: removed the ByColorDialog
and cleaned up the code.
* app/widgets/Makefile.am
* app/widgets/widgets-types.h
* app/widgets/gimpselectioneditor.[ch]: added new widget
GimpSelectionEditor with same same functionality as the old
ByColorDialog which can be open all the time (independent of the
active tool).
* app/widgets/gimppreview.[ch]: added gimp_preview_new_by_type()
so previews can be created without a viewable.
* app/widgets/gimppreview-utils.[ch]: changed
gimp_preview_type_from_viewable() to
gimp_preview_type_from_viewable_type().
* app/gui/dialogs-constructors.[ch]
* app/gui/dialogs.c
* app/gui/menus.c: register the new dialog type.
2002-08-22 Michael Natterer <mitch@gimp.org>
* app/undo.c: compress emissions of "mask_changed" and
"qmask_changed" across undo groups.
* app/core/gimpimage-mask.c: set GIMP_DRAWABLE(mask)->preview_valid
to FALSE in gimp_image_mask_invalidate(), not in
gimp_image_mask_push_undo(). Fixes selection preview rendering
after a mask undo.
2002-08-22 Michael Natterer <mitch@gimp.org>
* app/display/gimpdisplayshell-render.c: allocate all temporary
render bufs and check bufs large enough for GIMP_PREVIEW_MAX_SIZE
(which is 1024). Fixes crashes with too large navigation previews.
2002-08-22 Michael Natterer <mitch@gimp.org>
Fixed usage of uninitialized memory found by valgrind,
plus some cleanup:
* app/base/pixel-region.[ch]: allocate PixelRegionIterators and
PixelRegionHolders with g_new0(). Changed return values of
pixel_regions_register() and pixel_regions_process() from gpointer
to PixelRegionIterator*
* app/base/pixel-processor.c: no need to cast the above return values.
* app/base/temp-buf.[ch]: initialize PixelRegions with { 0 }
before using them for TempBufs.
* app/gui/device-status-dialog.c: initialize colors before
passing them to gimp_color_area_new().
2002-08-20 Michael Natterer <mitch@gimp.org>
Make sure the selection (gimpimage-mask.c) functionality is really
built *on top* of the GimpChannel functionality:
* app/undo.[ch]: renamed undo_push_image_mask() to
undo_push_mask() and generalized it's API to take a GimpChannel
param so undos can be pushed for channels which are not the
image's selection. Simplified the API and added code which copies
the region of interest instead of leaving this to callers.
* app/undo_types.h: s/IMAGE_MASK_UNDO/MASK_UNDO/
* app/undo_history.c: changed accordingly.
* app/core/gimpchannel.[ch]: don't #include "gimpimage-mask.h".
Changed gimp_channel_push_undo() to really push a channel undo,
not a selection undo. Added "gboolean push_undo" params to all
functions which are called from gimpimage-mask.c. Various cleanups
and optimizations. Added /*< proxy-foo >*/ stuff to the header so
we export just the struct itself to libgimpproxy. Added accessors
gimp_channel_[get|set]_show_masked().
* app/core/gimpimage-mask.[ch]: renamed gimp_image_mask_undo() to
gimp_image_mask_push_undo(). Call it before calling GimpChannel
functions which modify the mask, also call all GimpChannel
functions with push_undo = FALSE. Emit gimp_image_mask_changed()
after each operation instead of calling it in
gimp_image_mask_invalidate(). Removed gimp_image_mask_none()
because it is the same as gimp_image_mask_clear().
General cleanup.
* app/core/gimpimage-mask-select.c
* app/core/gimpimage-qmask.c: changed accordingly.
* app/core/gimpedit.c: call gimp_image_mask_clear(), not
gimp_channel_clear (gimp_image_get_mask()).
* app/core/gimpimage-crop.c
* app/core/gimpimage-resize.c
* app/core/gimpimage-scale.c: call gimp_image_mask_changed()
* app/gui/channels-commands.c
* app/gui/select-commands.c
* app/tools/gimptexttool.c
* tools/pdbgen/pdb/channel.pdb
* tools/pdbgen/pdb/selection.pdb: follow GimpChannel and
gimp_image_mask* API changes.
* app/pdb/channel_cmds.c
* app/pdb/selection_cmds.c
* libgimpproxy/gimpchannel.h: regenerated.
Unrelated:
* app/core/gimpimage.c: call gimp_drawable_push_undo() instead of
undo_push_image() directly.
2002-08-06 Sven Neumann <sven@gimp.org>
* app/tools/gimpmagnifytool.[ch]: reverted Dave's change
since this feature has already been implemented properly
(and configurable) last December.
2002-08-05 Dave Neary <bolsh@gimp.org>
* app/tools/gimpmagnifytool.[ch]: Require a minimum
movement in the X and Y direction before we zoom in
on/out to the dragged square. Limit rather arbitrarily
set to 5. This fixes bug #86939, reported by
philipj@telia.com.
2002-06-27 Michael Natterer <mitch@gimp.org>
* app/display/gimpdisplay.[ch]: removed gdisp->scale,
gdisp->dot_for_dot, the scaling marcos and the
gdisplay_[un]transform[_f]() functions.
* app/display/gimpdisplayshell.[ch]: added them here. Named the
transform functions gimp_display_shell_[un]transform_xy[_f]().
Made the gimp_display_shell_[un]transform_coords() functions copy
all values of the GimpCoords struct, not just x and y.
* app/display/gimpstatusbar.[ch]: keep a pointer to
GimpDisplayShell, not GimpDisplay.
* app/display/gimpdisplayshell-callbacks.c
* app/display/gimpdisplayshell-render.c
* app/display/gimpdisplayshell-scale.c
* app/display/gimpdisplayshell-scroll.c
* app/display/gimpdisplayshell-selection.c
* app/display/gimpnavigationview.c
* app/gui/image-commands.c
* app/gui/info-window.c
* app/gui/select-commands.c
* app/gui/view-commands.c
* app/tools/gimpbezierselecttool.c
* app/tools/gimpcroptool.c
* app/tools/gimpdrawtool.c
* app/tools/gimpeditselectiontool.c
* app/tools/gimpmagnifytool.c
* app/tools/gimpmeasuretool.c
* app/tools/gimpmovetool.c
* app/tools/gimppainttool.c
* app/tools/gimppathtool.c
* app/tools/gimprotatetool.c
* app/tools/gimpscaletool.c
* app/tools/gimpvectortool.c: changed accordingly.
* app/gui/layers-commands.c: if(gimage->selection_mask) is always
TRUE, use if(!gimp_image_mask_is_empty(gimage)) instead.
* app/tools/gimpfuzzyselecttool.[ch]: moved global variables
to the object struct.
2002-06-20 Michael Natterer <mitch@gimp.org>
Fixed color picking (reported by jimmac on #gimp):
* app/core/gimpimage-pick-color.c: set the returned color's alpha
value to opaque if the drawable we pick from has no aplha.
* app/tools/gimpcolorpickertool.c: ignore all values returned by
gimp_image_pick_color() if it returns FALSE (which happens if we
want to pick outside the drawable).
2002-06-19 Michael Natterer <mitch@gimp.org>
Fix for #85202:
Updating the active tool's modifier state on GTK_ENTER_NOTIFY and
GTK_LEAVE_NOTIFY was a bad idea because this only works with
focus-follows-mouse. Instead, update it during the whole time the
canvas can receive key events, namely from FOCUS_IN until
FOCUS_OUT. As an ugly side condition, click-to-focus leads to
GDK_BUTTON_PRESS arriving before GDK_FOCUS_CHANGE(in).
* app/display/gimpdisplayshell-callbacks.[ch]: removed the
separate focus_in and focus_out callbacks and handle them in
gimp_display_shell_canvas_tool_events(). Moved tool state updating
from the ENTER/LEAVE code to FOCUS_CHANGE. Added an ugly static
variable "button_press_before_focus" and take care of the side
condition mentioned above.
* app/display/gimpdisplayshell.c: changed accordingly.
2002-06-17 Sven Neumann <sven@gimp.org>
Obviously I disagree with Tim about the symbol_name parameter in
g_scanner_unexp_token(). As it seems it's not supposed to be used
to tell the user about the expected symbol (see bug #81850):
* gimpconfig.[ch] (gimp_config_deserialize_return): removed the
symbol_name parameter.
* app/config/gimpconfig-deserialize.c
* app/core/gimpcontainer.c
* app/core/gimpdocumentlist.c
* app/core/gimpparasitelist.c: changed the callers accordingly.
* app/core/gimpunits.c (gimp_unitrc_load): pass NULL as symbol_name
to g_scanner_unexp_token().
2002-06-17 Michael Natterer <mitch@gimp.org>
Separated tool_options creation from tool registration so we
don't implicitly create widgets before gui_init():
* libgimptool/gimptooltypes.h: removed GimpToolOptionsNewFunc
typedef here...
* app/core/core-types.h: ...and added it here.
* libgimpproxy/gimpproxytypes.h: regenerated.
* app/core/gimptoolinfo.[ch]: added a GimpToolOptionsNewFunc
pointer to remember the constructor. Fixed the finalize() method
(bug was never noticed because we leaked all tool infos)
* app/tools/tool_manager.[ch]: moved tool_options creation to the
new function tool_manager_restore(). Unref the tool infos after
adding them to their container. Added "brush" and "gradient" to
the context properties which are defined for tool contexts.
* app/app_procs.c: call tool_manager_restore() after gui_init().
* app/gui/gui.c: removed the hack introduced recently and call
render_setup() in gui_init() again, not in gui_themes_init().
Use the correct contexts now that they are properly initialized
at the time of tool_options creation:
* app/tools/gimpblendtool.c: use tool_info->context, not
gimp_get_user_context() to get/set the tool's gradient.
* app/paint/gimppaintcore.[ch] (gimp_paint_core_start): added a
GimpPaintOptions paramater and get the brush to use from
paint_options->context (instead of gimp_get_current_context()).
* app/paint/gimppaintcore-stroke.c
* app/tools/gimppainttool.c: changed accordingly.
* app/tools/paint_options.c: added a brush preview to the paint
options.
2002-06-16 Michael Natterer <mitch@gimp.org>
* app/tools/gimpblendtool.c: set the witdh of the gradient preview
to 96 instead of 128 pixels so it is not the widest tool options
item with the "small" theme.
2002-06-16 Michael Natterer <mitch@gimp.org>
* libgimpwidgets/gimpstock.[ch]: register the new "invert" and
"layer to imagesize" PNGs as stock icons.
* app/gui/menus.c: use them here.
* themes/Default/images/Makefile.am: fixed indentation.
2002-06-13 Sven Neumann <sven@gimp.org>
* configure.in
* app/plug-in/plug-in.c (plug_in_init_shm): allocate shared memory
segments with permissions 0600 instead of making them accessible
by everyone.
2002-06-12 Sven Neumann <sven@gimp.org>
* app/paint/gimppaintcore.[ch]: applied a patch from Henning
Makholm <henning@makholm.net> that vastly improves drawing of thin
lines. See bug #69773 for a detailed description.
2002-06-12 Sven Neumann <sven@gimp.org>
* app/widgets/gimppreview.c (gimp_preview_size_allocate): center
the preview's allocation.
* app/tools/gimpblendtool.c (blend_options_new): use a button for
the gradient so it's more obvious that it can be pressed.
2002-06-12 Michael Natterer <mitch@gimp.org>
* app/core/gimpdata.[ch]: added a boolean "internal" which
indicates that the data object is an automatically created
internal object. Changed the code to refuse saving to deleting
internal objects.
* app/core/Makefile.am
* app/core/gimp-gradients.[ch]: new files implementing internal
gradients (FG -> BG in RGB and HSV and FG -> transparent).
* app/core/gimp.c: call gimp_gradients_init().
* app/core/gimpdatafactory.c (gimp_data_factory_data_free): don't
free internal objects so they stay there on "Refresh".
* app/core/gimpdatalist.c: sort internal objects to the beginning
of the list.
* app/widgets/gimpdataeditor.c: refuse to change the name of
internal objects.
* app/widgets/gimpdatafactoryview.c: set the "Delete" button
insensitive for internal objects.
* app/widgets/gimpgradienteditor.c: refuse to edit internal
gradients, just display them so color picking works.
* app/gui/brushes-commands.c
* app/gui/gradients-commands.c
* app/gui/palettes-commands.c
* app/gui/patterns-commands.c: set the "Delete" menu item
insensitive for internal objects.
* app/gui/gui.c: need to call render_setup() earlier because of
you-dont-want-to-know-why. Will change it back once the previews
have their own render buffers.
* app/tools/gimpblendtool.c: Replaced the "Type" menu by a preview
showing the active gradient. Clicking the preview pops up the
gradient selection. Renamed the "Gradient" menu to "Shape". Removed
"blend_mode" from the BlendOptions struct because we always use
"custom" mode now.
2002-06-09 Michael Natterer <mitch@gimp.org>
* themes/Default/imagerc
* themes/Default/images/Makefile.am
* libgimpwidgets/gimpstock.[ch]: register the new "Swap" and
"Default" icons in "menu" size.
* app/gui/menus.c: use them here.
* app/widgets/gimptoolbox-color-area.c: changed accordingly.
2002-06-09 Michael Natterer <mitch@gimp.org>
Paint cleanup:
* app/paint/gimpairbrush.c
* app/paint/gimpclone.c
* app/paint/gimpconvolve.c
* app/paint/gimpdodgeburn.c
* app/paint/gimperaser.c
* app/paint/gimppaintbrush.c
* app/paint/gimppencil.c
* app/paint/gimpsmudge.c
* app/tools/gimpblendtool.c: made all *_motion() functions take
only (paint_core, drawable, paint_options) and get all parametrs
from looking at paint_options. Reordered functions to be
consistent. Indentation. Stuff...
* app/paint/gimpdodgeburn.[ch]: moved the GimpLut from
GimpDodgeBurnOptions to the GimpDodgeBurn object struct.
* app/paint/gimpsmudge.[ch]: moved all global variables to the
GimpSmudge object struct.
2002-06-09 Sven Neumann <sven@gimp.org>
* app/undo.c
* app/config/gimpconfig-deserialize.c
* app/core/gimpbrushpipe.c
* app/core/gimpcontainer.c
* app/core/gimpimagefile.c
* app/gui/paths-dialog.c
* app/tools/gimpcurvestool.c
* app/tools/gimplevelstool.c
* app/widgets/gimpcomponentlistitem.c
* app/widgets/gimpgradienteditor.c: unified translatable strings
and unmarked a few for translation since they should never be seen.
2002-06-09 Sven Neumann <sven@gimp.org>
* POTFILES.in: updated.
* de.po: updated german translation.
2002-06-08 Sven Neumann <sven@gimp.org>
* app/widgets/gimptoolbox-color-area.[ch]: use stock pixbufs to
draw the "Default Colors" and "Swap Colors" buttons.
* app/widgets/gimptoolbox.c: changed accordingly.
* pixmaps/Makefile.am
* pixmaps/default.xpm
* pixmaps/swap.xpm: removed these pixmaps.
* themes/Default/images/Makefile.am
* themes/Default/images/stock-default-colors-12.png
* themes/Default/images/stock-swap-colors-12.png: added them as stock
icons.
* libgimpwidgets/gimpstock.[ch]: register the new stock icons.
2002-06-08 Sven Neumann <sven@gimp.org>
* app/base/Makefile.am
* app/paint-funcs/Makefile.am: automake-1.6 seems to use yet another
variable to pass flags to the assembler (bug #84514). Define
AM_CCASFLAGS like AM_ASFLAGS to satisfy all versions of automake.
* configure.in
* all Makefiles: removed STRIP_BEGIN and STRIP_END since it's a
GNU make extension that we don't really need and newer versions of
automake don't seem to like it.
2002-06-07 Michael Natterer <mitch@gimp.org>
* app/core/gimplist.[ch]: added gimp_list_reverse().
* app/core/gimpdocumentlist.c: call it after deserializing so we
don't reverse the history each time.
* app/widgets/gimpdevices.c: use it instead of manually fiddling
with list->list.
2002-06-06 Michael Natterer <mitch@gimp.org>
* app/core/gimpdrawable.[ch]: renamed gimp_drawable_apply_image()
to gimp_drawable_push_undo() because that's what it actually does.
* app/image_map.c
* app/core/gimpdrawable-offset.c
* app/core/gimpimage-mask.c
* app/core/gimpimage.c
* app/core/gimplayer.c
* app/paint/gimppaintcore.c
* app/tools/gimpinktool.c: changed accordingly. Removed redundant
comments because it's now obvious what the function does from
looking at its name.
* app/core/gimpdrawable.[ch]
* app/core/gimpimage.h: renamed "gboolean undo" parameters to
"gboolean push_undo".
2002-06-06 Michael Natterer <mitch@gimp.org>
* app/core/gimpchannel.[ch] (gimp_channel_invert): added a boolean
"push_undo" parameter.
* app/core/gimpimage-mask.c
* app/core/gimpimage-qmask.c: pass push_undo == TRUE.
* app/core/gimplayer.c (gimp_layer_create_mask): call
gimp_channel_invert(), not gimp_drawable_invert() because the
latter takes the current selection into accout (reported by Jimmac
on #gimp). Added g_return_if_fail() stuff to all public functions.
Cleanup.
2002-06-06 Michael Natterer <mitch@gimp.org>
* app/core/gimpcontainer.c (gimp_container_get_child_by_index):
don't warn if an out-of-bounds index is passed in but simply
return NULL (removes the need to check if the container has 0
children before asking the container for it's first child).
2002-06-05 Michael Natterer <mitch@gimp.org>
* app/tools/gimprectselecttool.c: fixed#84157: allow the tool to
scroll the display. Also preserve it on drawable changes.
2002-06-04 Michael Natterer <mitch@gimp.org>
* app/paint/gimppaintoptions.[ch]: i don't know what i was
thinking, but GimpPaintOptions.context *is* used, sorry...
2002-06-02 Michael Natterer <mitch@gimp.org>
* app/gui/session.c: parse sessionrc using GScanner.
* app/config/gimpscanner.[ch]: added utility function
gimp_scanner_parse_string_list(). Fixed the color parser's parse
error detection.
* app/gimprc.c: removed the sessionrc parsing stuff.
* app/config/gimpconfig-params.c (gimp_param_spec_color): no need
to set the param_spec's value_type, it already gets set by it's
base class' instance_init() function.
Michael Natterer