Commit Graph

1781 Commits

Author SHA1 Message Date
Sven Neumann 7e209bf5b8 another micro optimization 2004-12-22 00:03:33 +00:00
Sven Neumann e59cc07dcd fixed the degenerate case where the source image is smaller than the
2004-12-21  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c (blur_line): fixed the degenerate case
	where the source image is smaller than the blurred area. This used
	to give artefacts at the borders.
2004-12-21 22:47:58 +00:00
Sven Neumann d02f17319d more code cleanup and micro optimizations.
2004-12-21  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c: more code cleanup and micro
	optimizations.
2004-12-21 22:04:55 +00:00
Sven Neumann a4c622468c reverted the last change since it introduced artefacts. Even had to
2004-12-21  Sven Neumann  <neumann@jpk.com>

	* plug-ins/common/unsharp.c: reverted the last change since it
	introduced artefacts. Even had to increase the border around the
	previewed area. Fixed a bug in the unsharp_region where it was
	using the wrong source region for blurring.
2004-12-21 13:01:01 +00:00
Sven Neumann 7567ea229e should be height here, not width 2004-12-21 11:46:23 +00:00
Sven Neumann b8e0037222 compute preview for the displayed area only, some more code cleanup.
2004-12-21  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c: compute preview for the displayed area
	only, some more code cleanup.
2004-12-21 10:48:32 +00:00
Sven Neumann f81299c1ac fixed bug #157910. More code cleanup and some trivial optimizations.
2004-12-21  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c (preview_update): fixed bug #157910.
	More code cleanup and some trivial optimizations.
2004-12-21 00:04:34 +00:00
Sven Neumann ff4b4eaf35 more code cleanup.
2004-12-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c: more code cleanup.
2004-12-20 22:27:05 +00:00
Sven Neumann 1b9306261f more code cleanup, removed lots of redundant variables 2004-12-20 21:20:59 +00:00
Sven Neumann 3d6e33e361 code cleanup, no real changes.
2004-12-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c: code cleanup, no real changes.
2004-12-20 20:45:42 +00:00
Sven Neumann 609c84c26f push a context around code that changes the foreground color.
2004-12-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/film.c (film): push a context around code that
	changes the foreground color.
2004-12-12 22:00:31 +00:00
William Skaggs 8b414f212f Bill Skaggs <weskaggs@primate.ucdavis.edu>
* plug-ins/common/pnm.c: make export do the right thing when
	saving as .pgm or .ppm.  Fixes bug #160045.
2004-12-12 17:18:03 +00:00
Sven Neumann 75c5adf3bb applied patch from Brion Vibber that adds an alpha channel to the pasted
2004-12-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/winclipboard.c: applied patch from Brion Vibber
	that adds an alpha channel to the pasted layer. Fixes bug #148601.
2004-12-12 14:43:22 +00:00
Sven Neumann ef3c2d48da got rid of a global variable.
2004-12-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/unsharp.c: got rid of a global variable.
2004-12-11 13:45:06 +00:00
Sven Neumann 9cd408dd8f more changes to restore the gimp-2.0 behaviour.
2004-12-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/bumpmap.c (dialog_bumpmap_callback): more changes
	to restore the gimp-2.0 behaviour.
2004-12-11 11:01:26 +00:00
Sven Neumann af558db63f do actually change the bumpmap drawable. Fixes bug #160985, hopefully
2004-12-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/bumpmap.c (dialog_bumpmap_callback): do actually
	change the bumpmap drawable. Fixes bug #160985, hopefully without
	reopening bug #158494.
2004-12-11 00:11:56 +00:00
David Odin 1e77f9d4a7 marked the menu entry for translation (reported by Zigomar)
* plug-ins/common/cartoon.c: marked the menu entry for translation
  (reported by Zigomar)
2004-12-09 20:02:49 +00:00
William Skaggs 3e772fae0e Bill Skaggs <weskaggs@primate.ucdavis.edu>
* plug-ins/common/randomize.c:  Changed algorithm for Pick and
	Slur to treat all channels within a pixel in the same way;
	intended to fix bug #72852.
2004-12-08 23:16:56 +00:00
Sven Neumann 92b0e87fed applied patch from Joao S. O. Bueno that sets a lower limit for the filter
2004-12-05  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lic.c: applied patch from Joao S. O. Bueno that
	sets a lower limit for the filter length (bug #160121). The patch
	also makes the plug-in work on drawables with alpha channel.
2004-12-05 18:37:44 +00:00
Sven Neumann 6cb3f105dd applied patch from Karine Proot that limits the size of the preview in the
2004-12-05  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/wmf.c: applied patch from Karine Proot that
	limits the size of the preview in the WMF loader (bug #133521).
2004-12-05 03:25:40 +00:00
Sven Neumann 37f179aed3 change the "update" property and notify listeners (in particular
2004-11-29  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreview.c (gimp_preview_toggle_callback):
	change the "update" property and notify listeners (in particular
	GimpDrawablePreview) before invalidating the preview. Plug-ins
	might (needlessly) look at the property to decide whether they
	need to redraw. Fixes bug #159816.

	* plug-ins/common/unsharp.c (preview_update): no need to look at
	the value of the "Preview" toggle. GimpPreview takes care this.
2004-11-29 12:15:19 +00:00
Manish Singh a769f1c3b0 thumbnail buffer variable declarations should be guarded under HAVE_EXIF.
2004-11-27  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/jpeg.c (save_image): thumbnail buffer variable
        declarations should be guarded under HAVE_EXIF.
2004-11-27 23:31:02 +00:00
Sven Neumann 7643d5e971 delay the creation of the display for the export image preview until the
2004-11-27  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/jpeg.c: delay the creation of the display for
	the export image preview until the user requests a preview. Fixes
	bug #159376.
2004-11-27 22:07:23 +00:00
Sven Neumann 29eb62c231 tell the user that we can't handle indexed images with alpha channel (bug
2004-11-27  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/tiff.c (save_image): tell the user that we can't
	handle indexed images with alpha channel (bug #159600).
2004-11-27 12:39:08 +00:00
Sven Neumann eb7b317d36 app/main.c app/widgets/gimpenumstore.h app/widgets/gimpunitstore.c applied
2004-11-27  Sven Neumann  <sven@gimp.org>

	* app/main.c
	* app/widgets/gimpenumstore.h
	* app/widgets/gimpunitstore.c
	* plug-ins/common/retinex.c: applied patch by Tim Mooney that
	removes extraneous ;
2004-11-27 12:09:13 +00:00
Sven Neumann 365af1b31b applied patch by Tim Mooney that increase the size of values[] + to
2004-11-27  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/wmf.c (run): applied patch by Tim Mooney that
	increase the size of values[] + to accomodate the use of
	file_wmf_load_thumb (bug #159601).
2004-11-27 12:04:12 +00:00
Manish Singh 448dd63f9d make sure the preview image type matches the source image type.
2004-11-26  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/dog.c: make sure the preview image type matches
        the source image type.
2004-11-26 18:55:41 +00:00
Manish Singh 787afc60bd Add the temporary layers to the image, so things work. Fixes bug #158895.
2004-11-25  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/dog.c: Add the temporary layers to the image, so
        things work. Fixes bug #158895.

        * plug-ins/common/iwarp.c: Fix same naughtiness as above. There's
        other naughtiness still though.

        * plug-ins/common/sunras.c: use gboolean for byte2bit invert argument.
2004-11-26 03:52:01 +00:00
Manish Singh 7a1647b1bf Use a jpeg_error_mgr that lives within PreviewPersistent, instead of an
2004-11-25  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/jpeg.c: Use a jpeg_error_mgr that lives within
        PreviewPersistent, instead of an automatic variable in save_image.
        Fixes bug #159076.
2004-11-26 03:16:03 +00:00
Michael Natterer bd57700685 cosmetics, untabified.
2004-11-23  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpparasitelist.c: cosmetics, untabified.

	* libgimpbase/gimpparasiteio.[ch]: added g_return_if_fail()'s
	to all functions.

	(gimp_pixpipe_params_parse): changed "gchar*" param to "const
	gchar*" (sortof API change, but these files are most probably only
	used by GIMP itself). Still uses strtok() on the internal copy,
	but at least not on the passed string.

	* plug-ins/common/csource.c
	* plug-ins/common/gif.c
	* plug-ins/common/gih.c
	* plug-ins/common/jpeg.c
	* plug-ins/common/png.c
	* plug-ins/common/tiff.c: use parasite getters instead of
	accessing the scruct members directly. Always use g_strndup()
	instead of just g_strdup() to get strings stored in parasites
	because there is no guarantee that they are nul-terminated.
2004-11-23 14:28:43 +00:00
Michael Natterer 88b3cb7df2 applied patch from Wolfgang Hofer which makes the plug-in use its
2004-11-22  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/struc.c: applied patch from Wolfgang Hofer
	which makes the plug-in use its procedure name for
	storing the "last_vals" struct. Fixes bug #159028.

	* plug-ins/common/tileit.c: ditto. Fixes bug #159029.
2004-11-22 11:09:29 +00:00
Sven Neumann 3349c37a6a plug-ins/common/compose.c transfer the image resolution to newly created
2004-11-21  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/compose.c
	* plug-ins/common/decompose.c: transfer the image resolution to
	newly created images.
2004-11-21 17:45:15 +00:00
Sven Neumann 66b998686a added an (optional) parameter that allows to request the output in the
2004-11-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/glob.c: added an (optional) parameter that
	allows to request the output in the filesystem encoding.
2004-11-19 23:35:17 +00:00
Sven Neumann 86690417d8 mention encoding in the PDB docs 2004-11-19 21:23:45 +00:00
Sven Neumann 3d501d24a6 added a naive glob() implementation which handles the most common use case
2004-11-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/glob.c: added a naive glob() implementation
	which handles the most common use case and is certainly better
	than nothing. Closes bug #143661 again.
2004-11-19 21:19:07 +00:00
Sven Neumann 21d9257abf just some minor code cleanup.
2004-11-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/xpm.c: just some minor code cleanup.
2004-11-19 20:00:22 +00:00
Sven Neumann 9b50c8b2ca applied a (modified) patch that adds the possibility to correlate the
2004-11-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/noisify.c: applied a (modified) patch that adds
	the possibility to correlate the noise with the signal. Adds the
	new PDB procedure "plug_in_scatter_rgb". Fixes bug #158700.

	* plug-ins/helpbrowser/dialog.c: set a reasonable default size.
2004-11-19 18:11:25 +00:00
Sven Neumann ef31a5f714 fixed use of fread(). Unfortunately this slowed down the plug-in again.
2004-11-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/postscript.c (skip_ps) (ps_close): fixed use of
	fread(). Unfortunately this slowed down the plug-in again.
	Disabled the code that reads the pipe to the end. This brings it
	back to speed. Seems to work fine for me, let's see if this causes
	problems for anyone...
2004-11-19 13:34:07 +00:00
Sven Neumann b606e95236 added a thumbnail load procedure (bug #158193).
2004-11-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/wmf.c: added a thumbnail load procedure
	(bug #158193).
2004-11-18 22:49:45 +00:00
Sven Neumann 2d4aad8683 changed the default to load only the first page of the document and added
2004-11-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/postscript.c: changed the default to load only
	the first page of the document and added a tooltip describing how
	to specify what pages to get.
2004-11-18 21:36:10 +00:00
Sven Neumann 86a8c17025 speed up loading of multi-page documents significantly by skipping in
2004-11-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/postscript.c: speed up loading of multi-page
	documents significantly by skipping in large chunks instead of using
	fgetc() to crawl through the stream.
2004-11-18 21:10:12 +00:00
Sven Neumann 181c089a51 check the number of return values. Only retrieve width and height if the
2004-11-18  Sven Neumann  <sven@gimp.org>

	* app/file/file-open.c (file_open_thumbnail): check the number of
	return values. Only retrieve width and height if the thumbnail
	load procedure does actually provide such this information.

	* plug-ins/common/postscript.c: added a procedure to loads
	thumbnails.  For now it only renders the first page of the
	document at low resolution. It should be extended to load an
	embedded thumbnail if available.

	* plug-ins/common/jpeg.c
	* plug-ins/common/svg.c: no need to register a menu label for the
	thumbnail loaders. Allocate the return_vals array large enough to
	hold all return values.
2004-11-18 19:00:02 +00:00
Michael Natterer 30164f1be2 added back the .xcf.gz and .xcf.bz2 extensions because they are the only
2004-11-18  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/compressor.c (compressors): added back the
	.xcf.gz and .xcf.bz2 extensions because they are the only way
	to figure the special nature of this plug-in's extensions.

	* app/widgets/gimpfileprocview.[ch]: keep a list of "meta
	extensions" (extensions which have a '.' themselves).

	* app/widgets/gimpfiledialog.c (gimp_file_dialog_proc_changed):
	try to replace the whole extension if the last extension is one of
	the meta extensions kept by GimpFileProcView. Fixes bug #158377.
2004-11-18 11:50:25 +00:00
Dave Neary dded69dcc8 Fixed initialisation issue that was crashing the plug-in on repeat runs.
2004-11-17  Dave Neary  <bolsh@gimp.org>

	* plug-ins/common/bumpmap.c: Fixed initialisation issue
	that was crashing the plug-in on repeat runs. Fixes bug
	#158494.
2004-11-17 21:49:08 +00:00
Manish Singh b91a3dd27e make libgimpprocbrowser a libtooled library.
2004-11-17  Manish Singh  <yosh@gimp.org>

        * plug-ins/dbbrowser/Makefile.am: make libgimpprocbrowser a libtooled
        library.

        * plug-ins/dbbrowser/gimpprocbrowser.[ch]: add a user_data pointer
        for GimpProcBrowserApplyCallback.

        * plug-ins/dbbrowser/gimpprocbrowser.c: only convert the name to
        scheme style if scheme_names in the proc info pane too.

        * plug-ins/dbbrowser/procedure-browser.c
        * plug-ins/script-fu/script-fu-console.c: pass NULL as user_data.

        * plug-ins/script-fu/Makefile.am: reference libgimpprocbrowser.la.

        * plug-ins/pygimp/Makefile.am
        * plug-ins/pygimp/procbrowser.c: new module, which wraps
        libgimprocbrowser.

        * plug-ins/pygimp/gimpmodule.c
        * plug-ins/pygimp/pygimp.h
        * plug-ins/pygimp/pygimp-pdb.c: export GimpPDBFunction so other
        modules can use it.

        * plug-ins/pygimp/plug-ins/pdbbrowse.py
        * plug-ins/pygimp/plug-ins/gimpcons.py: use gimpprocbrowser.
2004-11-17 20:02:23 +00:00
Michael Natterer 9daad804e3 plug-ins/dbbrowser/gimpprocbox.c plug-ins/dbbrowser/gimpprocbrowser.[ch]
2004-11-17  Michael Natterer  <mitch@gimp.org>

	* plug-ins/dbbrowser/gimpprocbox.c
	* plug-ins/dbbrowser/gimpprocbrowser.[ch]
	* plug-ins/dbbrowser/gimpprocview.c: some cleanup in preparation
	of moving it to a more public place.

	* plug-ins/dbbrowser/procedure-browser.c
	* plug-ins/script-fu/script-fu-console.c: changed accordingly.
2004-11-17 14:30:35 +00:00
Manish Singh 5ab6167570 Remove unnecessary G_OBJECT() casts.
2004-11-16  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/glasstile.c: Remove unnecessary G_OBJECT() casts.
2004-11-17 02:55:29 +00:00
Michael Natterer 9560d154e4 applied (modified) patch from S. Mukund which adds EXIF thumbnail loading
2004-11-17  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/jpeg.c: applied (modified) patch from S. Mukund
	which adds EXIF thumbnail loading and saving.
	Fixes bugs #155761 and #158190.
2004-11-17 01:05:05 +00:00
Sven Neumann ab3d24f1be added missing braces around initializer.
2004-11-16  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/jigsaw.c: added missing braces around initializer.
2004-11-16 15:38:35 +00:00
Manish Singh 5d01581069 Fix a bunch of warnings from Sparse:
2004-11-13  Manish Singh  <yosh@gimp.org>

        Fix a bunch of warnings from Sparse:

        * app/actions/dockable-commands.c
        * app/actions/layers-actions.c
        * app/actions/view-commands.c
        * app/base/pixel-surround.c
        * app/config/gimpconfig-utils.c
        * app/config/gimpscanner.c
        * app/core/gimpbrushgenerated.c
        * app/core/gimpcontainer.c
        * app/core/gimpimage.c
        * app/dialogs/palette-import-dialog.c
        * app/file/gimprecentlist.c
        * app/plug-in/plug-in-params.c
        * app/text/gimptext-compat.c
        * app/text/gimptext-parasite.c
        * app/vectors/gimpbezierstroke.c
        * app/vectors/gimpstroke.c
        * app/widgets/gimpcellrendereraccel.c
        * app/widgets/gimpselectiondata.c
        * app/xcf/xcf.c
        * libgimp/gimp.c
        * libgimpthumb/gimpthumb-utils.c
        * libgimpthumb/gimpthumbnail.c
        * modules/cdisplay_proof.c
        * plug-ins/Lighting/lighting_ui.c
        * plug-ins/common/csource.c
        * plug-ins/common/glasstile.c
        * plug-ins/common/nova.c
        * plug-ins/common/pcx.c
        * plug-ins/common/pnm.c
        * plug-ins/common/randomize.c
        * plug-ins/common/screenshot.c
        * plug-ins/common/sel_gauss.c
        * plug-ins/common/spheredesigner.c
        * plug-ins/common/wind.c
        * plug-ins/gfig/gfig-dialog.c
        * plug-ins/gfig/gfig-dobject.c
        * plug-ins/gimpressionist/gimpressionist.c
        * plug-ins/ifscompose/ifscompose.c
        * plug-ins/print/gimp_main_window.c
        * plug-ins/print/print.c: Cleanup integer vs. pointer confusion.

        * app/base/temp-buf.c
        * app/dialogs/about-dialog.c
        * plug-ins/common/bumpmap.c
        * plug-ins/common/jigsaw.c
        * plug-ins/gfig/gfig-dobject.c: Cosmetic cleanups.

        * app/config/gimpconfig-deserialize.c
        * app/config/gimpconfig-path.c
        * app/config/gimpconfigwriter.c
        * app/core/gimpgradient.c
        * app/tools/gimpdrawtool.c
        * plug-ins/common/nlfilt.c
        * plug-ins/common/unsharp.c
        * plug-ins/common/zealouscrop.c: Define inline functions before they
        are used.

        * app/core/gimpdrawable-blend.c: PixelRegion definition was changed
        some time ago, but the initialization here didn't change. Fix it.

        * app/plug-in/plug-in-rc.c (plug_in_extra_deserialize): No need to
        assign token twice in a row.

        * libgimpbase/gimpdatafiles.c (gimp_datafiles_read_directories): No
        need to initialize file_data, since the code fills out all the fields.

        * plug-ins/common/CML_explorer.c
        * plug-ins/common/vpropagate.c: Declare function pointers fully.

        * plug-ins/common/grid.c (pix_composite): G_INLINE_FUNC isn't needed,
        we assume we can use the "inline" keyword always.

        * plug-ins/common/psd_save.c
        * plug-ins/common/vinvert.c
        * plug-ins/gfig/gfig-arc.c
        * plug-ins/gfig/gfig-bezier.c
        * plug-ins/gfig/gfig-circle.c
        * plug-ins/gfig/gfig-dialog.c
        * plug-ins/gfig/gfig-dobject.c
        * plug-ins/gfig/gfig-ellipse.c
        * plug-ins/gfig/gfig-line.c
        * plug-ins/gfig/gfig-poly.c
        * plug-ins/gfig/gfig-spiral.c
        * plug-ins/gfig/gfig-star.c
        * plug-ins/gfig/gfig.c
        * plug-ins/gimpressionist/orientmap.c
        * plug-ins/gimpressionist/placement.c
        * plug-ins/gimpressionist/sizemap.c
        * plug-ins/imagemap/imap_grid.c
        * plug-ins/imagemap/imap_main.c
        * plug-ins/imagemap/imap_preferences.c
        * plug-ins/imagemap/imap_settings.c
        * plug-ins/maze/maze.c
        * plug-ins/sel2path/curve.c
        * plug-ins/sel2path/fit.c
        * plug-ins/sel2path/pxl-outline.c
        * plug-ins/sel2path/spline.c
        * plug-ins/xjt/xjt.c: Functions with no args should be declared
        with (void).

        * plug-ins/common/retinex.c (MSRCR): Initialize max_preview to quiet
        the compiler.
2004-11-14 02:50:33 +00:00