Commit Graph

9072 Commits

Author SHA1 Message Date
Sven Neumann 6a9db536e9 if we are in adjust mode, skip the GimpBrushClass when chaining up. Fixes
2007-05-02  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpperspectiveclonetool.c
	(gimp_perspective_clone_tool_cursor_update): if we are in adjust
	mode, skip the GimpBrushClass when chaining up. Fixes bug #354933.

svn path=/trunk/; revision=22379
2007-05-02 13:24:14 +00:00
Sven Neumann 2bcd3afe80 app/paint/gimpsmudge.c (gimp_smudge_start)
2007-05-02  Sven Neumann  <sven@gimp.org>

	* app/paint/gimpsmudge.c (gimp_smudge_start)

	* app/paint/gimpconvolve.c (gimp_convolve_motion): use
	gimp_pickable_get_pixel_at() to get the color to use with
	color_region(). Fixes Smudge and Convolve tools on grayscale images.

svn path=/trunk/; revision=22376
2007-05-02 12:03:19 +00:00
Sven Neumann ebb9c00470 the GLib version that has string validation fixed is 2.12.12.
2007-05-02  Sven Neumann  <sven@gimp.org>

	* app/core/gimpparamspecs.c (gimp_param_string_validate): the GLib
	version that has string validation fixed is 2.12.12.

svn path=/trunk/; revision=22375
2007-05-02 09:56:01 +00:00
Martin Nordholts 8776dc7f38 When adjusting a rectangle it feels unintuitive that the center of the
2007-05-02  Martin Nordholts  <martinn@svn.gnome.org>

	When adjusting a rectangle it feels unintuitive that the center of
	the rectangle when Ctrl is used lands on the corner that was used
	to resize the rectangle. This commit changes the center of the
	rectangle when Ctrl is used on a already-created rectangle to the
	center of the rectangle when the user starts adjusting the size.

	* app/tools/gimprectangletool.c (struct
	_GimpRectangleToolPrivate): Added center_[xy]_on_fixed_center
	members that keeps track on where the center of the rectangle
	should be when the Ctrl modifier is used.

	* app/tools/gimprectangletool.c: Added convenience function
	gimp_rectangle_tool_get_fixed_center_coords.

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_button_press): Sets the
	center_[xy]_on_fixed_center members depending on whether the button
	press modifies an existing rectangle or creates a new one.

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_active_modifier_key): Adjusted to accomodate to
	above mentioned changes.


svn path=/trunk/; revision=22374
2007-05-02 09:14:35 +00:00
Sven Neumann 8f7491f2eb cosmetics.
2007-05-02  Sven Neumann  <sven@gimp.org>

	* app/base/tile-manager.c: cosmetics.

svn path=/trunk/; revision=22373
2007-05-02 09:00:46 +00:00
Michael Natterer ee0ab61b4f changed "drawable" parameter to "pickable" and added some special casing
2007-04-30  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpselection.[ch] (gimp_selection_extract): changed
	"drawable" parameter to "pickable" and added some special casing
	for the GIMP_IS_DRAWABLE(pickable) case in the implementation.

	* app/core/gimpdrawable-transform.c: changed accordingly.

	* app/core/gimp-edit.c: ditto. Removed utility function
	gimp_edit_extract_visible() and simply use gimp_edit_extract() for
	"copy visible", passing image->projection. Fixes bug #434102.


svn path=/trunk/; revision=22368
2007-04-30 17:26:15 +00:00
Sven Neumann efb221acc7 app/widgets/gimpclipboard.c app/widgets/gimpdnd-xds.c use
2007-04-28  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpclipboard.c
	* app/widgets/gimpdnd-xds.c
	* plug-ins/helpbrowser/dialog.c: use 
gdk_atom_intern_static_string().


svn path=/trunk/; revision=22360
2007-04-28 10:11:37 +00:00
Sven Neumann 7c1fc759f5 added get_pixel_at() method to the GimpPickable interface. This gives
2007-04-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimppickable.[ch]: added get_pixel_at() method to the
	GimpPickable interface. This gives direct access to the pixel
	without converting it to an RGB color.

	* app/core/gimpdrawable.c
	* app/core/gimpimagemap.c
	* app/core/gimpprojection.c: implement the new method and also use
	it to reimplement get_color_at().

	* app/core/gimpimage-crop.c (gimp_image_crop_guess_bgcolor): use
	gimp_pickable_get_pixel_at(). Fixes auto-shrink on indexed and
	grayscale images.

svn path=/trunk/; revision=22359
2007-04-27 16:07:49 +00:00
Michael Natterer ff8ba7ea78 renamed GimpParamSpecString's flag "no_validate" to "allow_non_utf8".
2007-04-26  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpparamspecs.[ch]: renamed GimpParamSpecString's
	flag "no_validate" to "allow_non_utf8".

	* tools/pdbgen/app.pl
	* tools/pdbgen/pdb/*.pdb: renamed argument flag
	"no_validate" (which turns off utf8-validation for strings) to
	"allow_non_utf8" and renamed "no_success" (which turns off
	argument validation alltogether) to "no_validate".
	Doesn't affect generated code.


svn path=/trunk/; revision=22350
2007-04-26 19:10:23 +00:00
Michael Natterer 37a3f95d16 tools/pdbgen/pdb/display.pdb (diplay_is_valid)
2007-04-26  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/display.pdb (diplay_is_valid)
	* tools/pdbgen/pdb/drawable.pdb (drawable_is_valid)
	* tools/pdbgen/pdb/image.pdb (image_is_valid)
	* tools/pdbgen/pdb/vectors.pdb (vectors_is_valid): it's the
	argument flag "no_success" which turns off validation, not
	"no_validate" (how obvious). Also fixed drawable and vectors
	procedures to check for !gimp_item_is_removed() instead of
	gimp_item_is_attached() (a newly created item is unattached
	but valid).

	* app/pdb/display_cmds.c
	* app/pdb/drawable_cmds.c
	* app/pdb/image_cmds.c
	* app/pdb/vectors_cmds.c: regenerated.


svn path=/trunk/; revision=22349
2007-04-26 17:54:23 +00:00
Sven Neumann 3075f763ad app/paint-funcs/paint-funcs.c (gaussian_blur_region)
2007-04-26  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c (gaussian_blur_region)
	* plug-ins/common/blur.c (blur)
	* plug-ins/common/gauss.c (do_encoded_lre) (do_full_lre): reduce
	rounding errors.

	* plug-ins/common/checkerboard.c (checkerboard_dialog): layout
	improvements.

svn path=/trunk/; revision=22345
2007-04-26 14:30:07 +00:00
Michael Natterer 6369e06ece removed bogus "return" from void function. Fixes bug #433339, patch from
2007-04-25  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpbrush.c (gimp_brush_scale_size): removed bogus
	"return" from void function. Fixes bug #433339, patch from Eric
	Lamarque.


svn path=/trunk/; revision=22335
2007-04-25 16:04:06 +00:00
Michael Natterer 54737072a0 added #warning to use GParamSpecString's features once we depend on a
2007-04-25  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpparamspecs.c (gimp_param_string_validate): added
	#warning to use GParamSpecString's features once we depend on a
	fixed version.


svn path=/trunk/; revision=22330
2007-04-25 14:38:20 +00:00
Michael Natterer d6fd55064b added "gboolean non_empty" to require the string being non-empty. Changed
2007-04-25  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpparamspecs.[ch] (struct GimpParamSpecString)
	(gimp_param_spec_string): added "gboolean non_empty" to require
	the string being non-empty. Changed validation accordingly.
	Also fixed validation for static strings (we were happily
	freeing and modifying them before).

	* app/xcf/xcf.c: filenames should be non-empty.
	* app/pdb/gimp-pdb-compat.c: compat strings shouldn't.

	* tools/pdbgen/app.pl: add support for $arg->{non_empty} and
	changed generation of calls to gimp_param_spec_string().

	* tools/pdbgen/pdb/brush_select.pdb
	* tools/pdbgen/pdb/edit.pdb
	* tools/pdbgen/pdb/vectors.pdb
	* tools/pdbgen/pdb/plug_in.pdb
	* tools/pdbgen/pdb/gradient.pdb
	* tools/pdbgen/pdb/palette_select.pdb
	* tools/pdbgen/pdb/palette.pdb
	* tools/pdbgen/pdb/fileops.pdb
	* tools/pdbgen/pdb/progress.pdb
	* tools/pdbgen/pdb/procedural_db.pdb
	* tools/pdbgen/pdb/font_select.pdb
	* tools/pdbgen/pdb/pattern_select.pdb
	* tools/pdbgen/pdb/unit.pdb
	* tools/pdbgen/pdb/brush.pdb
	* tools/pdbgen/pdb/gradient_select.pdb
	* tools/pdbgen/pdb/buffer.pdb: require non-empty strings for data
	object names, procedure names, unit strings, PDB data identifiers
	and buffer names. Removed some manual strlen() checks, all other
	places just got better error reporting for free (proper validation
	error instead of unspecific execution error).

	* app/pdb/*_cmds.c: regenerated.


svn path=/trunk/; revision=22329
2007-04-25 14:23:05 +00:00
Sven Neumann 681764e4e8 round pixel values instead if just casting the float to an integer. Fixes
2007-04-25  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c (convolve_region): round pixel values
	instead if just casting the float to an integer. Fixes bug #432978.

svn path=/trunk/; revision=22322
2007-04-25 11:46:14 +00:00
Sven Neumann 8bfd436f31 whitespace cleanup.
2007-04-25  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c: whitespace cleanup.

svn path=/trunk/; revision=22321
2007-04-25 11:36:39 +00:00
Sven Neumann e3813131b7 also use the middle mouse button for panning.
2007-04-25  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpscrolledpreview.c: also use the middle mouse
	button for panning.

	* plug-ins/common/nova.c: override the default mouse handling of
	the GimpScrolledPreview and allow to reposition the center using
	the left mouse button. Fixes bug #364432.

	* app/tools/gimprectangletool.c: formatting.

svn path=/trunk/; revision=22319
2007-04-25 10:10:43 +00:00
Sven Neumann f92f6d1708 fiddle with test_config_LDFLAGS to make test-config link again.
2007-04-24  Sven Neumann  <sven@gimp.org>

	* app/config/Makefile.am: fiddle with test_config_LDFLAGS to make
	test-config link again.

svn path=/trunk/; revision=22309
2007-04-24 16:00:42 +00:00
Sven Neumann 5313214382 use GQuark for locale and help domains to avoid duplicating the same
2007-04-24  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginprocedure.[ch]: use GQuark for locale and
	help domains to avoid duplicating the same strings many times.

	* app/plug-in/gimppluginmanager-restore.c: removed FIXME.


svn path=/trunk/; revision=22304
2007-04-24 10:28:28 +00:00
Michael Natterer 687fc2d415 set the default plug-in locale domain on all GimpPlugInDefs which don't
2007-04-24  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimppluginmanager-restore.c
	(gimp_plug_in_manager_restore): set the default plug-in locale
	domain on all GimpPlugInDefs which don't register a locale domain
	themselves. Fixes bug #430146.


svn path=/trunk/; revision=22303
2007-04-24 09:35:42 +00:00
Michael Natterer 89329ada9f tools/pdbgen/pdb/brush.pdb (brush_rename) tools/pdbgen/pdb/gradient.pdb
2007-04-22  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/brush.pdb (brush_rename)
	* tools/pdbgen/pdb/gradient.pdb (gradient_rename)
	* tools/pdbgen/pdb/palette.pdb (palette_rename): don't allow the
	empty string as new name. Fixes bug #431845.

	* app/pdb/brush_cmds.c
	* app/pdb/gradient_cmds.c
	* app/pdb/palette_cmds.c: regenerated.


svn path=/trunk/; revision=22301
2007-04-22 12:17:41 +00:00
Sven Neumann 31ca80fd17 app/widgets/dbus-service.xml use "uri" instead of "filename" in the D-Bus
2007-04-21  Sven Neumann  <sven@gimp.org>

	* app/widgets/dbus-service.xml
	* app/widgets/gimpdbusservice.[ch]: use "uri" instead of 
"filename"
	in the D-Bus methods.


svn path=/trunk/; revision=22298
2007-04-21 18:09:16 +00:00
Sven Neumann 46ff5adf19 don't override LDFLAGS, use AM_LDFLAGS instead.
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/Makefile.am: don't override LDFLAGS, use AM_LDFLAGS 
instead.


svn path=/trunk/; revision=22287
2007-04-18 18:38:15 +00:00
Sven Neumann 44cefcc818 app/plug-in/Makefile.am app/plug-in/gimppluginmanager.[ch] moved
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/plug-in/Makefile.am
	* app/plug-in/gimppluginmanager.[ch]
	* app/plug-in/gimppluginmanager-restore.[ch]: moved
	gimp_plug_in_manager_restore() to it's own file.

	* app/core/gimp.c: changed accordingly.

	* app/Makefile.am (LDFLAGS): convince the linker to do its job.


svn path=/trunk/; revision=22286
2007-04-18 15:06:05 +00:00
Sven Neumann 91dc2e614e added another helper function to improve readability
svn path=/trunk/; revision=22284
2007-04-18 14:28:47 +00:00
Sven Neumann 76b1f3ca3f try to improve readability by moving code to helper functions.
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginmanager.c (gimp_plug_in_manager_restore):
	try to improve readability by moving code to helper functions.

svn path=/trunk/; revision=22283
2007-04-18 14:23:20 +00:00
Sven Neumann 3d5a8450da added a function that returns all file extensions registered in the
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimpinterpreterdb.[ch]: added a function that
	returns all file extensions registered in the interpreter db.

	* app/plug-in/gimppluginmanager.c (gimp_plug_in_manager_restore):
	if the PATHEXT environment variable is set, append all registered
	file extensions to it. This way GIMP can recognize Python scripts
	as plug-ins on platforms where the executable bit is unknown.


svn path=/trunk/; revision=22282
2007-04-18 13:21:20 +00:00
Sven Neumann 49b8176aa5 Allow other applications to open images in GIMP as if they were new images
2007-04-17  Sven Neumann  <sven@gimp.org>

	Allow other applications to open images in GIMP as if they were
	new images (without associating a filename). Fixes bug #423118.

	* app/file/file-open.[ch]: added parameter 'as_new' to
	file_open_image() and its variants.

	* app/actions/data-commands.c
	* app/actions/documents-commands.c
	* app/actions/file-commands.c
	* app/core/gimpimagefile.c
	* app/dialogs/file-open-dialog.c
	* app/dialogs/file-open-location-dialog.c
	* app/widgets/gimptoolbox.c
	* app/widgets/gimptoolbox-dnd.c: changed accordingly.

	* app/app.[ch]
	* app/main.c: added new command-line option '--as-new'.

	* app/widgets/gimpdbusservice.[ch]
	* app/widgets/dbus-service.xml: added new method "OpenAsNew" to the
	D-Bus interface.

	* docs/gimp.1.in: document the new command-line option.


svn path=/trunk/; revision=22264
2007-04-17 15:54:01 +00:00
Michael Natterer e198e7cba3 app/config/gimprc.c app/plug-in/gimppluginmanager.c
2007-04-17  Michael Natterer  <mitch@gimp.org>

	* app/config/gimprc.c
	* app/plug-in/gimppluginmanager.c
	* app/plug-in/gimpplugin.c
	* app/gui/themes.c: don't translate --verbose or g_printerr()
	messages, they are debugging output that often end up in bugzilla
	and should not depend on the locale.


svn path=/trunk/; revision=22262
2007-04-17 14:25:09 +00:00
Sven Neumann 4ea83b2c60 documentation fix.
2007-04-16  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c: documentation fix.


svn path=/trunk/; revision=22258
2007-04-16 15:02:51 +00:00
Michael Natterer dfd1309b19 app/widgets/Makefile.am app/widgets/widgets-types.h remove
2007-04-16  Michael Natterer  <mitch@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpcellrendereraccel.[ch]: remove GimpCellRenererAccel.

	* app/widgets/gimpactionview.c: use GtkCellRendererAccel instead.
	If an action has no label, use its name as label. Always show the
	"Name" column because there are too many actions with confusingly
	similar names.


svn path=/trunk/; revision=22256
2007-04-16 13:43:31 +00:00
Sven Neumann 467581b790 INSTALL configure.in require gtk+ >= 2.10.6.
2007-04-16  Sven Neumann  <sven@gimp.org>

	* INSTALL
	* configure.in
	* app/gui/gui.c (gui_sanity_check): require gtk+ >= 2.10.6.


svn path=/trunk/; revision=22255
2007-04-16 12:39:06 +00:00
Michael Natterer f2acde4c60 app/base/base-types.h remove redundant and inconsistently used MaskBuf
2007-04-13  Michael Natterer  <mitch@gimp.org>

	* app/base/base-types.h
	* app/base/temp-buf.[ch]: remove redundant and inconsistently used
	MaskBuf type and API.

	* app/core/gimpbrush-scale.c
	* app/paint/gimpbrushcore.[ch]: use TempBuf and its API instead.
	This also optimizes away a useless memset() on brush scaling,
	we completely fill each of the created buffers anyway.


svn path=/trunk/; revision=22249
2007-04-13 14:04:37 +00:00
Sven Neumann 9870749e1a implement GimpTool::key_press and delegate to the rectangle tool or the
2007-04-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangleselecttool.c: implement
	GimpTool::key_press and delegate to the rectangle tool or the 
edit
	selection tool. This resurrects positioning of floating 
selections
	with the cursor keys.


svn path=/trunk/; revision=22244
2007-04-12 20:07:38 +00:00
Sven Neumann 4f6c5c7a24 added a note that calling this function may cause data loss.
2007-04-12  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/display.pdb (display_delete): added a note that
	calling this function may cause data loss.

	* app/pdb/display_cmds.c
	* libgimp/gimpdisplay_pdb.c: regenerated.


svn path=/trunk/; revision=22243
2007-04-12 16:32:20 +00:00
Sven Neumann 65f2809545 if a plug-in or script registered with a DISPLAY argument after the
2007-04-12  Sven Neumann  <sven@gimp.org>

	* app/actions/plug-in-commands.c: if a plug-in or script
	registered with a DISPLAY argument after the run-mode argument,
	then pass the ID of the active display to the script, optionally
	followed by image and drawable IDs.

	* plug-ins/script-fu/scheme-wrapper.c
	* plug-ins/script-fu/script-fu-enums.h
	* plug-ins/script-fu/script-fu-interface.c
	* plug-ins/script-fu/script-fu-scripts.c
	* plug-ins/script-fu/script-fu-types.h: added SF-DISPLAY parameter.

svn path=/trunk/; revision=22241
2007-04-12 15:56:57 +00:00
Sven Neumann c68c91c94d app/tools/gimplevelstool.c app/tools/gimpcurvestool.c app/xcf/xcf-save.c
2007-04-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimplevelstool.c
	* app/tools/gimpcurvestool.c
	* app/xcf/xcf-save.c
	* app/xcf/xcf-load.c
	* app/widgets/gimppaletteeditor.c
	* app/widgets/gimpcolormapeditor.c
	* app/widgets/gimpcolorframe.c: get rid of compiler warnings about
	dereferencing type-punned pointers.


svn path=/trunk/; revision=22238
2007-04-12 14:48:04 +00:00
Mukund Sivaraman bc5843031b Fixes a bug (#428493) where gimp_statusbar_push_temp() expects vaargs and
2007-04-11  Mukund Sivaraman  <muks@mukund.org>

        * app/display/gimpstatusbar.c: Fixes a bug (#428493) where
          gimp_statusbar_push_temp() expects vaargs and
          gimp_statusbar_progress_message() directly passes a message
          to it as the format string.. in this case the message
          contains % (in the filename) and no arguments.


svn path=/trunk/; revision=22231
2007-04-11 09:42:51 +00:00
Michael Natterer 7cb18110b1 app/paint/gimpperspectiveclone.c #include "libgimpmath/gimpmath.h"
2007-04-09  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpperspectiveclone.c
	* app/paint/gimppaintoptions.c: #include "libgimpmath/gimpmath.h"


svn path=/trunk/; revision=22225
2007-04-09 11:54:44 +00:00
Michael Natterer c6733ac891 app/base/Makefile.am removed these files.
2007-04-01  Michael Natterer  <mitch@gimp.org>

	* app/base/Makefile.am
	* app/base/brush-scale.[ch]: removed these files.

	* app/core/Makefile.am
	* app/core/gimpbrush-scale.[ch]: added the functions here as
	static utility functions. Also move the default implementations of
	GimpBrush::scale_size(), ::scale_mask() and ::scale_pixmap() here,
	including their utility functions.

	* app/core/gimpbrush.c: remove all scale stuff and
	include "gimpbrush-scale.h" instead.

	(gimp_brush_get_new_preview): use GimpBrush's scale functions
	instead of the now private ones. Cleanup.

	(gimp_brush_scale_mask)
	(gimp_brush_scale_pixmap): return a copy of the buf for
	scale == 1.0.


svn path=/trunk/; revision=22213
2007-04-01 13:38:22 +00:00
Michael Natterer 00be2f5f8c use SQR(x) instead of x*x.
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpdrawable-blend.c: use SQR(x) instead of x*x.


svn path=/trunk/; revision=22211
2007-03-31 16:45:19 +00:00
Michael Natterer b2ef4856b0 set core->saved_proj_tiles to NULL after unrefing them.
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimppaintcore.c (gimp_paint_core_start): set
	core->saved_proj_tiles to NULL after unrefing them.

	* app/paint/gimppaintcore.h: whitespace fixes.


svn path=/trunk/; revision=22210
2007-03-31 16:43:41 +00:00
Michael Natterer 3adb312e12 made the GimpRectangleOptionsPrivate struct public (ha ha).
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleoptions.[ch]: made the
	GimpRectangleOptionsPrivate struct public (ha ha).

	(gimp_rectangle_options_gui): replaced the "Auto shrink selection"
	toggle by a normal button that needs to be clicked explicitely.

	* app/tools/gimprectangletool.c: access members of
	GimpRectangleOptionsPrivate directly instead of reading them into
	local variables using g_object_get(), this makes the code quite
	more readable. Some code cleanup.

	(gimp_rectangle_tool_button_release): get rid of the confusing
	auto-shrink madness on button release...

	(gimp_rectangle_tool_start)
	(gimp_rectangle_tool_halt): ...instead, connect to the option's
	auto shrink button and shrink on "clicked".


svn path=/trunk/; revision=22209
2007-03-31 16:38:55 +00:00
Michael Natterer 0d7ccd8f56 read the "operation" member of GimpSelectionOptions directly.
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleselecttool.c: read the "operation" member
	of GimpSelectionOptions directly.

	* app/tools/gimpellipseselecttool.c (gimp_ellipse_select_tool_draw):
	chain up instead of calling gimp_rectangle_tool_draw() directly,
	don't #include "gimprectantletool.h".


svn path=/trunk/; revision=22208
2007-03-31 16:22:57 +00:00
Michael Natterer 58bea5b1b6 access the GimpCropOptions structure directly to read the "layer_only"
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcroptool.c: access the GimpCropOptions structure
	directly to read the "layer_only" option (don't use g_object_get),
	some code cleanup.


svn path=/trunk/; revision=22207
2007-03-31 16:07:05 +00:00
Michael Natterer 6e422b5211 Statusbar messages shouldn't depend on the emission of unrelated signals:
2007-03-31  Michael Natterer  <mitch@gimp.org>

	Statusbar messages shouldn't depend on the emission of unrelated
	signals:

	* app/widgets/gimpuimanager.c (gimp_ui_manager_connect_proxy):
	connect to the menu items' "select" and "deselect" signals here...

	(gimp_ui_manager_item_realize): ...instead of here.


svn path=/trunk/; revision=22206
2007-03-31 12:25:03 +00:00
Michael Natterer 6fd436f9cb app/actions/dialogs-actions.c app/actions/dock-actions.c
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/actions/dialogs-actions.c
	* app/actions/dock-actions.c
	* app/actions/edit-actions.c
	* app/actions/file-actions.c
	* app/actions/help-actions.c
	* app/actions/layers-actions.c
	* app/actions/plug-in-actions.c
	* app/actions/tools-actions.c
	* app/actions/vectors-actions.c
	* app/actions/view-actions.c
	* app/actions/window-actions.c: add many missing action tooltips
	and fixed some broken/inconsistent ones. Sorry for the big string
	change but the inconsistenties were just too big to ship 2.4 like
	that.


svn path=/trunk/; revision=22204
2007-03-31 11:38:47 +00:00
Sven Neumann 04b0433c84 cosmetics
svn path=/trunk/; revision=22202
2007-03-30 10:18:05 +00:00
Sven Neumann 05d6439d9d hardcode the result of log (1.0 / 255.0) and avoid a useless call to
2007-03-30  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c: hardcode the result of
	log (1.0 / 255.0) and avoid a useless call to sqrt().

svn path=/trunk/; revision=22201
2007-03-30 10:14:30 +00:00
Sven Neumann f51e694972 compare square of errors instead of calculating the square root. Rewritten
2007-03-30  Sven Neumann  <sven@gimp.org>

	* app/paint/gimpheal.c (gimp_heal_laplace_iteration)
	(gimp_heal_laplace_loop): compare square of errors instead of
	calculating the square root. Rewritten loop to avoid code duplication.

svn path=/trunk/; revision=22200
2007-03-30 09:53:43 +00:00