2001-03-31 Michael Natterer <mitch@gimp.org>
* app/undo.c: made undo_pop_paint() work again.
* app/tools/gimppainttool.[ch]: store the tool ID and the tool
type in the PaintUndo struct.
* app/tools/gimppenciltool.c: removed unused variable.
* app/tools/gimptool.c: removed and reordered STUB()s and cruft.
2001-03-31 Michael Natterer <mitch@gimp.org>
* app/tools/Makefile.am
* app/tools/gimpfliptool.[ch]: applied a patch from Dave Neary
which re-activates this tool. Enabled the tool options too.
* app/tools/gimpbezierselecttool.c
* app/tools/gimpbucketfilltool.c
* app/tools/gimpiscissorstool.c
* app/tools/gimptexttool.c: trivial fixes.
* app/tools/gimptool.c: removed cruft.
* app/tools/gimptransformtool.[ch]: a special case for the flip
tool, cleanup.
* app/tools/tools.c: register the flip tool.
2001-03-31 Michael Natterer <mitch@gimp.org>
* app/undo.c: re-enabled transform undo. Fixes the transform tool
crashes.
* app/tools/gimptool.[ch]: put tool->ID back because the undo
system uses it. Also, a unique tool serial number will be not too
bad to have once we have module tools.
* app/tools/gimptransformtool.[ch]: changed accordingly.
2001-03-31 Michael Natterer <mitch@gimp.org>
* app/Makefile.am
* app/pixel_surround.[ch]: lowlevel stuff taken out of the transform
tool.
* app/tools/gimpscaletool.[ch]: minor cleanups, declare
gimp_scale_tool_register() publically.
* app/tools/gimptransformtool.[ch]: removed the PixelSurround stuff,
hardcode tr_tool->interactive to TRUE, removed the no_draw() function,
register the tool options, misc. other fixes and bad hacks that need
to go away.
(All this non-interactive stuff needs to be done outside the tool
system. A "non-interactive tool" is just pure nonsense)
* app/tools/gimptool.h: spacing.
* app/tools/tool_manager.c: tool_manager_register_tool_options():
return after warning, don't simply continue and crash.
* app/tools/tools.c: register the bezier select tool.
2001-03-30 Michael Natterer <mitch@gimp.org>
* app/app_procs.[ch]: some random cleanups in pre-historic code.
* app/fileops.c: useless cleanup (will be split into file-open.[ch]
and file-save.[ch] soon).
* app/gimppattern.c: implement GimpData's "duplicate" method.
* app/global_edit.c: cleanup in preparation for making a view on a
GimpContainer of cut buffers out of it.
* app/gradient_editor.c: don't let the name entry expand vertically.
* app/menus.c: typos.
2001-03-25 18:16:50 Adam D. Moss <adam@gimp.org>
* app/convert.c: Define accessor function/macro for histogram
reads and writes. This slows us down a little because we avoid
some of the dirty tricks we used when we knew that the histogram
was a straight 3d array, so I've recovered some of the speed loss
by implementing a 5d accessor function with good locality of
reference. This change is the first step towards quantizing in a
more interesting colourspace than frumpy old RGB.
Dodge/Burn is back
Needs a bit of luvin still, but generally works
ChangeLog app/tools/Makefile.am app/tools/gimpdodgeburntool.c
app/tools/gimpdodgeburntool.h app/tools/gimptool.c
app/tools/paint_options.c app/tools/tools.c
2001-03-16 Hans Breuer <hans@breuer.org>
* app/makefile.msc
* app/tools/makefile.msc : adapted to current state of file
renaming/restructuring. Probably will break again soon ...
* app/context_manager.c : needs register_tools () prototype
* app/gimplist.c
* app/gimppalette-import.c : #include <string.h> for memcpy, strcmp
and friends
* app/pdb/fileops_cmds.c : #include <process.h> /* for _getpid() */
(Yes I know that this is not the right place to change it, but hacking
pdbgen.pl to get platform specific headers is out of my scope)
* app/test_commands.c : explicit casts to (GimpSetDrawableFunc) make
it compile even with strict checks turned on.
* app/undo.c (undo_pop_paint) : return a value even if the function
does nothing at the moment (makes it compile)
* libgimp/gimp.def : updated
* libgimp/gimpcolorselector.h : include <gmodule.h> to make
gimp_color_selector_(un)register prototypes conform to their
implementation
* libgimp/gimpfeatures.h : reflect 1.3 version
* libgimpmath/gimpmatrix.c
* libgimpwidgets/gimpdialog.c : more <string.h> inclusion
* libgimp/makefile.msc : moved gimpadativesupersample.c to
libgimpcolor, which makes it reusable from the core, too.
* libgimp/gimp.def : updated
* libgimp/gimpproceduraledb.c : #include <string.h>
* libgimpcolor/gimpcolor.def
* libgimpcolor/makefile.msc : added gimpadaptivesupersample
* libgimpmath/gimpmatrix.c : #include <string.h> for memcmp
* libgimpwidgets/gimpdialog.c - " - for strcmp
2001-03-12 Michael Natterer <mitch@gimp.org>
* app/gimplayerlistview.c: added some help_data and tooltips.
* app/tools/Makefile.am
* app/tools/gimperasertool.[ch]: one more.
* app/tools/gimppaintbrushtool.[ch]
* app/tools/gimppenciltool.[ch]: made all paint tools look the same.
* app/tools/gimppainttool.c
* app/tools/gimptool.[ch]
* app/tools/paint_options.c
* app/tools/tools.c: changed accordingly.
* pixmaps/anchor.xpm: made it a bit smaller.
* pixmaps/refresh.xpm: replaced with the "Recurrence" icon from
evolution.
2001-03-12 Michael Natterer <mitch@gimp.org>
* pixmaps/Makefile.am
* pixmaps/edit.xpm: new pixmap. "Someone" needs to go over the
pixmaps one day ;)
* app/gimpdatafactoryview.c
* app/gimpdrawablelistview.c: use the new icon.
* app/floating_sel.c: stupid: the new gimp_layer_get_opacity()
accessor speaks in normalized [0.0..1.0] values, so the
floating selection was invisible after blindly using it.
* app/gimpimage.c: more stupid: a totally useless sanity clamping
made the composite preview ugly. Fixed.
* app/tools/tool_manager.c: why the heck did this never crash before:
don't dereference a NULL GDisplay pointer.
2001-03-11 Michael Natterer <mitch@gimp.org>
* app/Makefile.am
* app/apptypes.h
* app/gimplayerlistview.[ch]: new subclass of GimpDrawableListView
(the upcoming replacement of the layers dialog). Connects to the
new GimpLayer signals using the layer container as signal proxy
(see below).
* app/gimpcontainerview.[ch]: made "set_container" a virtual
function. This is needed by the GimpLayerListView to
connect/disconnect signals. Subclasses implementing this method
MUST obey the following order of instructions:
1. disconnect from signals related to GimpContainerView->container
2. chain up (!!!)
3. connect to signals related to GimpContainerView->container
And yes, I will add DocBook files for all those new objects :)
* app/gimppreview.[ch]: made "border_color" a GimpRGB instead of
guchar[3]. Added gimp_preview_set_border_color().
* app/gimpcontainergridview.c
* app/gimplayerlistitem.c: use gimp_preview_set_border_color().
* app/gimpcontainerlistview.c
* app/gimpdrawablelistview.c: cleanup.
* app/gimpdrawablelistitem.c: we can safely asume that our parent
widget is a GimpDrawableListView and use it's "reorder_drawable"
function pointer (after checking that it's there).
* app/gimplistitem.c: connect the correct DND type when changing
the container of a list item with "reorderable" enabled.
* app/gimplayer.[ch]: added accessors and "*_changed" signals for
layer->mode, layer->opacity and layer->preserve_trans.
* app/disp_callbacks.c: fixed a FIXME: use the correct bucket fill
tool context again.
* app/tools/paint_options.[ch]: paint_mode_menu_new(): added a
boolean which toggles the "Behind" item on/off to the same
constructor can be used for all paint mode menus.
* app/tools/gimptoolinfo.c: rect. select is the standard tool again.
* app/brush_select.c
* app/floating_sel.c
* app/gimpimage.c
* app/layers_dialog.c
* app/pdb/layer_cmds.c
* app/tools/gimpeditselectiontool.c
* tools/pdbgen/pdb/layer.pdb: use the new layer accessors and the
paint_mode_menu constructor.
* app/commands.c
* app/gdisplay.c
* app/menus.c
* app/undo.c
* app/tools/gimppainttool.c
* app/tools/gimptool.c
* app/tools/paint_options.c
* app/tools/tool_manager.c: put the #warning's back inside
#ifdef __GNUC__
* app/Makefile.am
Inclusion of David's MMX code into Makefile now
depends on prior definition of HAVE_ASM_MMX.
* app/pdb/procedural_db.c
Line 276 cast of va_args to type GimpRGB seems
very problematical on SGI, as the va_args macro
expands to Extreme Ugliness and
(GimpRGB)(Extreme Ugliness) does not compile.
RH Linux seems indifferent and accepts either.
* app/commands.c
* app/gdisplay.c
* app/menus.c
* app/plug_in_cmds.c
* app/undo.c
* app/tools/gimppainttool.c
* app/tools/gimptool.c
* app/tools/paint_options.c
* app/tools/tool_manager.c
s|#<remark about extreme buggedness>|
/* #<remark about extreme buggedness> */|
Not all compilers are at peace with non-standard
pre-compiler directives. SGI MIPs compilers are
among the latter species.
2001-03-08 Michael Natterer <mitch@gimp.org>
* app/tools/Makefile.am
* app/tools/gimpellipseselecttool.[ch]
* app/tools/gimprectselecttool.[ch]: new objects based on a (heavily
modified) patch by Dave Neary <dneary@eircom.net>.
* app/tools/gimpfuzzyselecttool.c
* app/tools/gimptool.[ch]
* app/tools/selection_options.c
* app/tools/tools.c: changed accordingly.
2001-03-06 Michael Natterer <mitch@gimp.org>
* app/gimage.[ch]: removed the layer mask functions.
* app/gimpchannel.[ch]: added a boolean "dummy" parameter to
gimp_channel_copy() so it has the same signature as
gimp_layer_copy() and can be used by the GimpDrawableListView to
generically duplicate drawables.
* app/gimpcontainerview.c: call "select_item" with a NULL item
before changing the underlying GimpContainer so subclasses have
a chance to update (e.g. set button sensitivity).
* app/gimpdnd.c: folded all the GtkType comparing code into a
utility function (much more readable now).
* app/gimpdrawablelistview.[ch]: activated the "raise", "lower",
"duplicate" and "delete". I'm not really happy with all those
function pointers passed to the constructor (and the dummy
parameters I've added to some GimpChannel functions) -- OTOH the
generic view maybe worth the "gboolean dummy" cruft hanging around
in the channel class.
* app/gimplayer.[ch]: removed the "apply_mask", "edit_mask" and
"show_mask" booleans ...
* app/gimplayermask.[ch]: .. and added them here together with
proper accessors and "*_changed" signals.
This also makes the layer mask undo code much clearer as we don't
have to store the booleans separately.
* app/gimplayerlistitem.c: badly hacked to acheive the correct
indicator being drawn around the active drawable. This needs
a new GimpPreview function for setting the border color.
* app/gimplistitem.c: smaller horizontal spacing.
* app/gimppreview.[ch]: added the "border_width" parameter also to
gimp_preview_set_size() so we can modify all previews the same way
after creation.
* app/layers_dialog.c: no need to push an undo group around
the "duplicate layer" code. Was this an artefact or did I miss
something here ???
* app/channel_ops.c
* app/channels_dialog.c
* app/gimage_mask.c
* app/gimpcontainergridview.c
* app/gimpcontainerlistview.c
* app/gimpdrawablelistitem.c
* app/gimpimage.[ch]
* app/qmask.c
* app/test_commands.c
* app/undo.c
* app/xcf.c
* app/pdb/channel_cmds.c
* tools/pdbgen/pdb/channel.pdb
* app/pdb/selection_cmds.c
* tools/pdbgen/pdb/selection.pdb: changed accordingly.
* app/pdb/internal_procs.c
* app/pdb/layer_cmds.c
* libgimp/gimplayer_pdb.[ch]
* tools/pdbgen/pdb/layer.pdb: commented out the layer mask accessors
from the perl code, so the functions temporarily disappeared all
over the place.
* plug-ins/Makefile.am: don't build XJT until the layer mask stuff
is back.
* pixmaps/eye.xpm: cropped it to it's minimal size.
2001-03-05 Sven Neumann <sven@gimp.org>
* app/Makefile.am
* app/apptypes.h
* app/gimpimage-undo.[ch]
* app/gimpundo.[ch]
* app/gimpundostack.[ch]: added new GimpUndo and GimpUndoStack objects
which will be used for the upcoming new undo system. Actually my
current plan for the undo system is to keep it pretty much as it is...
* app/gimpimage.[ch]: added new GimpUndoStacks but temporarily kept
old GSLists around, so I don't break everything now.
2001-03-04 Michael Natterer <mitch@gimp.org>
* app/gimpbrushpreview.c
* app/gimpgradientpreview.c
* app/gimppalettepreview.c
* app/gimppatternpreview.c
* app/gimptoolinfopreview.c: removed all dnd code ...
* app/gimppreview.c: ... and put it where is belongs.
* app/gimpcontext.c: use g_type_is_a() instead of comparing the
types directly.
* app/gimpdnd.[ch]: same g_type_is_a() fix here. New function
gimp_dnd_viewable_source_unset().
* app/gimpdrawablelistitem.c: gtk_signal_connect_while_alive() to
GimpDrawable's "visibility_changed" fixes a crash here.
* app/gimplayerlistitem.c: check more strictly if DND reordering
of layers is allowed.
* app/gimplistitem.c: more DND reordering checking.
Start drawing the drop indicator at x = name_label->allocation.x
(looks better IMHO).
2001-03-04 Michael Natterer <mitch@gimp.org>
* app/Makefile.am
* app/apptypes.h
* app/gimplayerlistitem.[ch]: new widget derived from
GimpDrawableListItem (additionally displays the layer mask),
* app/gimplistitem.[ch]: added the preview_size to the struct so
subclasses can create previews at arbitrary times. Removed the
"preview_size" parameter from "set_viewable".
* app/gimpimage.[ch]: removed the layer mask functions because
they belong to GimpLayer.
* app/gimplayer.[ch]: folded the layer mask code from GimpImage
into GimpLayer's layer mask functions. Added a "mask_changed"
signal which is emitted when a mask is added/removed. Added
"push_undo" parameters to the functions so we can use them from
the undo system.
* app/undo.c: instead of badly poking the GimpLayer struct, use
the accessors with push_undo = FALSE.
* app/gimage_mask.c
* app/gimpdrawablelistitem.c
* app/layers_dialog.c
* app/xcf.c
* app/pdb/image_cmds.c
* tools/pdbgen/pdb/image.pdb: changed accordingly.
2001-03-04 Michael Natterer <mitch@gimp.org>
* app/gimpdrawable.[ch]: new function gimp_drawable_set_visible().
Renamed gimp_drawable_visible() to gimp_drawable_get_visible().
Added a "visibility_changed" signal.
* app/gimplistitem.[ch]: new virtual function "set_viewable"
which allows subclasses to connect to the viewable's signals.
* app/gimpdrawablelistitem.[ch]: added an eye button. Implement
"set_viewable" to connect to the "visibility_changed" signal.
* app/gimpchannel.[ch]: removed unused function
gimp_channel_toggle_visibility().
* app/channels_dialog.c
* app/floating_sel.c
* app/gimage_mask.c
* app/gimpimage.c
* app/gimplayer.c
* app/layers_dialog.c
* app/xcf.c
* app/pdb/channel_cmds.c
* app/pdb/layer_cmds.c
* app/pdb/pdb_glue.h
* tools/pdbgen/pdb/channel.pdb
* tools/pdbgen/pdb/layer.pdb: removed direct access of
drawable->visible and use the functions instead. Also makes PDB
code generation nicer.
* pixmaps/eye.xpm: cropped it a bit.
2001-03-04 Sven Neumann <sven@gimp.org>
* app/preferences_dialog.c (prefs_save_callback): applied a patch
from David Odin <David.Odin@bigfoot.com> that fixes a typo in the code.
2001-03-04 Michael Natterer <mitch@gimp.org>
* app/Makefile.am
* app/apptypes.h
* app/gimpdrawablelistitem.[ch]
* app/gimplistitem.[ch]: new widgets capable of reordering
themselves using DND.
* app/gimpcontainerlistview.c: removed stuff which is now done
by the GimpListItem.
* app/gimpdnd.[ch]: new function gimp_dnd_get_drag_data(widget)
which returns a GimpViewable using the widget's drag callback.
* app/gimpdrawablelistview.c: implement GimpContainerView's
"insert_item" method and enable reordering for the created
GimpListItem.
2001-03-03 Michael Natterer <mitch@gimp.org>
* app/appenums.h: renamed ZoomType to GimpZoomZype and added it
here.
* app/commands.c
* app/disp_callbacks.c
* app/nav_window.c
* app/scale.[ch]: changed accordingly.
* app/tools/Makefile.am
* app/tools/magnify.[ch]: back as object.
* app/tools/tool.c: removed the old ToolInfo entry.
* app/tools/tools.c: register it.
2001-03-02 Michael Natterer <mitch@gimp.org>
* app/tools/Makefile.am
* app/tools/gimpselectiontool.[ch]: new files ported by
Dave Neary <dneary@eircom.net>. Changed them a bit to inherit
from GimpDrawTool and added implementations of "modifier_key"
and "oper_update" because they are shared by 4 of the old
selection tools.
2001-03-01 Michael Natterer <mitch@gimp.org>
* app/tools/crop.[ch]: we need to override GimpDrawTool's "draw"
method to actually see something.
* app/channels_dialog.c
* app/layers_dialog.c: fixed the crash introduced by the migration
of gimage->layers and gimage->channels to GimpContainer.
* app/appenums.h
* app/gimplayer.c
* app/layers_dialog.c: When adding a layer mask allow the option
of using the current selection (or it's inverse) to initialise
the mask.
2001-02-28 Michael Natterer <mitch@gimp.org>
* app/gdisplay.c
* app/gimage.c. #include "tools/tool.h"
* app/tools/edit_selection.[ch]: the arrow_key function is not
a method of edit_selection but of any tool that needs it.
* app/tools/gimppaintbrushtool.c: removed variables.
* app/tools/move.c: use the arrow_key function.
* app/tools/tool_manager.h: removed the include of "tool.h"
2001-02-28 Michael Natterer <mitch@gimp.org>
* app/tools/Makefile.am
* app/tools/edit_selection.[ch]: back as real tool which gets
temporarily pushed to the tool_manager's new tool stack.
* app/tools/move.c
* app/tools/text_tool.c: call the edit_selection stuff again.
* app/tools/tool.c: added a STUB().
* app/tools/tool_manager.[ch]: implemented tool_manager_push_tool()
and tool_manager_pop_tool().
Michael Natterer