Commit Graph

29 Commits

Author SHA1 Message Date
Mukund Sivaraman 0a20d9bdbd file-jpeg: Rename misnamed macros 2011-06-10 23:40:23 +05:30
Mukund Sivaraman f3c395f9df file-jpeg: (save) Change default subsampling labels
This was discussed in #gimp. We change the default subsampling
labels to more easily understood ones ones for users of
graphics software.
2011-06-10 23:37:09 +05:30
Mukund Sivaraman f03aef5a5e file-jpeg: (save) Change default restart MCU rows to 16
With a 1x1,1x1,1x1 interleave, this will result in a restart
marker every 128 rows of pixels, which is more suitable for a
default setting.
2011-06-10 23:34:44 +05:30
Mukund Sivaraman 4e0a48fabc file-jpeg: (save) Change the label for restart interval
This was discussed in #gimp. The old label was "Frequency (rows)"
which is misleading. This field is basically converted by libjpeg
to another value called a restart interval which is stored in a
JPEG file. The restart interval specifies after how many MCUs
the restart (syncronization) marker appears in the bitstream.
It is not easy to explain to a layperson what an MCU is.

The value in the dialog specifies after how many *MCU rows* the
restart marker appears. This is a libjpeg thing, and libjpeg
converts it to the restart interval.

I have merely renamed the text label of the field and PDB
description as the current text implies pixel rows which is not
the case.

A better alternative is to use the restart interval (in MCUs,
not MCU rows) as saved in the file itself, which more people
than users of libjpeg would understand. But even that setting
is not something that can easily be explained to a layperson.
2011-06-10 23:33:11 +05:30
Mukund Sivaraman 4b3a1c6680 file-jpeg: (save) Change default coding mode to progressive
This was discussed in #gimp. This would no longer result in strictly
baseline JPEGs, but progressive mode has been supported for about
a decade in browsers and libjpeg now.

Progressive mode brings two advantages: (1) Medium to large images get
decent space savings to due to coding of large sequences of
zero coefficients, and (2) The images load progressively in a browser
which leads to better user experience when viewing medium to large
images on a website.

Those who want strictly baseline have the option to turn it off.
2011-06-10 23:25:05 +05:30
Mukund Sivaraman dd912b1cb9 file-jpeg: (save) Change default compression level to 90
This was discussed in #gimp. 90 is affordable as the default
in these days of large hard disks and broadband.
2011-06-10 23:16:51 +05:30
Mukund Sivaraman 24c88e0fcf file-jpeg: (save) Change default subsampling to best quality
This was discussed in #gimp. There is no reason to have the default
option throw away such image quality in these days of large hard disks
and broadband.
2011-06-10 23:15:43 +05:30
Michael Natterer ab3fe10275 plug-ins: remove some more -Wunused-but-set-variable 2011-05-15 21:12:49 +02:00
Michael Natterer bb6436cb44 libgimp: deprecate and rename the global pararasite functions
just as it was done for items and images. Remove the "parasite" PDB
group completely.
2011-03-08 14:31:04 +01:00
Michael Natterer 87646e9ace libgimp: deprecate and rename the image parasite functions
in exactly the way the drawable functios were turned into item ones.
2011-03-08 13:19:21 +01:00
Mukund Sivaraman b072e75833 file-jpeg: Make cinfo struct static so asynchronous saves don't crash
The plug-in already makes a copy of the cinfo struct for asynchronous
save, but it seems that somewhere inside cinfo, a pointer points to
another region in this struct. So, everything is copied as-is, and
the pointer ends up pointing to somewhere in the save_image() stack
which is gone when that function returns.
2010-10-23 17:23:22 +05:30
Mukund Sivaraman 64ed52144a Update indentation 2010-10-23 00:39:03 +05:30
Mukund Sivaraman 4998863806 file-jpeg: Fix a crash when toggling settings in preview mode
This patch cancels the GSource for background_jpeg_save() and calls it
synchronously to free resources. Without this patch, multiple GSources
for background_jpeg_save() get setup and result in a crash.
2010-10-22 22:23:42 +05:30
Nelson A. de Oliveira 4fea27ec1d Bug 623169 - Memory leaks in GIMP
Add some missing g_free() and free() calls, found by cppcheck.
2010-07-15 21:42:36 +02:00
Michael Natterer c6a2eaa5c4 plug-ins: use new item API instead of deprecated drawable API 2010-07-09 12:27:36 +02:00
Michael Natterer d0fae3d338 Use gtk_adjustment_get_value() instead of adjustment->value 2009-10-09 21:19:09 +02:00
Martin Nordholts 19fe919dce plug-ins: Port file plug-ins to new export API 2009-07-21 16:03:58 +02:00
Michael Natterer e805cb0cf4 Use gtk_dialog_get_content_area() instead of dialog->vbox 2009-07-15 18:57:12 +02:00
Sven Neumann 4fa43f5bfd plug-ins/file-jpeg/jpeg-load.c (load_image) need to finish the progress
2009-03-07  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-jpeg/jpeg-load.c (load_image)
	* plug-ins/file-jpeg/jpeg-save.c (save_image): need to finish 
the
	progress update.


svn path=/trunk/; revision=28118
2009-03-06 23:21:09 +00:00
Michael Natterer d9b5207aa2 Change licence to GPLv3 (and to LGPLv3 for libgimp).
2009-01-17  Michael Natterer  <mitch@gimp.org>

	* all files with a GPL header and all COPYING files:

	Change licence to GPLv3 (and to LGPLv3 for libgimp).

	Cleaned up some copyright headers and regenerated the parsers in
	the ImageMap plugin.


svn path=/trunk/; revision=27913
2009-01-17 22:28:01 +00:00
Sven Neumann 477110a7a3 formatting
svn path=/trunk/; revision=27567
2008-11-06 16:34:02 +00:00
Nils Philippsen 0800b7e3e9 fix memory leak
* plug-ins/file-jpeg/jpeg-save.c: fix memory leak

svn path=/trunk/; revision=27566
2008-11-06 15:56:58 +00:00
Sven Neumann c8375c0113 Bug 559081 – JPEG Save dialog preview should adjust size units
2008-11-03  Sven Neumann  <sven@gimp.org>

	Bug 559081 – JPEG Save dialog preview should adjust size units

	* plug-ins/file-jpeg/jpeg-save.c: use 
g_format_size_for_display()
	to display the JPEG file size.


svn path=/trunk/; revision=27532
2008-11-03 16:39:20 +00:00
Sven Neumann 13110ea95d some cleanups to the subsampling code; in an attempt to fix bug #555031.
2008-10-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-jpeg/jpeg-save.c: some cleanups to the 
subsampling
	code; in an attempt to fix bug #555031.


svn path=/trunk/; revision=27126
2008-10-04 21:12:14 +00:00
Sven Neumann dae9f75a17 plug-ins/file-jpeg/jpeg.[ch] plug-ins/file-jpeg/jpeg-save.[ch] introduced
2008-09-25  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-jpeg/jpeg.[ch]
	* plug-ins/file-jpeg/jpeg-save.[ch]
	* plug-ins/file-jpeg/jpeg-settings.[ch]: introduced an enum for
	the subsampling factor.


svn path=/trunk/; revision=27056
2008-09-25 14:30:02 +00:00
Sven Neumann 9665fee425 Bug 553412 – JPEG sampling factors not set to 1x1 on grayscale images:
2008-09-25  Sven Neumann  <sven@gimp.org>

	Bug 553412 – JPEG sampling factors not set to 1x1 on grayscale
	images:

	* plug-ins/file-jpeg/jpeg-save.c: always set subsampling to 1x1
	for grayscale images and indicate this properly in the UI.


svn path=/trunk/; revision=27055
2008-09-25 14:24:27 +00:00
Martin Nordholts b5b51b475f libgimpwidgets/gimpwidgets.c
2008-08-26  Martin Nordholts  <martinn@svn.gnome.org>

	* libgimpwidgets/gimpwidgets.c

	* plug-ins/common/file-xbm.c
	* plug-ins/common/file-wmf.c
	* plug-ins/common/file-svg.c
	* plug-ins/common/file-gih.c
	* plug-ins/common/blur-motion.c
	* plug-ins/file-jpeg/jpeg-save.c
	* plug-ins/lighting/lighting-ui.c
	* plug-ins/map-object/map-object-ui.c

	* app/tools/gimpsheartool.c
	* app/tools/gimpaligntool.c
	* app/tools/gimprotatetool.c
	* app/tools/gimplevelstool.c
	* app/dialogs/resize-dialog.c
	* app/dialogs/offset-dialog.c
	* app/widgets/gimppaletteeditor.c
	* app/widgets/gimpcolormapeditor.c
	* app/dialogs/layer-options-dialog.c
	* app/display/gimpdisplayshell-scale-dialog.c: Pass page_size = 0
	to gimp_spin_button_new() to adapt to new and correct value
	clamping in GTK+.

svn path=/trunk/; revision=26778
2008-08-26 19:32:14 +00:00
Sven Neumann 5084939673 plug-ins/file-jpeg/jpeg.[ch] plug-ins/file-jpeg/jpeg-load.[ch] pass error
2008-08-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-jpeg/jpeg.[ch]
	* plug-ins/file-jpeg/jpeg-load.[ch]
	* plug-ins/file-jpeg/jpeg-save.[ch]: pass error messages with 
the
	return values instead of calling g_message().


svn path=/trunk/; revision=26670
2008-08-20 07:07:56 +00:00
Michael Natterer 3d75c95f95 plug-ins/bmp/* plug-ins/faxg3/* plug-ins/fits/* plug-ins/fli/*
2008-08-11  Michael Natterer  <mitch@gimp.org>

	* plug-ins/bmp/*
	* plug-ins/faxg3/*
	* plug-ins/fits/*
	* plug-ins/fli/*
	* plug-ins/ico/*
	* plug-ins/jpeg/*
	* plug-ins/psd/*
	* plug-ins/sgi/*
	* plug-ins/uri/*
	* plug-ins/xjt/*: removed these...

	* plug-ins/file-bmp/*
	* plug-ins/file-faxg3/*
	* plug-ins/file-fits/*
	* plug-ins/file-fli/*
	* plug-ins/file-ico/*
	* plug-ins/file-jpeg/*
	* plug-ins/file-psd/*
	* plug-ins/file-sgi/*
	* plug-ins/file-uri/*
	* plug-ins/file-xjt/*: and moved them here. Changed executable
	names to "file-foo".

	* plug-ins/Makefile.am: changed accordingly.

	* plug-ins/common/*: rename all file plug-ins to file-foo.c. Get
	rid of the names "poppler" and "postscript" and call them
	"file-pdf" and "file-ps" because the conflict with standard
	autofoo targets is gone.

	* plug-ins/common/plugin-defs.pl: changed accordingly.

	* plug-ins/common/mkgen.pl: make sure cflags variables are named
	"PLUG_IN_NAME_CFLAGS" and not "PLUG-IN-NAME_CFLAGS"

	* plug-ins/common/Makefile.am: regenerated.

	* configure.in: change folders and variable names to match above
	changes.


svn path=/trunk/; revision=26494
2008-08-11 10:06:13 +00:00