From fef971fa8d8028a86e9afb0a3ecd4c7552551da9 Mon Sep 17 00:00:00 2001 From: bootchk Date: Mon, 22 Apr 2024 15:32:34 -0400 Subject: [PATCH] GUI: Rename menu Filters>Development>Goat exercises => Plug-in Examples The old menu label was confusing to users. Remove translatable strings having joke "goat" so translators not confused. Move the goat plugins to the menu. The items under the menu should all be example plugins. The menu is in a release. Test plugins should not be in this menu. Test plugins should not ship in a stable release. !!! Note that 2.10 does not ship with example plugins. If we don't want 3.0 to ship stable build with example plugins, then the meson.build for goat-exercises needs to change and the menu removed entirely in menus/image-menu.ui.in.in. --- extensions/goat-exercises/goat-exercise-c.c | 10 +++++----- extensions/goat-exercises/goat-exercise-gjs.js | 10 +++++----- extensions/goat-exercises/goat-exercise-lua.lua | 10 +++++----- extensions/goat-exercises/goat-exercise-py3.py | 10 +++++----- extensions/goat-exercises/goat-exercise-vala.vala | 10 +++++----- menus/image-menu.ui.in.in | 2 +- 6 files changed, 26 insertions(+), 26 deletions(-) diff --git a/extensions/goat-exercises/goat-exercise-c.c b/extensions/goat-exercises/goat-exercise-c.c index d80f33c734..5061456f62 100644 --- a/extensions/goat-exercises/goat-exercise-c.c +++ b/extensions/goat-exercises/goat-exercise-c.c @@ -111,14 +111,14 @@ goat_create_procedure (GimpPlugIn *plug_in, gimp_procedure_set_sensitivity_mask (procedure, GIMP_PROCEDURE_SENSITIVE_DRAWABLE); - gimp_procedure_set_menu_label (procedure, _("Exercise in _C minor")); + gimp_procedure_set_menu_label (procedure, _("In _C")); gimp_procedure_set_icon_name (procedure, GIMP_ICON_GEGL); gimp_procedure_add_menu_path (procedure, - "/Filters/Development/Goat exercises/"); + "/Filters/Development/Plug-in Examples/"); gimp_procedure_set_documentation (procedure, - _("Exercise a goat in the C language"), - "Takes a goat for a walk", + _("Plug-in example in C"), + _("Plug-in example in C"), PLUG_IN_PROC); gimp_procedure_set_attribution (procedure, "Øyvind Kolås ", @@ -177,7 +177,7 @@ goat_run (GimpProcedure *procedure, gint response; gimp_ui_init (PLUG_IN_BINARY); - dialog = gimp_dialog_new (_("Exercise a goat (C)"), PLUG_IN_ROLE, + dialog = gimp_dialog_new (_("Plug-in Example in C"), PLUG_IN_ROLE, NULL, GTK_DIALOG_USE_HEADER_BAR, gimp_standard_help_func, PLUG_IN_PROC, diff --git a/extensions/goat-exercises/goat-exercise-gjs.js b/extensions/goat-exercises/goat-exercise-gjs.js index d7f18c8151..7dc9256373 100755 --- a/extensions/goat-exercises/goat-exercise-gjs.js +++ b/extensions/goat-exercises/goat-exercise-gjs.js @@ -60,12 +60,12 @@ var Goat = GObject.registerClass({ procedure.set_image_types("*"); procedure.set_sensitivity_mask(Gimp.ProcedureSensitivityMask.DRAWABLE); - procedure.set_menu_label(_("Exercise a JavaScript goat")); + procedure.set_menu_label(_("In _JavaScript")); procedure.set_icon_name(GimpUi.ICON_GEGL); - procedure.add_menu_path ('/Filters/Development/Goat exercises/'); + procedure.add_menu_path ('/Filters/Development/Plug-in Examples/'); - procedure.set_documentation(_("Exercise a goat in the JavaScript language (GJS)"), - _("Takes a goat for a walk in Javascript with the GJS interpreter"), + procedure.set_documentation(_("Plug-in example in JavaScript (GJS)"), + _("Plug-in example in JavaScript (GJS)"), name); procedure.set_attribution("Jehan", "Jehan", "2019"); @@ -87,7 +87,7 @@ var Goat = GObject.registerClass({ GimpUi.init("goat-exercise-gjs"); /* TODO: help function and ID. */ let dialog = new GimpUi.Dialog({ - title: _("Exercise a goat (JavaScript)"), + title: _("Plug-in Example in JavaScript (GJS)"), role: "goat-exercise-JavaScript", use_header_bar: true, }); diff --git a/extensions/goat-exercises/goat-exercise-lua.lua b/extensions/goat-exercises/goat-exercise-lua.lua index da96d1f025..d0ec0a5c7c 100755 --- a/extensions/goat-exercises/goat-exercise-lua.lua +++ b/extensions/goat-exercises/goat-exercise-lua.lua @@ -64,7 +64,7 @@ function run(procedure, run_mode, image, drawables, config, run_data) if run_mode == "INTERACTIVE" then GimpUi.init("goat-exercise-lua"); local dialog = GimpUi.Dialog { - title = _("Exercise a goat (Lua)"), + title = _("Plug-in Example in Lua"), role = "goat-exercise-Lua", use_header_bar = 1 } @@ -169,12 +169,12 @@ function Goat.Exercise:do_create_procedure(name) procedure:set_image_types("*"); procedure:set_sensitivity_mask(Gimp.ProcedureSensitivityMask.DRAWABLE); - procedure:set_menu_label(_("Exercise a Lua goat")); + procedure:set_menu_label(_("In _Lua")); procedure:set_icon_name(GimpUi.ICON_GEGL); - procedure:add_menu_path('/Filters/Development/Goat exercises/'); + procedure:add_menu_path('/Filters/Development/Plug-in Examples/'); - procedure:set_documentation(_("Exercise a goat in the Lua language"), - "Takes a goat for a walk in Lua", + procedure:set_documentation(_("Plug-in example in Lua"), + _("Plug-in example in Lua"), name); procedure:set_attribution("Jehan", "Jehan", "2019"); diff --git a/extensions/goat-exercises/goat-exercise-py3.py b/extensions/goat-exercises/goat-exercise-py3.py index 2674831f1c..9c351a3c3d 100755 --- a/extensions/goat-exercises/goat-exercise-py3.py +++ b/extensions/goat-exercises/goat-exercise-py3.py @@ -43,12 +43,12 @@ class Goat (Gimp.PlugIn): procedure.set_image_types("*") procedure.set_sensitivity_mask (Gimp.ProcedureSensitivityMask.DRAWABLE) - procedure.set_menu_label(_("Exercise a goat and a python")) + procedure.set_menu_label(_("In _Python")) procedure.set_icon_name(GimpUi.ICON_GEGL) - procedure.add_menu_path('/Filters/Development/Goat exercises/') + procedure.add_menu_path('/Filters/Development/Plug-in Examples/') - procedure.set_documentation(_("Exercise a goat in the Python 3 language"), - _("Takes a goat for a walk in Python 3"), + procedure.set_documentation(_("Plug-in example in Python 3"), + _("Plug-in example in Python 3"), name) procedure.set_attribution("Jehan", "Jehan", "2019") @@ -71,7 +71,7 @@ class Goat (Gimp.PlugIn): GimpUi.init("goat-exercise-py3.py") dialog = GimpUi.Dialog(use_header_bar=True, - title=_("Exercise a goat (Python 3)"), + title=_("Plug-in Example in Python 3"), role="goat-exercise-Python3") dialog.add_button(_("_Cancel"), Gtk.ResponseType.CANCEL) diff --git a/extensions/goat-exercises/goat-exercise-vala.vala b/extensions/goat-exercises/goat-exercise-vala.vala index 6b0348a81f..62886899b8 100755 --- a/extensions/goat-exercises/goat-exercise-vala.vala +++ b/extensions/goat-exercises/goat-exercise-vala.vala @@ -42,11 +42,11 @@ public class Goat : Gimp.PlugIn { var procedure = new Gimp.ImageProcedure(this, name, Gimp.PDBProcType.PLUGIN, this.run); procedure.set_image_types("RGB*, INDEXED*, GRAY*"); procedure.set_sensitivity_mask(Gimp.ProcedureSensitivityMask.DRAWABLE); - procedure.set_menu_label(_("Exercise a Vala goat")); - procedure.set_documentation(_("Exercise a goat in the Vala language"), - _("Takes a goat for a walk in Vala"), + procedure.set_menu_label(_("In _Vala")); + procedure.set_documentation(_("Plug-in example in Vala"), + _("Plug-in example in Vala"), PLUG_IN_PROC); - procedure.add_menu_path("/Filters/Development/Goat exercises/"); + procedure.add_menu_path("/Filters/Development/Plug-in Examples/"); procedure.set_attribution("Niels De Graef", "Niels De Graef", "2020"); procedure.set_icon_name(GimpUi.ICON_GEGL); @@ -64,7 +64,7 @@ public class Goat : Gimp.PlugIn { GimpUi.init(PLUG_IN_BINARY); var dialog = - new GimpUi.Dialog(_("Exercise a goat (Vala)"), + new GimpUi.Dialog(_("Plug-in Example in Vala"), PLUG_IN_ROLE, null, Gtk.DialogFlags.USE_HEADER_BAR, diff --git a/menus/image-menu.ui.in.in b/menus/image-menu.ui.in.in index 747726bfed..094e2be3df 100644 --- a/menus/image-menu.ui.in.in +++ b/menus/image-menu.ui.in.in @@ -843,7 +843,7 @@ De_velopment - _Goat exercises + Plug-in _Examples _Python-Fu