From dda65d85c388adfa2a3a8aada1e717f18dde0f33 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Sat, 3 Apr 2021 11:40:22 +0100 Subject: [PATCH] app: Don't second-guess the dependency system Removing this check makes the treatment of LittleCMS consistent with all the other dependencies checked in the same file, which only check that the runtime version is at least the required version. As long as we were compiled against LittleCMS >= 2.8, and are now running against a version that has at least the same symbols, it doesn't necessarily matter whether the version we are running against is the same one we were compiled against. Distributions like Debian and Ubuntu track the versions in which individual symbols were introduced, which allows runtime dependencies to be weakened when no newer symbols are actually used; this is practically necessary when working with very large numbers of packages, to avoid a new version of a dependency library unnecessarily blocking upgrade of dependent packages. However, this doesn't work if dependent packages add their own checks that bypass this mechanism. Signed-off-by: Simon McVittie --- app/sanity.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/app/sanity.c b/app/sanity.c index 694108983e..bca0d7f010 100644 --- a/app/sanity.c +++ b/app/sanity.c @@ -391,22 +391,6 @@ sanity_check_lcms (void) gint lcms_version = cmsGetEncodedCMMversion (); - if (LCMS_VERSION > lcms_version) - { - return g_strdup_printf - ("Liblcms2 version mismatch!\n\n" - "GIMP was compiled against LittleCMS version %d.%d, but the\n" - "LittleCMS version found at runtime is only %d.%d.\n\n" - "Somehow you or your software packager managed\n" - "to install a LittleCMS that is older than what GIMP was\n" - "built against.\n\n" - "Please make sure that the installed LittleCMS version\n" - "is at least %d.%d and that headers and library match.", - LCMS_VERSION / 1000, LCMS_VERSION % 1000 / 10, - lcms_version / 1000, lcms_version % 1000 / 10, - LCMS_VERSION / 1000, LCMS_VERSION % 1000 / 10); - } - if (lcms_version < (LCMS_REQUIRED_MAJOR * 1000 + LCMS_REQUIRED_MINOR * 10)) {