dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libgimp: add G_GNUC_WARN_UNUSED_RESULT to several functions. 

Functions creating a new GeglBuffer should trigger a warning if the
result if unused, because this is potentially a big memory leak.

Similarly objects created by functions creating new layers should be
handled (usually by adding the layer to the image with
gimp_image_insert_layer()), because they also come with a buffer and
possibly quite some important memory leak.
This commit is contained in:
Jehan 2024-07-07 22:39:13 +02:00
parent ebc4f9afab
commit dac11f11aa
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libgimp/gimpdrawable.h
View File

@ -56,8 +56,8 @@ struct _GimpDrawableClass
GimpDrawable * gimp_drawable_get_by_id (gint32 drawable_id);
GeglBuffer * gimp_drawable_get_buffer (GimpDrawable *drawable);
GeglBuffer * gimp_drawable_get_shadow_buffer (GimpDrawable *drawable);
GeglBuffer * gimp_drawable_get_buffer (GimpDrawable *drawable) G_GNUC_WARN_UNUSED_RESULT;
GeglBuffer * gimp_drawable_get_shadow_buffer (GimpDrawable *drawable) G_GNUC_WARN_UNUSED_RESULT;
const Babl * gimp_drawable_get_format (GimpDrawable *drawable);
const Babl * gimp_drawable_get_thumbnail_format (GimpDrawable *drawable);

2
libgimp/gimpgrouplayer.h
View File

@ -41,7 +41,7 @@ G_DECLARE_FINAL_TYPE (GimpGroupLayer, gimp_group_layer, GIMP, GROUP_LAYER, GimpL
GimpGroupLayer * gimp_group_layer_get_by_id (gint32 layer_id);
GimpGroupLayer * gimp_group_layer_new (GimpImage *image,
const gchar *name);
const gchar *name) G_GNUC_WARN_UNUSED_RESULT;
G_END_DECLS

6
libgimp/gimplayer.h
View File

@ -63,7 +63,7 @@ GimpLayer * gimp_layer_new (GimpImage *image,
gint height,
GimpImageType type,
gdouble opacity,
GimpLayerMode mode);
GimpLayerMode mode) G_GNUC_WARN_UNUSED_RESULT;
GimpLayer * gimp_layer_new_from_pixbuf (GimpImage *image,
const gchar *name,
@ -71,12 +71,12 @@ GimpLayer * gimp_layer_new_from_pixbuf (GimpImage *image,
gdouble opacity,
GimpLayerMode mode,
gdouble progress_start,
gdouble progress_end);
gdouble progress_end) G_GNUC_WARN_UNUSED_RESULT;
GimpLayer * gimp_layer_new_from_surface (GimpImage *image,
const gchar *name,
cairo_surface_t *surface,
gdouble progress_start,
gdouble progress_end);
gdouble progress_end) G_GNUC_WARN_UNUSED_RESULT;
GimpLayer * gimp_layer_copy (GimpLayer *layer);

2
libgimp/gimptextlayer.h
View File

@ -44,7 +44,7 @@ GimpTextLayer * gimp_text_layer_new (GimpImage *image,
const gchar *text,
GimpFont *font,
gdouble size,
GimpUnit unit);
GimpUnit unit) G_GNUC_WARN_UNUSED_RESULT;
G_END_DECLS