dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #7115: properly chaining up finalize() methods. 

Thanks to Massimo Valentini for finding these.
Fixes:

> GLib-GObject-CRITICAL **: 13:21:53.256: Object 0x5485140 of type GimpLineArt not finalized correctly.
> GLib-GObject-CRITICAL **: 13:21:57.472: Object 0x231f520 of type GimpExtension not finalized correctly.

Outputted when glib is built with -Dglib_debug=enabled and GIMP is run
with GOBJECT_DEBUG=objects.
This commit is contained in:
Jehan 2021-08-04 01:59:41 +02:00
parent 0a83a45732
commit cc57860837
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/core/gimpextension.c
View File

@ -165,6 +165,8 @@ gimp_extension_finalize (GObject *object)
g_free (extension->p->path);
if (extension->p->app)
g_object_unref (extension->p->app);
G_OBJECT_CLASS (parent_class)->finalize (object);
}
static void

4
app/core/gimplineart.c
View File

@ -306,6 +306,8 @@ static void gimp_edgelset_next8 (const GeglBuffer *buffer,
G_DEFINE_TYPE_WITH_CODE (GimpLineArt, gimp_line_art, GIMP_TYPE_OBJECT,
G_ADD_PRIVATE (GimpLineArt))
#define parent_class gimp_line_art_parent_class
static guint gimp_line_art_signals[LAST_SIGNAL] = { 0 };
static void
@ -382,6 +384,8 @@ gimp_line_art_finalize (GObject *object)
line_art->priv->frozen = FALSE;
gimp_line_art_set_input (line_art, NULL);
G_OBJECT_CLASS (parent_class)->finalize (object);
}
static void