dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert back to unsigned chars for the buffer, and only cast to gchar if we 

2006-05-05  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/gifload.c (DoExtension): Revert back to unsigned
        chars for the buffer, and only cast to gchar if we know we're dealing
        with a comment. Fixes bug #339865.
This commit is contained in:
Manish Singh 2006-05-06 05:32:39 +00:00 committed by Manish Singh
parent 2499c09161
commit 70eeb8ce7c
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2006-05-05 Manish Singh <yosh@gimp.org>
* plug-ins/common/gifload.c (DoExtension): Revert back to unsigned
chars for the buffer, and only cast to gchar if we know we're dealing
with a comment. Fixes bug #339865.
2006-05-05 Michael Natterer <mitch@gimp.org>
* app/plug-in/gimppluginmanager-call.[ch]

10
plug-ins/common/gifload.c
View File

@ -496,8 +496,8 @@ static int
DoExtension (FILE *fd,
int label)
{
static gchar buf[256];
gchar *str;
static guchar buf[256];
gchar *str;
switch (label)
{
@ -536,7 +536,9 @@ DoExtension (FILE *fd,
str = "Comment Extension";
while (GetDataBlock (fd, (unsigned char *) buf) > 0)
{
if (!g_utf8_validate (buf, -1, NULL))
gchar *comment = (gchar *) buf;
if (!g_utf8_validate (comment, -1, NULL))
continue;
if (comment_parasite)
@ -544,7 +546,7 @@ DoExtension (FILE *fd,
comment_parasite = gimp_parasite_new ("gimp-comment",
GIMP_PARASITE_PERSISTENT,
strlen (buf) + 1, buf);
strlen (comment) + 1, comment);
}
return TRUE;
break;