dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

app: check the time before last selection draw before queuing a redraw. 

This way, we would queue a lot less canvas region unnecessary redraws.
We still remake the time-before-last-draw check in the draw() signal
handling before we want to update the marching ants index for draw
events coming for other reasons (canvas updates, moving/zooming on
canvas, exposition changes, etc.).
This commit is contained in:
Jehan 2021-05-09 15:51:20 +02:00
parent e8a531e51e
commit 6466d46052
1 changed files with 24 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
app/display/gimpdisplayshell-selection.c
View File

@ -229,7 +229,7 @@ selection_start (Selection *selection)
selection_stop (selection);
/* If this selection is paused, do not start it */
if (selection->paused == 0)
if (selection->paused == 0 && selection->timeout == 0)
{
selection->timeout = g_idle_add ((GSourceFunc) selection_start_timeout,
selection);
@ -441,28 +441,38 @@ selection_free_segs (Selection *selection)
static gboolean
selection_start_timeout (Selection *selection)
{
selection->timeout = 0;
/* Draw the ants */
if (gimp_display_get_image (selection->shell->display) &&
selection->show_selection)
{
GdkWindow *window;
cairo_rectangle_int_t rect;
cairo_region_t *region;
GimpDisplayConfig *config = selection->shell->display->config;
gint64 time = g_get_monotonic_time ();
window = gtk_widget_get_window (GTK_WIDGET (selection->shell));
if ((time - selection->shell->selection_update) / 1000 > config->marching_ants_speed)
{
GdkWindow *window;
cairo_rectangle_int_t rect;
cairo_region_t *region;
rect.x = 0;
rect.y = 0;
rect.width = gdk_window_get_width (window);
rect.height = gdk_window_get_height (window);
window = gtk_widget_get_window (GTK_WIDGET (selection->shell));
region = cairo_region_create_rectangle (&rect);
gtk_widget_queue_draw_region (GTK_WIDGET (selection->shell), region);
cairo_region_destroy (region);
rect.x = 0;
rect.y = 0;
rect.width = gdk_window_get_width (window);
rect.height = gdk_window_get_height (window);
region = cairo_region_create_rectangle (&rect);
gtk_widget_queue_draw_region (GTK_WIDGET (selection->shell), region);
cairo_region_destroy (region);
}
else
{
return G_SOURCE_CONTINUE;
}
}
selection->timeout = 0;
return G_SOURCE_REMOVE;
}