From 5a8eb56643cf5d00fbb8e5273c484d39dcdf0de4 Mon Sep 17 00:00:00 2001 From: Sven Neumann Date: Mon, 13 Sep 1999 11:03:37 +0000 Subject: [PATCH] bug-fixing... --Sven --- ChangeLog | 7 +++++++ app/brush_select.c | 2 +- app/gui/brush-select.c | 2 +- plug-ins/common/curve_bend.c | 21 +++------------------ 4 files changed, 12 insertions(+), 20 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5450f986c1..aad29b810c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Mon Sep 13 12:58:56 MEST 1999 Sven Neumann + + * app/brush_select.c: corrected scrolling in the Brushes Dialog. + Fixes bug #2146. + + * plug-ins/common/curve_bend.c: applied a path from Wolfgang Hofer that fixes wrong parameters in PDB calls. + Mon Sep 13 01:50:29 BST 1999 Nick Lamb * plug-ins/common/png.c: Update info structure after applying diff --git a/app/brush_select.c b/app/brush_select.c index 14b7081b25..7133224916 100644 --- a/app/brush_select.c +++ b/app/brush_select.c @@ -917,7 +917,7 @@ display_brush (BrushSelectP bsp, ystart = BOUNDS (offset_y, 0, bsp->preview->allocation.height); yend = BOUNDS (offset_y + height, 0, bsp->preview->allocation.height); - mask = temp_buf_data (mask_buf) + (ystart - offset_y) * mask_buf->width * 3; + mask = temp_buf_data (mask_buf) + (ystart - offset_y) * mask_buf->width; buf = g_new (guchar, 3 * bsp->cell_width); if (GIMP_IS_BRUSH_PIXMAP (brush)) diff --git a/app/gui/brush-select.c b/app/gui/brush-select.c index 14b7081b25..7133224916 100644 --- a/app/gui/brush-select.c +++ b/app/gui/brush-select.c @@ -917,7 +917,7 @@ display_brush (BrushSelectP bsp, ystart = BOUNDS (offset_y, 0, bsp->preview->allocation.height); yend = BOUNDS (offset_y + height, 0, bsp->preview->allocation.height); - mask = temp_buf_data (mask_buf) + (ystart - offset_y) * mask_buf->width * 3; + mask = temp_buf_data (mask_buf) + (ystart - offset_y) * mask_buf->width; buf = g_new (guchar, 3 * bsp->cell_width); if (GIMP_IS_BRUSH_PIXMAP (brush)) diff --git a/plug-ins/common/curve_bend.c b/plug-ins/common/curve_bend.c index d5bcaa0c80..f71b1ec8c3 100644 --- a/plug-ins/common/curve_bend.c +++ b/plug-ins/common/curve_bend.c @@ -1,4 +1,4 @@ -/* curve_bend plugin for the GIMP (tested with GIMP 1.0.4 upto GIMP 1.1.4, requires gtk+ 1.2) */ +/* curve_bend plugin for the GIMP (tested with GIMP 1.1.9, requires gtk+ 1.2) */ /* The GIMP -- an image manipulation program * Copyright (C) 1995 Spencer Kimball and Peter Mattis @@ -19,6 +19,7 @@ */ /* Revision history + * (1999/09/13) v1.01 hof: PDB-calls updated for gimp 1.1.9 * (1999/05/10) v1.0 hof: first public release * (1999/04/23) v0.0 hof: coding started, * splines and dialog parts are similar to curves.c @@ -48,7 +49,7 @@ /* Defines */ #define PLUG_IN_NAME "plug_in_curve_bend" #define PLUG_IN_PRINT_NAME "CurveBend" -#define PLUG_IN_VERSION "v1.0 (1999/05/08)" +#define PLUG_IN_VERSION "v1.01 (1999/09/13)" #define PLUG_IN_MENU_PATH "/Filters/Distorts/CurveBend" #define PLUG_IN_IMAGE_TYPES "RGB*, GRAY*" #define PLUG_IN_AUTHOR "Wolfgang Hofer (hof@hotbot.com)" @@ -481,8 +482,6 @@ gint p_gimp_rotate(gint32 image_id, gint32 drawable_id, gint32 interpolation, gd l_nparams = p_pdb_procedure_available(l_rotate_proc); if (l_nparams >= 0) { - if (l_nparams == 3) - { /* use the new Interface (Gimp 1.1 style) * (1.1 knows the image_id where the drawable belongs to) */ @@ -492,18 +491,6 @@ gint p_gimp_rotate(gint32 image_id, gint32 drawable_id, gint32 interpolation, gd PARAM_INT32, interpolation, PARAM_FLOAT, l_angle_rad, PARAM_END); - } - else - { - /* use the old Interface (Gimp 1.0.2 style) */ - return_vals = gimp_run_procedure (l_rotate_proc, - &nreturn_vals, - PARAM_IMAGE, image_id, - PARAM_DRAWABLE, drawable_id, - PARAM_INT32, interpolation, - PARAM_FLOAT, l_angle_rad, - PARAM_END); - } if (return_vals[0].data.d_status == STATUS_SUCCESS) { l_rc = 0; @@ -539,7 +526,6 @@ gint32 p_gimp_edit_copy(gint32 image_id, gint32 drawable_id) { return_vals = gimp_run_procedure (l_procname, &nreturn_vals, - PARAM_IMAGE, image_id, PARAM_DRAWABLE, drawable_id, PARAM_END); @@ -571,7 +557,6 @@ gint32 p_gimp_edit_paste(gint32 image_id, gint32 drawable_id, gint32 paste_into { return_vals = gimp_run_procedure (l_procname, &nreturn_vals, - PARAM_IMAGE, image_id, PARAM_DRAWABLE, drawable_id, PARAM_INT32, paste_into, PARAM_END);