dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libgimpbase: do not use g_snprintf() with same source and buffer. 

`man snprintf` clearly says (in NOTES) that when source and target
overlap, the result in undefined.

g_snprintf() conforms to the same standard hence would not get the
expected result. In my case, the result was just tzstr (e.g. "+01:00").
This commit is contained in:
Jehan 2020-11-14 21:11:33 +01:00
parent 74eb2b1f8a
commit 435d5ce83a
1 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
libgimpbase/gimpmetadata.c
View File

@ -285,21 +285,22 @@ void
gimp_metadata_add_xmp_history (GimpMetadata *metadata,
gchar *state_status)
{
time_t now;
struct tm* now_tm;
char timestr[256];
char tzstr[7];
gchar iid_data[256];
gchar strdata[1024];
gchar tagstr[1024];
gchar *uuid;
gchar *did;
gchar *odid;
gint id_count;
gint found;
gint lastfound;
gint count;
int ii;
time_t now;
struct tm *now_tm;
gchar *tmp;
char timestr[256];
char tzstr[7];
gchar iid_data[256];
gchar strdata[1024];
gchar tagstr[1024];
gchar *uuid;
gchar *did;
gchar *odid;
gint id_count;
gint found;
gint lastfound;
gint count;
int ii;
static const gchar *tags[] =
{
@ -436,11 +437,10 @@ gimp_metadata_add_xmp_history (GimpMetadata *metadata,
/* get current time and timezone string */
strftime (timestr, 256, "%Y-%m-%dT%H:%M:%S", now_tm);
g_snprintf (timestr, sizeof (timestr), "%s%s",
timestr, tzstr);
tmp = g_strdup_printf ("%s%s", timestr, tzstr);
gexiv2_metadata_set_tag_string (GEXIV2_METADATA (metadata),
tagstr, timestr);
tagstr, tmp);
g_free (tmp);
memset (tagstr, 0, sizeof (tagstr));
memset (strdata, 0, sizeof (strdata));