dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libgimpconfig: remove more g_assert(). 

As discussed with mitch on IRC, these asserts make no sense. They can
happen if we fail to parse user-side data. Also currently deserialize()
does not even pass the GError down so we would always assert on failed
parsing.

What must be done instead if change the signature of deserialize() and
all its implementations, with a GError arg. Then this GError will
properly bubble up to the caller for appropriate handling.
This commit is contained in:
Jehan 2022-02-10 21:25:03 +01:00
parent 7131c220a8
commit 40bebec273
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libgimpconfig/gimpconfig-iface.c
View File

@ -539,9 +539,6 @@ gimp_config_deserialize_stream (GimpConfig *config,
gimp_scanner_unref (scanner);
if (! success)
g_assert (error == NULL || *error != NULL);
return success;
}
@ -586,9 +583,6 @@ gimp_config_deserialize_string (GimpConfig *config,
gimp_scanner_unref (scanner);
if (! success)
g_assert (error == NULL || *error != NULL);
return success;
}