dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add GimpContainer::add() implementation, it's needed after all even though 

2008-10-11  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpdrawablestack.c: add GimpContainer::add()
	implementation, it's needed after all even though everybody uses
	gimp_container_insert() on drawable stacks.

	(gimp_drawable_stack_remove_node): no need to have a special check
	for newly added nodes, this can't happen any more now that we have
	an add() impl.

	(gimp_drawable_stack_get_graph): free the reverse list.


svn path=/trunk/; revision=27228
This commit is contained in:
Michael Natterer 2008-10-11 10:18:46 +00:00 committed by Michael Natterer
parent 26de288d8b
commit 302bda6c66
2 changed files with 30 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ChangeLog
View File

@ -1,3 +1,15 @@
2008-10-11 Michael Natterer <mitch@gimp.org>
* app/core/gimpdrawablestack.c: add GimpContainer::add()
implementation, it's needed after all even though everybody uses
gimp_container_insert() on drawable stacks.
(gimp_drawable_stack_remove_node): no need to have a special check
for newly added nodes, this can't happen any more now that we have
an add() impl.
(gimp_drawable_stack_get_graph): free the reverse list.
2008-10-11 Michael Natterer <mitch@gimp.org>
Fix old bug in the GimpContainer implementation that wasn't

23
app/core/gimpdrawablestack.c
View File

@ -46,6 +46,8 @@ GeglNode * gegl_node_remove_child (GeglNode *self,
static void gimp_drawable_stack_finalize (GObject *object);
static void gimp_drawable_stack_add (GimpContainer *container,
GimpObject *object);
static void gimp_drawable_stack_remove (GimpContainer *container,
GimpObject *object);
static void gimp_drawable_stack_reorder (GimpContainer *container,
@ -71,6 +73,7 @@ gimp_drawable_stack_class_init (GimpDrawableStackClass *klass)
object_class->finalize = gimp_drawable_stack_finalize;
container_class->add = gimp_drawable_stack_add;
container_class->remove = gimp_drawable_stack_remove;
container_class->reorder = gimp_drawable_stack_reorder;
}
@ -94,6 +97,18 @@ gimp_drawable_stack_finalize (GObject *object)
G_OBJECT_CLASS (parent_class)->finalize (object);
}
static void
gimp_drawable_stack_add (GimpContainer *container,
GimpObject *object)
{
GimpDrawableStack *stack = GIMP_DRAWABLE_STACK (container);
GIMP_CONTAINER_CLASS (parent_class)->add (container, object);
if (stack->graph)
gimp_drawable_stack_add_node (stack, GIMP_DRAWABLE (object));
}
static void
gimp_drawable_stack_remove (GimpContainer *container,
GimpObject *object)
@ -181,6 +196,8 @@ gimp_drawable_stack_get_graph (GimpDrawableStack *stack)
previous = node;
}
g_list_free (reverse_list);
output = gegl_node_get_output_proxy (stack->graph, "output");
if (previous)
@ -245,11 +262,7 @@ gimp_drawable_stack_remove_node (GimpDrawableStack *stack,
GeglNode *node;
gint index;
node = gimp_drawable_get_node (GIMP_DRAWABLE (drawable));
/* bail out if the layer was newly added */
if (! gegl_node_get_consumers (node, "output", NULL, NULL))
return;
node = gimp_drawable_get_node (drawable);
index = gimp_container_get_child_index (GIMP_CONTAINER (stack),
GIMP_OBJECT (drawable));