don't bail out successfully after the first test, don't bail out

2006-11-08  Simon Budig  <simon@gimp.org>

	* tools/defcheck.py: don't bail out successfully after the first test,
	don't bail out prematurely on a failed test and actually spot double
	symbols in .def-files if they follow immediately each other...
This commit is contained in:
Simon Budig 2006-11-08 22:47:44 +00:00 committed by Simon Budig
parent f7513e5a80
commit 2f5c6f7b8b
2 changed files with 11 additions and 3 deletions

View File

@ -1,3 +1,9 @@
2006-11-08 Simon Budig <simon@gimp.org>
* tools/defcheck.py: don't bail out successfully after the first test,
don't bail out prematurely on a failed test and actually spot double
symbols in .def-files if they follow immediately each other...
2006-11-08 Sven Neumann <sven@gimp.org>
* tools/Makefile.am (EXTRA_DIST): added defcheck.py.

View File

@ -41,6 +41,8 @@ def_files = (
"libgimpwidgets/gimpwidgets.def"
)
have_errors = 0
for df in def_files:
directory, rest = df.split ("/")
basename, extension = rest.split (".")
@ -55,7 +57,7 @@ for df in def_files:
doublesymbols = []
for i in range (len (defsymbols)-1, 0, -1):
if defsymbols[i] in defsymbols[:i-1]:
if defsymbols[i] in defsymbols[:i]:
doublesymbols.append ((defsymbols[i], i+2))
unsortindex = -1
@ -104,6 +106,6 @@ for df in def_files:
print " the .def-file is not properly sorted (line %d)" % (unsortindex + 2)
print
sys.exit (1)
have_errors = -1
sys.exit (0)
sys.exit (have_errors)