dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

it's a bad idea to access an array before checking if it's long enough. 

2006-08-09  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/plug-in-params.c (plug_in_params_to_args): it's a
	bad idea to access an array before checking if it's long enough.
	Fixes bug #350555. Also added some comments, the logic here is
	really weird.
This commit is contained in:
Michael Natterer 2006-08-09 21:22:50 +00:00 committed by Michael Natterer
parent 9d76a1734f
commit 262fce4dc2
2 changed files with 27 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
2006-08-09 Michael Natterer <mitch@gimp.org>
* app/plug-in/plug-in-params.c (plug_in_params_to_args): it's a
bad idea to access an array before checking if it's long enough.
Fixes bug #350555. Also added some comments, the logic here is
really weird.
2006-08-09 Sven Neumann <sven@gimp.org>
* libgimpcolor/gimprgb.c

27
app/plug-in/plug-in-params.c
View File

@ -57,22 +57,35 @@ plug_in_params_to_args (GParamSpec **pspecs,
GType type;
gint count;
/* first get the fallback compat GType that matches the pdb type */
type = gimp_pdb_compat_arg_type_to_gtype (params[i].type);
/* then try to try to be more specific by looking at the param
* spec (return values have one additional value (the status),
* skip that, it's not in the array of param specs)
*/
if (i > 0 || ! return_values)
{
gint pspec_index = i;
GimpPDBArgType pspec_arg_type;
gint pspec_index = i;
if (return_values)
pspec_index--;
pspec_arg_type = gimp_pdb_compat_arg_type_from_gtype
(G_PARAM_SPEC_VALUE_TYPE (pspecs[pspec_index]));
if (pspec_index < n_pspecs && pspec_arg_type == params[i].type)
/* are there param specs left? */
if (pspec_index < n_pspecs)
{
type = G_PARAM_SPEC_VALUE_TYPE (pspecs[pspec_index]);
GimpPDBArgType pspec_arg_type;
pspec_arg_type = gimp_pdb_compat_arg_type_from_gtype
(G_PARAM_SPEC_VALUE_TYPE (pspecs[pspec_index]));
/* if the param spec's GType, mapped to a pdb type, matches
* the passed pdb type, use the param spec's GType
*/
if (pspec_arg_type == params[i].type)
{
type = G_PARAM_SPEC_VALUE_TYPE (pspecs[pspec_index]);
}
}
}