dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pdb: Allow off-canvas guides with Script-fu 

Commit 015f4946 allowed guides to be
placed off-canvas in the GUI. However,
the restrictions were not removed from
the Script-fu implementation.
This patch fixes the Script-fu parameters
and conditional checks to match the
GUI implementation.
This commit is contained in:
Alx Sa 2024-05-27 12:23:52 +00:00
parent fb94e576df
commit 1759174d9d
2 changed files with 20 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/pdb/image-guides-cmds.c
View File

@ -64,13 +64,11 @@ image_add_hguide_invoker (GimpProcedure *procedure,
if (success)
{
if (yposition <= gimp_image_get_height (image))
{
GimpGuide *g;
GimpGuide *g;
g = gimp_image_add_hguide (image, yposition, TRUE);
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
}
g = gimp_image_add_hguide (image, yposition, TRUE);
if (g)
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
else
success = FALSE;
}
@ -103,13 +101,11 @@ image_add_vguide_invoker (GimpProcedure *procedure,
if (success)
{
if (xposition <= gimp_image_get_width (image))
{
GimpGuide *g;
GimpGuide *g;
g = gimp_image_add_vguide (image, xposition, TRUE);
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
}
g = gimp_image_add_vguide (image, xposition, TRUE);
if (g)
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
else
success = FALSE;
}
@ -294,7 +290,7 @@ register_image_guides_procs (GimpPDB *pdb)
g_param_spec_int ("yposition",
"yposition",
"The guide's y-offset from top of image",
0, G_MAXINT32, 0,
G_MININT32, G_MAXINT32, 0,
GIMP_PARAM_READWRITE));
gimp_procedure_add_return_value (procedure,
g_param_spec_uint ("guide",
@ -329,7 +325,7 @@ register_image_guides_procs (GimpPDB *pdb)
g_param_spec_int ("xposition",
"xposition",
"The guide's x-offset from left of image",
0, G_MAXINT32, 0,
G_MININT32, G_MAXINT32, 0,
GIMP_PARAM_READWRITE));
gimp_procedure_add_return_value (procedure,
g_param_spec_uint ("guide",

24
pdb/groups/image_guides.pdb
View File

@ -30,7 +30,7 @@ HELP
@inargs = (
{ name => 'image', type => 'image',
desc => 'The image' },
{ name => 'yposition', type => '0 <= int32',
{ name => 'yposition', type => 'int32',
desc => "The guide's y-offset from top of image" }
);
@ -42,13 +42,11 @@ HELP
%invoke = (
code => <<'CODE'
{
if (yposition <= gimp_image_get_height (image))
{
GimpGuide *g;
GimpGuide *g;
g = gimp_image_add_hguide (image, yposition, TRUE);
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
}
g = gimp_image_add_hguide (image, yposition, TRUE);
if (g)
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
else
success = FALSE;
}
@ -70,7 +68,7 @@ HELP
@inargs = (
{ name => 'image', type => 'image',
desc => 'The image' },
{ name => 'xposition', type => '0 <= int32',
{ name => 'xposition', type => 'int32',
desc => "The guide's x-offset from left of image" }
);
@ -82,13 +80,11 @@ HELP
%invoke = (
code => <<'CODE'
{
if (xposition <= gimp_image_get_width (image))
{
GimpGuide *g;
GimpGuide *g;
g = gimp_image_add_vguide (image, xposition, TRUE);
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
}
g = gimp_image_add_vguide (image, xposition, TRUE);
if (g)
guide = gimp_aux_item_get_id (GIMP_AUX_ITEM (g));
else
success = FALSE;
}