From 12cb09836a4fbf4471a6a276eb4a0657236c8255 Mon Sep 17 00:00:00 2001
From: Michael Natterer <mitch@gimp.org>
Date: Sat, 1 Oct 2016 21:44:59 +0200
Subject: [PATCH] Bug 772303 - preferences > folders don't have tooltips

Add tooltips to all buttons and indicators of GimpFileEntry and
GimpPathEditor.
---
 libgimpwidgets/gimpfileentry.c  | 11 +++++++++--
 libgimpwidgets/gimppatheditor.c | 17 +++++++++++++++++
 2 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/libgimpwidgets/gimpfileentry.c b/libgimpwidgets/gimpfileentry.c
index efff5b8496..236bf4914d 100644
--- a/libgimpwidgets/gimpfileentry.c
+++ b/libgimpwidgets/gimpfileentry.c
@@ -149,7 +149,8 @@ gimp_file_entry_init (GimpFileEntry *entry)
                     entry);
 
   gimp_help_set_help_data (button,
-                           _("Show file location in the file manager"), NULL);
+                           _("Show file location in the file manager"),
+                           NULL);
 
   entry->browse_button = gtk_button_new ();
   gtk_box_pack_end (GTK_BOX (entry), entry->browse_button, FALSE, FALSE, 0);
@@ -225,7 +226,7 @@ gimp_file_entry_new (const gchar *title,
   entry->check_valid = check_valid;
 
   gimp_help_set_help_data (entry->browse_button,
-                           dir_only ?
+                           entry->dir_only ?
                            _("Open a file selector to browse your folders") :
                            _("Open a file selector to browse your files"),
                            NULL);
@@ -236,6 +237,12 @@ gimp_file_entry_new (const gchar *title,
                                                          GTK_ICON_SIZE_BUTTON);
       gtk_box_pack_start (GTK_BOX (entry), entry->file_exists, FALSE, FALSE, 0);
       gtk_widget_show (entry->file_exists);
+
+      gimp_help_set_help_data (entry->file_exists,
+                               entry->dir_only ?
+                               _("Indicates whether or not the folder exists") :
+                               _("Indicates whether or not the file exists"),
+                               NULL);
     }
 
   gimp_file_entry_set_filename (entry, filename);
diff --git a/libgimpwidgets/gimppatheditor.c b/libgimpwidgets/gimppatheditor.c
index 5966ff782b..50caa3a954 100644
--- a/libgimpwidgets/gimppatheditor.c
+++ b/libgimpwidgets/gimppatheditor.c
@@ -32,6 +32,7 @@
 #undef GIMP_DISABLE_DEPRECATED
 #include "gimpfileentry.h"
 
+#include "gimphelpui.h"
 #include "gimpicons.h"
 #include "gimppatheditor.h"
 #include "gimp3migration.h"
@@ -175,6 +176,10 @@ gimp_path_editor_init (GimpPathEditor *editor)
                     G_CALLBACK (gimp_path_editor_new_clicked),
                     editor);
 
+  gimp_help_set_help_data (editor->new_button,
+                           _("Add a new folder"),
+                           NULL);
+
   editor->up_button = button = gtk_button_new ();
   gtk_widget_set_sensitive (button, FALSE);
   gtk_box_pack_start (GTK_BOX (button_box), button, TRUE, TRUE, 0);
@@ -188,6 +193,10 @@ gimp_path_editor_init (GimpPathEditor *editor)
                     G_CALLBACK (gimp_path_editor_move_clicked),
                     editor);
 
+  gimp_help_set_help_data (editor->up_button,
+                           _("Move the selected folder up"),
+                           NULL);
+
   editor->down_button = button = gtk_button_new ();
   gtk_widget_set_sensitive (button, FALSE);
   gtk_box_pack_start (GTK_BOX (button_box), button, TRUE, TRUE, 0);
@@ -201,6 +210,10 @@ gimp_path_editor_init (GimpPathEditor *editor)
                     G_CALLBACK (gimp_path_editor_move_clicked),
                     editor);
 
+  gimp_help_set_help_data (editor->down_button,
+                           _("Move the selected folder down"),
+                           NULL);
+
   editor->delete_button = button = gtk_button_new ();
   gtk_widget_set_sensitive (button, FALSE);
   gtk_box_pack_start (GTK_BOX (button_box), button, TRUE, TRUE, 0);
@@ -214,6 +227,10 @@ gimp_path_editor_init (GimpPathEditor *editor)
                     G_CALLBACK (gimp_path_editor_delete_clicked),
                     editor);
 
+  gimp_help_set_help_data (editor->delete_button,
+                           _("Remove the selected folder from the list"),
+                           NULL);
+
   scrolled_window = gtk_scrolled_window_new (NULL, NULL);
   gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (scrolled_window),
                                        GTK_SHADOW_IN);