dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gimp/menus/meson.build

109 lines
3.0 KiB
Meson
Raw Normal View History

Meson port.
2017-11-01 21:27:13 +08:00
menus_dir = prefix / gimpdatadir / 'menus'
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
ui_menus_files = files(
app, menus: add an application menu for systems which wants this. In particular on macOS, we want to show some default common actions (see comments in !837) but gtk_application_prefers_app_menu() docs says that it will always return FALSE on this OS. So we ignore this call on macOS.
2023-04-05 06:46:35 +08:00
'app-menu.ui',
menus: add all the missing menus in the new GtkBuilder format! I was handling all the problematic cases first. These remaining menus are working fine otherwise by just implementing them, as far as my tests go.
2023-03-02 21:32:18 +08:00
'brush-editor-menu.ui',
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
'brushes-menu.ui',
'buffers-menu.ui',
'channels-menu.ui',
'colormap-menu.ui',
menus: add all the missing menus in the new GtkBuilder format! I was handling all the problematic cases first. These remaining menus are working fine otherwise by just implementing them, as far as my tests go.
2023-03-02 21:32:18 +08:00
'cursor-info-menu.ui',
menus: add dashboard-menu with proper placeholder support.
2023-03-01 23:09:10 +08:00
'dashboard-menu.ui',
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
'documents-menu.ui',
menus: add all the missing menus in the new GtkBuilder format! I was handling all the problematic cases first. These remaining menus are working fine otherwise by just implementing them, as far as my tests go.
2023-03-02 21:32:18 +08:00
'dynamics-editor-menu.ui',
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
'dynamics-menu.ui',
'error-console-menu.ui',
'fonts-menu.ui',
app: add the gradient editor submenu and a new concept of GimpRadioAction's… … group name. The gradient editor submenu add 2 submenus with changing names. It was using again bogus actions: "gradient-editor-blending-func" and "gradient-editor-coloring-type" do nothing except for being used as name holders. Instead I add the concept of group name for GimpRadioAction-s and when I use a radio action attribute as <submenu>, this submenu will use the group name (and sync with it, if it changes).
2023-02-28 20:51:09 +08:00
'gradient-editor-menu.ui',
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
'gradients-menu.ui',
'images-menu.ui',
'layers-menu.ui',
'mypaint-brushes-menu.ui',
menus: add all the missing menus in the new GtkBuilder format! I was handling all the problematic cases first. These remaining menus are working fine otherwise by just implementing them, as far as my tests go.
2023-03-02 21:32:18 +08:00
'palette-editor-menu.ui',
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
'palettes-menu.ui',
'patterns-menu.ui',
'quick-mask-menu.ui',
menus: add all the missing menus in the new GtkBuilder format! I was handling all the problematic cases first. These remaining menus are working fine otherwise by just implementing them, as far as my tests go.
2023-03-02 21:32:18 +08:00
'sample-points-menu.ui',
'selection-menu.ui',
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
'templates-menu.ui',
app, menus: use the new GimpToolbar in the GimpTextEditor.
2023-03-02 21:27:23 +08:00
'text-editor-toolbar.ui',
menus: add all the missing menus in the new GtkBuilder format! I was handling all the problematic cases first. These remaining menus are working fine otherwise by just implementing them, as far as my tests go.
2023-03-02 21:32:18 +08:00
'text-tool-menu.ui',
'tool-options-menu.ui',
'tool-preset-editor-menu.ui',
'tool-presets-menu.ui',
app, menus: now support the child menu of the GimpDockbook menu. I only translated the undo menu into GtkBuilder's .ui format for now. The only missing part is that the icon is now shown. Note that in various parts, I don't rely anymore on a bogus menu action (i.e. "undo-popup" action in this case) which does nothing but has an associated label and icon. I simply add the label and icon as submenu attribute directly in the .ui file, which is translatable and whose strings should be parsed by gettext. Eventually I'll just get rid of all the various "*-popup" or "*-menu" bogus actions.
2023-02-28 01:49:45 +08:00
'undo-menu.ui',
menus: add all the missing menus in the new GtkBuilder format! I was handling all the problematic cases first. These remaining menus are working fine otherwise by just implementing them, as far as my tests go.
2023-03-02 21:32:18 +08:00
'vector-toolpath-menu.ui',
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
'vectors-menu.ui',
)
install_data(ui_menus_files,
install_dir: menus_dir,
)
Meson port.
2017-11-01 21:27:13 +08:00
unstable_menus_args = stable ? [] : [ '--stringparam', 'unstable-menus', 'yes' ]
menus: add a dockable-menu with the new GtkBuilder format. The dialogs-menuitems is shared between dockable-menu and image-menu, just as it was with the old format. For this, we use XSL transformation with XInclude, then drop the namespace (because GTK doesn't like the unknown namespace being defined and crash immediately otherwise).
2023-02-23 04:29:08 +08:00
menus_ui_built_files = []
foreach menu_filegen : [ 'dockable-menu.ui', 'image-menu.ui', ]
menus: fix dialogs_dockable_actions being in 2 groups. Depending on where it's used, this list of action can be either in the "dockable" or the "dialogs" action group. The meson rule is a bit more complicated than I wished it were because of the ever-so-blocking lack of simple dependency in meson. Cf. my latest comment: https://github.com/mesonbuild/meson/issues/8123#issuecomment-1496168759
2023-04-04 23:28:49 +08:00
# This does look a bit overly complicated, but I encountered 2 issues:
# 1. The simpler solution was to do first the custom_target() then a single
# configure_file() per file. It didn't work out because of meson complex
# dependency logic (see https://github.com/mesonbuild/meson/issues/8123).
# 2. So I inverted, but now xsltproc was the one acting up by adding the
# 'xml:base' attribute when the included and including XML files are in
# different folders. This is why I added a second configure_file() to have
# both XML files in the same folder.
conf = configuration_data()
if menu_filegen == 'dockable-menu.ui'
group = 'dockable'
else
group = 'dialogs'
endif
conf.set('GROUP', group)
included_file = configure_file(
input: 'dialogs-menuitems.ui.in',
output: group + '-dialogs-menuitems.ui',
configuration: conf,
)
pre_built_file = configure_file(
input: menu_filegen + '.in.in',
output: menu_filegen + '.in',
configuration: conf,
)
menus: add a dockable-menu with the new GtkBuilder format. The dialogs-menuitems is shared between dockable-menu and image-menu, just as it was with the old format. For this, we use XSL transformation with XInclude, then drop the namespace (because GTK doesn't like the unknown namespace being defined and crash immediately otherwise).
2023-02-23 04:29:08 +08:00
menus_ui_built_files += custom_target(menu_filegen,
menus: fix dialogs_dockable_actions being in 2 groups. Depending on where it's used, this list of action can be either in the "dockable" or the "dialogs" action group. The meson rule is a bit more complicated than I wished it were because of the ever-so-blocking lack of simple dependency in meson. Cf. my latest comment: https://github.com/mesonbuild/meson/issues/8123#issuecomment-1496168759
2023-04-04 23:28:49 +08:00
input : [ pre_built_file, 'menus.xsl', included_file],
menus: add a dockable-menu with the new GtkBuilder format. The dialogs-menuitems is shared between dockable-menu and image-menu, just as it was with the old format. For this, we use XSL transformation with XInclude, then drop the namespace (because GTK doesn't like the unknown namespace being defined and crash immediately otherwise).
2023-02-23 04:29:08 +08:00
output: [ menu_filegen ],
command: [
xsltproc,
'--xinclude',
unstable_menus_args,
menus: fix dialogs_dockable_actions being in 2 groups. Depending on where it's used, this list of action can be either in the "dockable" or the "dialogs" action group. The meson rule is a bit more complicated than I wished it were because of the ever-so-blocking lack of simple dependency in meson. Cf. my latest comment: https://github.com/mesonbuild/meson/issues/8123#issuecomment-1496168759
2023-04-04 23:28:49 +08:00
'--path',
meson.current_build_dir(),
menus: add a dockable-menu with the new GtkBuilder format. The dialogs-menuitems is shared between dockable-menu and image-menu, just as it was with the old format. For this, we use XSL transformation with XInclude, then drop the namespace (because GTK doesn't like the unknown namespace being defined and crash immediately otherwise).
2023-02-23 04:29:08 +08:00
'--output', '@OUTPUT@',
'@INPUT1@',
'@INPUT0@',
],
install: true,
install_dir: menus_dir,
)
endforeach
Meson port.
2017-11-01 21:27:13 +08:00
if xmllint.found()
app, menus: very early prototype for a GimpMenu. This demonstrates a first version of our replacing menu, using GAction and GMenuModel. I had to make our own subclass of GtkMenu to process the model (from a .ui XML file) for the following reasons: * gtk_menu_new_from_model() doesn't support tooltips, which is a feature we use quite extensively in GIMP: with all our filters, being able to give a longer description is often useful; moreover we use tooltips to give hints about why a menu item is deactivated as well. Unfortunately it looks like GTK doesn't consider this lack as a problem and don't plan on adding tooltip support. See: https://gitlab.gnome.org/GNOME/gtk/-/issues/785 * I won't to avoid copying action's label and icons in the .ui file. This only duplicates strings and would be a source of issues each time we change action's strings (we'd have to do it in 2 places, which someone will inevitably forget). Now it still has various issues: * The syncing between actions and menu items need to be cleaned up. It's still in early demo code. * It uses directly some Gtk*Action code because GimpRadioAction and GimpToggleAction are not directly related right now (only through their parents). * gtk_application_set_menubar() might still be necessary on macOS as I think it's what enables the native menu system on this OS. It means that we'll have to edit the menu model to add back the labels (as this function does not extract these from the linked action since GAction has no label or icon concept). * Icons are not taken into account right now. * I'll have to verify if GimpAction with proxy work (but my guess is that right now, it won't). * Action's active state is not synced with menu item active state right now. * Various actions are inserted live, such as opened images, opened views, recently opened images, and so on. This needs to be implemented back. * Plug-ins need to be able to create their own menu item into this new menu. * For all these various reasons, I'm keeping the old menu around, for the sake of comparison, until the time the new one becomes feature-full. Part of this commit is inspired by !558 and obsoletes this MR.
2023-02-07 20:59:20 +08:00
# XXX: no DTD validation as GtkBuilder UI format does not have a DTD (as far as
# we could find).
custom_target('validate_ui_menus',
command: [
xmllint,
'--output', '@OUTPUT@',
'--path', meson.current_source_dir(),
menus: implement a bunch of menus in GtkBuilder format. It's not all of them yet, just the ones which work out of the box with current code and which I could easily trigger.
2023-02-24 04:15:40 +08:00
ui_menus_files, menus_ui_built_files
app, menus: very early prototype for a GimpMenu. This demonstrates a first version of our replacing menu, using GAction and GMenuModel. I had to make our own subclass of GtkMenu to process the model (from a .ui XML file) for the following reasons: * gtk_menu_new_from_model() doesn't support tooltips, which is a feature we use quite extensively in GIMP: with all our filters, being able to give a longer description is often useful; moreover we use tooltips to give hints about why a menu item is deactivated as well. Unfortunately it looks like GTK doesn't consider this lack as a problem and don't plan on adding tooltip support. See: https://gitlab.gnome.org/GNOME/gtk/-/issues/785 * I won't to avoid copying action's label and icons in the .ui file. This only duplicates strings and would be a source of issues each time we change action's strings (we'd have to do it in 2 places, which someone will inevitably forget). Now it still has various issues: * The syncing between actions and menu items need to be cleaned up. It's still in early demo code. * It uses directly some Gtk*Action code because GimpRadioAction and GimpToggleAction are not directly related right now (only through their parents). * gtk_application_set_menubar() might still be necessary on macOS as I think it's what enables the native menu system on this OS. It means that we'll have to edit the menu model to add back the labels (as this function does not extract these from the linked action since GAction has no label or icon concept). * Icons are not taken into account right now. * I'll have to verify if GimpAction with proxy work (but my guess is that right now, it won't). * Action's active state is not synced with menu item active state right now. * Various actions are inserted live, such as opened images, opened views, recently opened images, and so on. This needs to be implemented back. * Plug-ins need to be able to create their own menu item into this new menu. * For all these various reasons, I'm keeping the old menu around, for the sake of comparison, until the time the new one becomes feature-full. Part of this commit is inspired by !558 and obsoletes this MR.
2023-02-07 20:59:20 +08:00
],
# The output file is only useful as a flag file, so that the command
# knows if it has been run already.
output: [ 'validate_ui_menus-output.xml' ],
build_by_default: true,
install: false
)
Meson port.
2017-11-01 21:27:13 +08:00
endif